[PATCH 1/2] doc/features: describe distribution feature pni-name

[PATCH 1/2] doc/features: describe distribution feature pni-name

[Jörg Sommer]

From: Jörg Sommer <joerg.sommer@navimatix.de>

Signed-off-by: Jörg Sommer <joerg.sommer@navimatix.de>
---
 documentation/ref-manual/features.rst | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/documentation/ref-manual/features.rst b/documentation/ref-manual/features.rst
index 2ea946b31d..81f09f59d8 100644
--- a/documentation/ref-manual/features.rst
+++ b/documentation/ref-manual/features.rst
@@ -197,6 +197,10 @@ metadata, as extra layers can define their own:
 
 -  *pcmcia:* Include PCMCIA/CompactFlash support.
 
+-  *pni-names:* Enable generation of persistent network interface names,
+   i.e. it's tried hard to get the same but unique names for the network
+   interfaces even after a reinstall.
+
 -  *polkit:* Include :wikipedia:`Polkit <Polkit>` support.
 
 -  *ppp:* Include PPP dialup support.
-- 
2.34.1

[PATCH 2/2] doc/features: remove duplicate word in distribution feature ext2

[Jörg Sommer]

From: Jörg Sommer <joerg.sommer@navimatix.de>

Signed-off-by: Jörg Sommer <joerg.sommer@navimatix.de>
---
 documentation/ref-manual/features.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/documentation/ref-manual/features.rst b/documentation/ref-manual/features.rst
index 81f09f59d8..88ffac091a 100644
--- a/documentation/ref-manual/features.rst
+++ b/documentation/ref-manual/features.rst
@@ -146,7 +146,7 @@ metadata, as extra layers can define their own:
 
 -  *directfb:* Include DirectFB support.
 
--  *ext2:* Include tools for supporting for devices with internal
+-  *ext2:* Include tools for supporting devices with internal
    HDD/Microdrive for storing files (instead of Flash only devices).
 
 -  *gobject-introspection-data:* Include data to support
-- 
2.34.1

Re: [docs] [PATCH 2/2] doc/features: remove duplicate word in distribution feature ext2

[Quentin Schulz]

Hi Jörg,

On 8/30/24 1:40 PM, Jörg Sommer via lists.yoctoproject.org wrote:
> From: Jörg Sommer <joerg.sommer@navimatix.de>
> 
> Signed-off-by: Jörg Sommer <joerg.sommer@navimatix.de>

Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>

Thanks!
Quentin

Re: [docs] [PATCH 1/2] doc/features: describe distribution feature pni-name

[Quentin Schulz]

Hi Jörg,

On 8/30/24 1:40 PM, Jörg Sommer via lists.yoctoproject.org wrote:
> From: Jörg Sommer <joerg.sommer@navimatix.de>
> 
> Signed-off-by: Jörg Sommer <joerg.sommer@navimatix.de>
> ---
>   documentation/ref-manual/features.rst | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/documentation/ref-manual/features.rst b/documentation/ref-manual/features.rst
> index 2ea946b31d..81f09f59d8 100644
> --- a/documentation/ref-manual/features.rst
> +++ b/documentation/ref-manual/features.rst
> @@ -197,6 +197,10 @@ metadata, as extra layers can define their own:
>   
>   -  *pcmcia:* Include PCMCIA/CompactFlash support.
>   
> +-  *pni-names:* Enable generation of persistent network interface names,
> +   i.e. it's tried hard to get the same but unique names for the network
> +   interfaces even after a reinstall.
> +

I'm a bit bothered by "it's tried hard to get". I could suggest:

"""
the system tries hard to have the same but unique names for the network 
interfaces even after a reinstall.
"""

Whatever works best, not sure it's any better. In any case,

Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>

@Alex: A `git log -S pni-names` in poky returns commits that started in 
scarthgap, and all of them are available in scarthgap, therefore I 
believe this matches the requirements for backporting to scarthgap too.

Thanks!
Quentin

Re: [docs] [PATCH 1/2] doc/features: describe distribution feature pni-name

[Jörg Sommer]

[-- Attachment #1: Type: text/plain, Size: 1317 bytes --]

Quentin Schulz schrieb am Fr 30. Aug, 14:19 (GMT):
> On 8/30/24 1:40 PM, Jörg Sommer via lists.yoctoproject.org wrote:
> > From: Jörg Sommer <joerg.sommer@navimatix.de>
> > 
> > Signed-off-by: Jörg Sommer <joerg.sommer@navimatix.de>
> > ---
> >   documentation/ref-manual/features.rst | 4 ++++
> >   1 file changed, 4 insertions(+)
> > 
> > diff --git a/documentation/ref-manual/features.rst b/documentation/ref-manual/features.rst
> > index 2ea946b31d..81f09f59d8 100644
> > --- a/documentation/ref-manual/features.rst
> > +++ b/documentation/ref-manual/features.rst
> > @@ -197,6 +197,10 @@ metadata, as extra layers can define their own:
> >   -  *pcmcia:* Include PCMCIA/CompactFlash support.
> > +-  *pni-names:* Enable generation of persistent network interface names,
> > +   i.e. it's tried hard to get the same but unique names for the network
> > +   interfaces even after a reinstall.
> > +
> 
> I'm a bit bothered by "it's tried hard to get". I could suggest:
> 
> """
> the system tries hard to have the same but unique names for the network
> interfaces even after a reinstall.
> """
> 
> Whatever works best, not sure it's any better.

I'm open for any suggestions. I'm not a native speaker and better in writing
code than texts.

I'll send a v2 for this patch.

-- 

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5068 bytes --]

[PATCH] doc/features: describe distribution feature pni-name

[Jörg Sommer]

From: Jörg Sommer <joerg.sommer@navimatix.de>

Signed-off-by: Jörg Sommer <joerg.sommer@navimatix.de>
Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
---
 documentation/ref-manual/features.rst | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/documentation/ref-manual/features.rst b/documentation/ref-manual/features.rst
index 2ea946b31d..72e7315197 100644
--- a/documentation/ref-manual/features.rst
+++ b/documentation/ref-manual/features.rst
@@ -197,6 +197,10 @@ metadata, as extra layers can define their own:
 
 -  *pcmcia:* Include PCMCIA/CompactFlash support.
 
+-  *pni-names:* Enable generation of persistent network interface names, i.e.
+   the system tries hard to have the same but unique names for the network
+   interfaces even after a reinstall.
+
 -  *polkit:* Include :wikipedia:`Polkit <Polkit>` support.
 
 -  *ppp:* Include PPP dialup support.
-- 
2.34.1

Re: [PATCH] doc/features: describe distribution feature pni-name

[Quentin Schulz]

Hi Jörg,

Please try to add the v2 when sending the second version of a patch so 
the maintainer doesn't have to guess which one is the latest from their 
inbox. Also try to add below the --- what changed between v1 and v2.

No need to do this now I believe? Let's see if the maintainer(s) say the 
opposite.

Cheers,
Quentin

On 8/31/24 9:14 AM, Jörg Sommer wrote:
> From: Jörg Sommer <joerg.sommer@navimatix.de>
> 
> Signed-off-by: Jörg Sommer <joerg.sommer@navimatix.de>
> Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
> ---
>   documentation/ref-manual/features.rst | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/documentation/ref-manual/features.rst b/documentation/ref-manual/features.rst
> index 2ea946b31d..72e7315197 100644
> --- a/documentation/ref-manual/features.rst
> +++ b/documentation/ref-manual/features.rst
> @@ -197,6 +197,10 @@ metadata, as extra layers can define their own:
>   
>   -  *pcmcia:* Include PCMCIA/CompactFlash support.
>   
> +-  *pni-names:* Enable generation of persistent network interface names, i.e.
> +   the system tries hard to have the same but unique names for the network
> +   interfaces even after a reinstall.
> +
>   -  *polkit:* Include :wikipedia:`Polkit <Polkit>` support.
>   
>   -  *ppp:* Include PPP dialup support.

Re: [PATCH] doc/features: describe distribution feature pni-name

[Jörg Sommer]

[-- Attachment #1: Type: text/plain, Size: 449 bytes --]

Quentin Schulz schrieb am Mo 02. Sep, 10:42 (GMT):
> Hi Jörg,
> 
> Please try to add the v2 when sending the second version of a patch so the
> maintainer doesn't have to guess which one is the latest from their inbox.

Yes, you're right. I've realised it the moment git-send-email printed the
subject.

> Also try to add below the --- what changed between v1 and v2.

Is there a git-send-email option to do so easily?


Regards Jörg

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5068 bytes --]

Re: [PATCH] doc/features: describe distribution feature pni-name

[Quentin Schulz]

Hi Jörg,

On 9/2/24 10:59 AM, Jörg Sommer wrote:
> Quentin Schulz schrieb am Mo 02. Sep, 10:42 (GMT):
>> Hi Jörg,
>>
>> Please try to add the v2 when sending the second version of a patch so the
>> maintainer doesn't have to guess which one is the latest from their inbox.
> 
> Yes, you're right. I've realised it the moment git-send-email printed the
> subject.
> 
>> Also try to add below the --- what changed between v1 and v2.
> 
> Is there a git-send-email option to do so easily?
> 

Not that I'm aware. I used to use git-format-patch and then edit the 
patches by hand if I remember correctly. I've personally switched to 
b4[1] about 2 years ago for my contributions to different projects and 
the diff between versions is stored in the cover-letter, which is stored 
as an empty commit on top of your series. If there's only one patch in 
the series, the content of the cover-letter is added below the --- of 
the patch.

[1] https://b4.docs.kernel.org/en/latest/contributor/overview.html

Cheers,
Quentin

Re: [docs] [PATCH] doc/features: describe distribution feature pni-name

[Alexandre Belloni]

On 02/09/2024 10:59:14+0200, J�rg Sommer via lists.yoctoproject.org wrote:
> Quentin Schulz schrieb am Mo 02. Sep, 10:42 (GMT):
> > Hi J�rg,
> > 
> > Please try to add the v2 when sending the second version of a patch so the
> > maintainer doesn't have to guess which one is the latest from their inbox.
> 
> Yes, you're right. I've realised it the moment git-send-email printed the
> subject.
> 
> > Also try to add below the --- what changed between v1 and v2.
> 
> Is there a git-send-email option to do so easily?
> 

git format-patch -v2 will tweak the subject line properly.



> 
> Regards J�rg



> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#5348): https://lists.yoctoproject.org/g/docs/message/5348
> Mute This Topic: https://lists.yoctoproject.org/mt/108192394/3617179
> Group Owner: docs+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/docs/unsub [alexandre.belloni@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com