public inbox for docs@lists.yoctoproject.org
 help / color / mirror / Atom feed
From: Michael Opdenacker <michael.opdenacker@bootlin.com>
To: Quentin Schulz <foss@0leil.net>,
	Quentin Schulz <quentin.schulz@theobroma-systems.com>,
	docs@lists.yoctoproject.org
Cc: Quentin Schulz <foss+yocto@0leil.net>
Subject: Re: [docs] [PATCH 1/4] docs: sdk-manual: appendix-obtain: fix literal block content
Date: Thu, 22 Jun 2023 23:02:39 +0200	[thread overview]
Message-ID: <3abb9990-047d-fb77-962b-2b5e80dbd95a@bootlin.com> (raw)
In-Reply-To: <20230622-typos-202306-v1-1-68489d7f23f2@theobroma-systems.com>

Hi Quentin

On 22.06.23 at 18:51, Quentin Schulz wrote:
> From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
>
> The literal block renders its content verbatim so a term role (`:term:`)
> would appear as :term: string in there and `---` as --- string instead
> of the expected hyphen.
>
> While at it, surround the former-term roles with `` to highlight them.
>
> Fixes: e319b3bf4eb6 ("manuals: add missing references to SDKMACHINE and SDK_ARCH")
> Cc: Quentin Schulz <foss+yocto@0leil.net>
> Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
> ---
>   documentation/sdk-manual/appendix-obtain.rst | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/documentation/sdk-manual/appendix-obtain.rst b/documentation/sdk-manual/appendix-obtain.rst
> index ba844507d..e16017de7 100644
> --- a/documentation/sdk-manual/appendix-obtain.rst
> +++ b/documentation/sdk-manual/appendix-obtain.rst
> @@ -140,8 +140,8 @@ build the SDK installer. Follow these steps:
>         message similar to the following::
>   
>            The extensible SDK can currently only be built for the same
> -         architecture as the machine being built on --- :term:`SDK_ARCH`
> -         is set to ``i686`` (likely via setting :term:`SDKMACHINE`) which is
> +         architecture as the machine being built on --- ``SDK_ARCH``
> +         is set to ``i686`` (likely via setting ``SDKMACHINE`` which is
>            different from the architecture of the build machine (``x86_64``).


Thanks, but actually, we should return to what the message should be like:

- "-" instead of "---"

- "SDKMACHINE" instead of "``SDKMACHINE`` and the same for SDK_ARCH.

Originally, the message was:
"The extensible SDK can currently only be built for the same 
architecture as the machine being built on - SDK_ARCH is
  set to i686 (likely via setting SDKMACHINE) which is different from 
the architecture of the build machine (x86_64).
Unable to continue."

Would you have time to correct this? I can do it too :)

Cheers
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



  reply	other threads:[~2023-06-22 21:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-22 16:51 [PATCH 0/4] fix some doc typos Quentin Schulz
2023-06-22 16:51 ` [PATCH 1/4] docs: sdk-manual: appendix-obtain: fix literal block content Quentin Schulz
2023-06-22 21:02   ` Michael Opdenacker [this message]
2023-06-22 16:51 ` [PATCH 2/4] docs: ref-manual: terms: fix typos in SPDX term Quentin Schulz
2023-06-22 16:51 ` [PATCH 3/4] docs: fix unnecessary double white space Quentin Schulz
2023-06-22 16:51 ` [PATCH 4/4] docs: ref-manual: terms: fix incorrect note directive Quentin Schulz
2023-06-22 21:09 ` [docs] [PATCH 0/4] fix some doc typos Michael Opdenacker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3abb9990-047d-fb77-962b-2b5e80dbd95a@bootlin.com \
    --to=michael.opdenacker@bootlin.com \
    --cc=docs@lists.yoctoproject.org \
    --cc=foss+yocto@0leil.net \
    --cc=foss@0leil.net \
    --cc=quentin.schulz@theobroma-systems.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox