Re: [docs] [PATCH 3/6] overview-manual: convert configuration-compile-autoreconf.png to svg

[Quentin Schulz <quentin.schulz@cherry.de>]

Hi Antonin,

On 2/24/25 10:19 AM, Antonin Godard wrote:
> Hi Quentin,
> 
> On Thu Feb 20, 2025 at 5:13 PM CET, Quentin Schulz wrote:
>> Hi Antonin,
>>
>> On 2/18/25 10:11 AM, Antonin Godard via lists.yoctoproject.org wrote:
>>> Convert the png file to an SVG file, and add the UNPACKDIR reference.
>>>
>>
>> The arrows for the build directory are misaligned, especially for the
>> machine-specific package.
> 
> Yes, I noticed afterwards too. There were some font issues, rsvg-convert was not
> properly picking them up. And also having so many arrows require precision that
> is not taken into account when converting from SVGs to PNGs.
> 
> In the end, I think having the different arrows as text (for the rightmost part)
> is much better and will always meet the alignment no matter what the font is.
> E.g:
> 
>    ${PV} -------- WORKDIR
> 

Maybe

${PV} <------- WORKDIR

?

> So now the output is this:
> https://lufi.bootlin.com/r/EuK0sscTNP#uV4rb2CQCPCMXONMGiBTfR9PY8BTDm0g0xeIAI+AsH8=
> 
> What do you think?
> 

I do not see much of a difference with "real" arrows, so that's fine by 
me :)

>> I'm also a bit skeptical about the position of the star before
>> EXTRA_OECONF, it feels like it's somehow part of the variable name.
>> Maybe add a space or make the star appear a bit higher (like in the
>> current PNG?).
> 
> I will adjust that.
> 
>> A remark for the original content as well, but I don't really understand
>> why B isn't passed to do_configure and do_install as well? Isn't it
>> where build artifacts will be configured before do_compile runs and from
>> where do_install will run in order to install files into $D?
>>
>> do_configure[dirs] = "${B}"
>> do_install[dirs] = "${B}"
>>
>> in base.bbclass for example.
>>
>> I'm wondering also if we shouldn't have a bidirectional arrow for B for
>> the configure and compile task as they are run from there, i.e. they
>> generate files in there as well?
> 
> I agree, B is used in all three.
> 
> For do_install, I guess a unidirectional arrow would make more sense as D is
> already used to point towards the other way.
> 

Unidirectional D arrow makes sense to me as there's nothing D before 
do_install I think?

Now to come to think of it, I'm not sure there's anything in B before 
do_configure? So should we have unidirectional for do_configure and 
bidirectional for do_compile?

Cheers,
Quentin