[PATCH v4 0/4] Cover systemd.bbclass and devtool ide-sdk changes

[PATCH v4 0/4] Cover systemd.bbclass and devtool ide-sdk changes

[Adrian Freihofer]

Changes of v4 in comparison to v3:
- Suggestions from https://lists.yoctoproject.org/g/docs/message/6091
- Release notes: cover devtool modify --debug-build

Adrian Freihofer (4):
  migration-guides: systemd.bbclass do not add Also services for 5.2
  sdk-manual: extensible.rst: update devtool ide-sdk
  sdk-manual: extensible.rst: remove confusing post-install-logging
  release-notes-5.2: cover devtool modify --debug-build

 .../migration-guides/migration-5.2.rst        | 20 +++++++++++++++++++
 .../migration-guides/release-notes-5.2.rst    |  6 ++++++
 documentation/sdk-manual/extensible.rst       |  8 ++++----
 3 files changed, 30 insertions(+), 4 deletions(-)

-- 
2.47.1

[PATCH v4 1/4] migration-guides: systemd.bbclass do not add Also services for 5.2

[Adrian Freihofer]

From: Adrian Freihofer <adrian.freihofer@gmail.com>

Covers the changes introduced by commit
https://git.yoctoproject.org/poky/commit/?id=efa5f65c2214239ed7aaf7bd8998683e755c5660

Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com>
Reviewed-by: Antonin Godard <antonin.godard@bootlin.com>
---
 .../migration-guides/migration-5.2.rst        | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/documentation/migration-guides/migration-5.2.rst b/documentation/migration-guides/migration-5.2.rst
index cb70e19da0c..c317587ee5a 100644
--- a/documentation/migration-guides/migration-5.2.rst
+++ b/documentation/migration-guides/migration-5.2.rst
@@ -74,6 +74,26 @@ systemd changes
    As a consequence, the ``systemd`` recipe no longer contains the ``usrmerge``
    :term:`PACKAGECONFIG` option as it is now implied by default.
 
+-  ``systemd.bbclass``: If a ``systemd`` service file had referred to other service
+   files by starting them via
+   `Also <https://www.freedesktop.org/software/systemd/man/latest/systemd.unit.html#Also=>`__,
+   the other service files were automatically added to the :term:`FILES` variable of
+   the same package. Example: 
+
+   a.service contains::
+
+      [Install]
+      Also=b.service
+
+   If ``a.service`` is packaged in package ``A``, ``b.service`` is automatically
+   packaged into package ``A`` as well. This happens even if ``b.service`` is
+   explicitly added to package ``B`` using :term:`FILES` and
+   :term:`SYSTEMD_SERVICE` variables.
+   This prevents such services from being packaged into different packages.
+   Therefore, this automatic behavior has been removed for service files (but
+   not for socket files).
+   Now all service files must be explicitly added to :term:`FILES`.
+
 Recipe changes
 ~~~~~~~~~~~~~~
 
-- 
2.47.1

Re: [docs] [PATCH v4 1/4] migration-guides: systemd.bbclass do not add Also services for 5.2

[Quentin Schulz]

Hi Adrian,

On 1/14/25 9:07 PM, Adrian Freihofer via lists.yoctoproject.org wrote:
> From: Adrian Freihofer <adrian.freihofer@gmail.com>
> 
> Covers the changes introduced by commit
> https://git.yoctoproject.org/poky/commit/?id=efa5f65c2214239ed7aaf7bd8998683e755c5660
> 
> Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com>
> Reviewed-by: Antonin Godard <antonin.godard@bootlin.com>
> ---
>   .../migration-guides/migration-5.2.rst        | 20 +++++++++++++++++++
>   1 file changed, 20 insertions(+)
> 
> diff --git a/documentation/migration-guides/migration-5.2.rst b/documentation/migration-guides/migration-5.2.rst
> index cb70e19da0c..c317587ee5a 100644
> --- a/documentation/migration-guides/migration-5.2.rst
> +++ b/documentation/migration-guides/migration-5.2.rst
> @@ -74,6 +74,26 @@ systemd changes
>      As a consequence, the ``systemd`` recipe no longer contains the ``usrmerge``
>      :term:`PACKAGECONFIG` option as it is now implied by default.
>   
> +-  ``systemd.bbclass``: If a ``systemd`` service file had referred to other service
> +   files by starting them via
> +   `Also <https://www.freedesktop.org/software/systemd/man/latest/systemd.unit.html#Also=>`__,
> +   the other service files were automatically added to the :term:`FILES` variable of
> +   the same package. Example:
> +
> +   a.service contains::
> +
> +      [Install]
> +      Also=b.service
> +
> +   If ``a.service`` is packaged in package ``A``, ``b.service`` is automatically
> +   packaged into package ``A`` as well. This happens even if ``b.service`` is
> +   explicitly added to package ``B`` using :term:`FILES` and
> +   :term:`SYSTEMD_SERVICE` variables.
 > +   This prevents such services from being packaged into different 
packages.

I believe there's some misleading use of the present tense?

This behavior is fixed no?

So I would suggest the following:

"""
If ``a.service`` is packaged in package ``A``, ``b.service`` was 
automatically
packaged into package ``A`` as well. This happened even if ``b.service`` was
explicitly added to package ``B`` using :term:`FILES` and
:term:`SYSTEMD_SERVICE` variables.
This prevented such services from being packaged into different packages.
"""

Does this make sense?

Cheers,
Quentin

[PATCH v4 2/4] sdk-manual: extensible.rst: update devtool ide-sdk

[Adrian Freihofer]

From: Adrian Freihofer <adrian.freihofer@gmail.com>

Replace
  devtool ide-sdk --debug-build-config
by
  devtool modify --debug-build

This change was introduced with commit
https://git.yoctoproject.org/poky/commit/?id=1f7eb26c947dde14698ae6e2ab88f0637027f4cb

Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com>
---
 documentation/sdk-manual/extensible.rst | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/documentation/sdk-manual/extensible.rst b/documentation/sdk-manual/extensible.rst
index 9a50d7fc54c..3733997fac4 100644
--- a/documentation/sdk-manual/extensible.rst
+++ b/documentation/sdk-manual/extensible.rst
@@ -669,7 +669,8 @@ The extensible SDK supports two different development modes.
       IMAGE_INSTALL:append = " my-recipe"
 
    Assuming the BitBake environment is set up correctly and a workspace has
-   been created for the recipe using ``devtool modify my-recipe``, the
+   been created for the recipe using ``devtool modify my-recipe`` or probably
+   even better by using ``devtool modify my-recipe --debug-build``, the
    following command can create the SDK and the configuration for VSCode in
    the recipe workspace::
 
@@ -786,8 +787,8 @@ The extensible SDK supports two different development modes.
    .. code-block:: sh
 
       # Create the SDK
-      devtool modify cmake-example
-      devtool ide-sdk cmake-example core-image-minimal -c --debug-build-config --ide=none
+      devtool modify cmake-example --debug-build
+      devtool ide-sdk cmake-example core-image-minimal -c --ide=none
 
       # Install the firmware on a target device or start QEMU
       runqemu
-- 
2.47.1

Re: [docs] [PATCH v4 2/4] sdk-manual: extensible.rst: update devtool ide-sdk

[Quentin Schulz]

Hi Adrian,

On 1/14/25 9:07 PM, Adrian Freihofer via lists.yoctoproject.org wrote:
> From: Adrian Freihofer <adrian.freihofer@gmail.com>
> 
> Replace
>    devtool ide-sdk --debug-build-config
> by
>    devtool modify --debug-build
> 
> This change was introduced with commit
> https://git.yoctoproject.org/poky/commit/?id=1f7eb26c947dde14698ae6e2ab88f0637027f4cb
> 
> Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com>

Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>

Thanks!
Quentin

[PATCH v4 3/4] sdk-manual: extensible.rst: remove confusing post-install-logging

[Adrian Freihofer]

From: Adrian Freihofer <adrian.freihofer@gmail.com>

This is a fix for 22dc5b3be3b1fbdb9447999b71f79db055271826, which has
completely replaced debug-tweaks. But in the context of devtool ide-sdk
and the comment in the example, the post-install-logging-image feature
doesn't really make much sense. Therefore, remove it.

Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com>
---
 documentation/sdk-manual/extensible.rst | 1 -
 1 file changed, 1 deletion(-)

diff --git a/documentation/sdk-manual/extensible.rst b/documentation/sdk-manual/extensible.rst
index 3733997fac4..1cb1bb47c2c 100644
--- a/documentation/sdk-manual/extensible.rst
+++ b/documentation/sdk-manual/extensible.rst
@@ -658,7 +658,6 @@ The extensible SDK supports two different development modes.
          allow-empty-password \
          allow-root-login \
          empty-root-password \
-         post-install-logging \
       "
 
       # Remote debugging needs gdbserver on the target device
-- 
2.47.1

[PATCH v4 4/4] release-notes-5.2: cover devtool modify --debug-build

[Adrian Freihofer]

Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com>
---
 documentation/migration-guides/release-notes-5.2.rst | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/documentation/migration-guides/release-notes-5.2.rst b/documentation/migration-guides/release-notes-5.2.rst
index 0eef448330d..06dce8d17a4 100644
--- a/documentation/migration-guides/release-notes-5.2.rst
+++ b/documentation/migration-guides/release-notes-5.2.rst
@@ -243,6 +243,12 @@ New Features / Enhancements in |yocto-ver|
    -  Remove the "S = WORKDIR" workaround as now :term:`S` cannot be equal to
       :term:`WORKDIR`.
 
+   -  The already broken ``--debug-build-config`` option of
+      ``devtool ide-sdk`` has been replaced by a new ``--debug-build`` option
+      of ``devtool modify``. The new ``devtool ide-sdk`` workflow is:
+      ``devtool modify my-recipe --debug-build`` followed by
+      ``devtool ide-sdk my-recipe my-image``.
+
 -  Patchtest-related changes:
 
    -  Refactor pattern definitions in a ``patterns`` module.
-- 
2.47.1

Re: [docs] [PATCH v4 4/4] release-notes-5.2: cover devtool modify --debug-build

[Quentin Schulz]

Hi Adrian,

On 1/14/25 9:07 PM, Adrian Freihofer via lists.yoctoproject.org wrote:
> Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com>

Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>

Thanks for doing that!
Quentin

Re: [PATCH v4 0/4] Cover systemd.bbclass and devtool ide-sdk changes

[Antonin Godard]

On Tue, 14 Jan 2025 21:07:10 +0100, Adrian Freihofer wrote:
> Changes of v4 in comparison to v3:
> - Suggestions from https://lists.yoctoproject.org/g/docs/message/6091
> - Release notes: cover devtool modify --debug-build
> 
> Adrian Freihofer (4):
>   migration-guides: systemd.bbclass do not add Also services for 5.2
>   sdk-manual: extensible.rst: update devtool ide-sdk
>   sdk-manual: extensible.rst: remove confusing post-install-logging
>   release-notes-5.2: cover devtool modify --debug-build
> 
> [...]

Applied, thanks!

[1/4] migration-guides: systemd.bbclass do not add Also services for 5.2
      commit: 71acf03e02d1e21a4dbe081e75d1e4383ac2f3ac
[2/4] sdk-manual: extensible.rst: update devtool ide-sdk
      commit: e2b6a4c6c633e79d0e4975ba2e1a27a8c1b8c1c5
[3/4] sdk-manual: extensible.rst: remove confusing post-install-logging
      commit: 148191460627241cbd0c42583140f114c78cc94c
[4/4] release-notes-5.2: cover devtool modify --debug-build
      commit: ef5f35e6da2dcdfad6290ab4d5bfa3010a600caf

Best regards,
-- 
Antonin Godard <antonin.godard@bootlin.com>