From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF6D3C636D3 for ; Sun, 12 Feb 2023 22:02:23 +0000 (UTC) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [85.220.165.71]) by mx.groups.io with SMTP id smtpd.web11.1179.1676239334632564111 for ; Sun, 12 Feb 2023 14:02:15 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: pengutronix.de, ip: 85.220.165.71, mailfrom: u.oelmann@pengutronix.de) Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pRKQG-0005iD-G2 for docs@lists.yoctoproject.org; Sun, 12 Feb 2023 23:02:12 +0100 Received: from uol by pty.hi.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pRKQE-002vAL-VK for docs@lists.yoctoproject.org; Sun, 12 Feb 2023 23:02:10 +0100 References: <174331ACAD9BF3F3.21535@lists.yoctoproject.org> User-agent: mu4e 1.6.9; emacs 29.0.50 From: Ulrich =?utf-8?Q?=C3=96lmann?= To: docs@lists.yoctoproject.org Subject: Re: [docs] [PATCH] ref-manual: add missing quotes Date: Sun, 12 Feb 2023 22:45:59 +0100 In-reply-to: <174331ACAD9BF3F3.21535@lists.yoctoproject.org> Message-ID: <6r7cwmpmot.fsf@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: u.oelmann@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: docs@lists.yoctoproject.org List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Sun, 12 Feb 2023 22:02:23 -0000 X-Groupsio-URL: https://lists.yoctoproject.org/g/docs/message/3666 Hi there, On Sun, Feb 12 2023 at 22:41 +0100, Ulrich =C3=96lmann wrote: > Signed-off-by: Ulrich =C3=96lmann > --- > documentation/ref-manual/variables.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/documentation/ref-manual/variables.rst b/documentation/ref-m= anual/variables.rst > index a36c4c6df962..c561aae6563a 100644 > --- a/documentation/ref-manual/variables.rst > +++ b/documentation/ref-manual/variables.rst > @@ -4275,7 +4275,7 @@ system and gives an overview of their function and = contents. > To use the variable, set it in the append file for your kernel rec= ipe > using the following form:: > > - KBUILD_DEFCONFIG_KMACHINE ?=3D defconfig_file > + KBUILD_DEFCONFIG_KMACHINE ?=3D "defconfig_file" I did not find any occurance of a variable named "KBUILD_DEFCONFIG_ KMACHINE" in kernel-yocto.bbclass and from the above line's context my feeling is that the last underscore was meant to be the old override syntax which should be updated to ":" now. If this is correct then I would additionally expect the override not to be KMACHINE but MACHINE instead as only the latter is a valid override. Could someone with more insight please confirm or reject my suspicion? In case of positive feedback I would gladly send another patch doing a s/KBUILD_DEFCONFIG_KMACHINE/KBUILD_DEFCONFIG:MACHINE/ that changes both occurances in ref-manual/variables.rst and kernel-dev/ common.rst. Best regards Ulrich > Here is an example from a "raspberrypi2" :term:`KMACHINE` build th= at uses > a ``defconfig`` file named "bcm2709_defconfig":: --=20 Pengutronix e.K. | Ulrich =C3=96lmann = | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |