From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
To: Antonin Godard <antonin.godard@bootlin.com>, docs@lists.yoctoproject.org
Cc: michael.opdenacker@rootcommit.com
Subject: Re: [docs] [PATCH 3/3] dev-manual/bmaptool.rst: simplify and fix instructions
Date: Wed, 04 Dec 2024 09:26:43 +0000 (UTC) [thread overview]
Message-ID: <7fa75108-fb1b-4d62-babc-054888a076d3@rootcommit.com> (raw)
In-Reply-To: <D613DE1UW3GV.OXCJKSG2VQH6@bootlin.com>
Hi Antonin
Thanks for the review!
On 12/2/24 10:02, Antonin Godard wrote:
> Hi Michael,
>
> On Sun Dec 1, 2024 at 6:38 PM CET, Michael Opdenacker via lists.yoctoproject.org wrote:
>> From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>>
>> - Remove duplicate instructions
>>
>> - Detail how to run bmaptool directly if you installed it on your host
>> instead of building it through the ``bmaptool-native`` recipe,
>> as running "oe-run-native bmaptool-native bmaptool ..." won't work
>> in this case.
>>
>> Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>> ---
>> documentation/dev-manual/bmaptool.rst | 12 +++++++-----
>> 1 file changed, 7 insertions(+), 5 deletions(-)
>>
>> diff --git a/documentation/dev-manual/bmaptool.rst b/documentation/dev-manual/bmaptool.rst
>> index 5fc46c7792..e17074b65b 100644
>> --- a/documentation/dev-manual/bmaptool.rst
>> +++ b/documentation/dev-manual/bmaptool.rst
>> @@ -44,14 +44,16 @@ any type of image. Use these steps to flash an image using `bmaptool`:
>> depending on your particular setup. The following commands assume the
>> image resides in the :term:`Build Directory`'s ``deploy/images/`` area:
>>
>> - - If you have write access to the media, use this command form::
>> + - If needed, set permissions to get write access to the media::
>>
>> - $ oe-run-native bmaptool-native bmaptool copy build-directory/tmp/deploy/images/machine/image.wic /dev/sdX
>> + $ such chmod 666 /dev/sdX
> I know this was already instructed before, but maybe `chmod o+w` is a better
> practice and advice to give. What do you think?
I wondered too. Let's do it, I agree.
>
> Also I think this recommendation could be given after the sudo command, since it
> shouldn't be a problem to write to the device as root. I'm assuming the `chmod
> o+w` instruction was added here because oe-run-native doesn't run as root.
Right, this makes no sense to give this recommendation before "sudo".
My V2 will recommend chmod right before running oe-run-native.
Cheers
Michael.
--
Michael Opdenacker
Root Commit
Embedded Linux Training and Consulting
https://rootcommit.com/
next prev parent reply other threads:[~2024-12-04 9:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-01 17:38 [PATCH 1/3] dev-manual: fix styling of references to bmaptool michael.opdenacker
2024-12-01 17:38 ` [PATCH 2/3] dev-manual/bmaptool.rst: add missing command for bmaptool-native michael.opdenacker
2024-12-02 9:02 ` [docs] " Antonin Godard
2024-12-04 10:31 ` Michael Opdenacker
2024-12-01 17:38 ` [PATCH 3/3] dev-manual/bmaptool.rst: simplify and fix instructions michael.opdenacker
2024-12-01 19:26 ` [docs] " Ulrich Ölmann
2024-12-04 9:19 ` Michael Opdenacker
2024-12-02 9:02 ` Antonin Godard
2024-12-04 9:26 ` Michael Opdenacker [this message]
2024-12-04 9:33 ` Michael Opdenacker
2024-12-04 10:17 ` Antonin Godard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fa75108-fb1b-4d62-babc-054888a076d3@rootcommit.com \
--to=michael.opdenacker@rootcommit.com \
--cc=antonin.godard@bootlin.com \
--cc=docs@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox