public inbox for docs@lists.yoctoproject.org
 help / color / mirror / Atom feed
From: Michael Opdenacker <michael.opdenacker@bootlin.com>
To: "Ulrich Ölmann" <u.oelmann@pengutronix.de>
Cc: yocto@pengutronix.de,
	Yocto Project Documentation <docs@lists.yoctoproject.org>
Subject: Re: [docs] [PATCH v2 3/3] ref-manual: classes: kernel-fitimage: refine role of INITRAMFS_IMAGE_BUNDLE
Date: Mon, 17 Jul 2023 18:17:58 +0200	[thread overview]
Message-ID: <9bffe951-5aa2-13cf-1ee7-2cd71f9e6e93@bootlin.com> (raw)
In-Reply-To: <20230714093554.2402426-3-u.oelmann@pengutronix.de>

Hi Ulrich,

On 14.07.23 at 11:35, Ulrich Ölmann wrote:
> Although it might seem a little bit pedantic this patch describes what the class
> actually checks (see e.g. [1]) and kernel.bbclass per default sets the parameter
> INITRAMFS_IMAGE_BUNDLE to the empty string (see [2]) which already satisfies
> that check without the need of additionally explicitly setting it to '0'.
>
> [1] https://git.yoctoproject.org/poky/tree/meta/classes-recipe/kernel-fitimage.bbclass?h=4.3_M1&id=cc97d775cb402df0d4122bf54eab1a5198c98471#n667
> [2] https://git.yoctoproject.org/poky/tree/meta/classes-recipe/kernel.bbclass?h=4.3_M1&id=cc97d775cb402df0d4122bf54eab1a5198c98471#n37
>
> Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
> ---
>   documentation/ref-manual/classes.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/documentation/ref-manual/classes.rst b/documentation/ref-manual/classes.rst
> index dc30419a1e7f..4577baba3e66 100644
> --- a/documentation/ref-manual/classes.rst
> +++ b/documentation/ref-manual/classes.rst
> @@ -1625,7 +1625,7 @@ The address where the RAM disk image is to be loaded by U-Boot
>   is specified by :term:`UBOOT_RD_LOADADDRESS` and the entrypoint by
>   :term:`UBOOT_RD_ENTRYPOINT`. The ramdisk is added to the FIT image when
>   :term:`INITRAMFS_IMAGE` is specified and requires that :term:`INITRAMFS_IMAGE_BUNDLE`
> -is set to 0.
> +is not set to 1.
>   
>   Only a single :term:`Initramfs` bundle can be added to the FIT image created by
>   :ref:`ref-classes-kernel-fitimage` and the :term:`Initramfs` bundle in FIT is optional.


Many thanks for the 3 patches, much appreciated as always.
For the 3 patches: Reviewed-by: Michael Opdenacker 
<michael.opdenacker@bootlin.com>
Merged into master-next.

Thanks again
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



      reply	other threads:[~2023-07-17 16:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-14  9:35 [PATCH v2 1/3] ref-manual: classes: kernel-fitimage: fix source of imagetype Ulrich Ölmann
2023-07-14  9:35 ` [PATCH v2 2/3] ref-manual: classes: kernel-fitimage: fix typos Ulrich Ölmann
2023-07-14  9:35 ` [PATCH v2 3/3] ref-manual: classes: kernel-fitimage: refine role of INITRAMFS_IMAGE_BUNDLE Ulrich Ölmann
2023-07-17 16:17   ` Michael Opdenacker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9bffe951-5aa2-13cf-1ee7-2cd71f9e6e93@bootlin.com \
    --to=michael.opdenacker@bootlin.com \
    --cc=docs@lists.yoctoproject.org \
    --cc=u.oelmann@pengutronix.de \
    --cc=yocto@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox