Re: [docs] [PATCH] ref-manual: use standardized method accross both ubuntu and debian for locale install

["Antonin Godard" <antonin.godard@bootlin.com>]

Hi Guénaël,

Thanks for the patch!

On Fri Nov 15, 2024 at 1:33 PM CET, Guénaël Muller via lists.yoctoproject.org wrote:
> Modify locale installation method to be standard accross all debian-based distributions.
> Pre-existing method is available only on Ubuntu, locale-gen tool has no parameter in Debian.
>
> Signed-off-by: Guénaël Muller <guenael.muller@smile.fr>
> Reviewed-by: Yoann Congal <yoann.congal@smile.fr>
> ---
>  documentation/poky.yaml.in                       | 3 +--
>  documentation/ref-manual/system-requirements.rst | 8 ++++++++
>  2 files changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/documentation/poky.yaml.in b/documentation/poky.yaml.in
> index c770318f2..66f758fe8 100644
> --- a/documentation/poky.yaml.in
> +++ b/documentation/poky.yaml.in
> @@ -13,8 +13,7 @@ YOCTO_RELEASE_DL_URL : "&YOCTO_DL_URL;/releases/yocto/yocto-&DISTRO;"
>  UBUNTU_HOST_PACKAGES_ESSENTIAL : "gawk wget git diffstat unzip texinfo gcc \
>       build-essential chrpath socat cpio python3 python3-pip python3-pexpect \
>       xz-utils debianutils iputils-ping python3-git python3-jinja2 \
> -     python3-subunit zstd liblz4-tool file locales libacl1
> -     \n\   $ sudo locale-gen en_US.UTF-8"
> +     python3-subunit zstd liblz4-tool file locales libacl1"
>  FEDORA_HOST_PACKAGES_ESSENTIAL : "gawk make wget tar bzip2 gzip python3 unzip perl patch \
>       diffutils diffstat git cpp gcc gcc-c++ glibc-devel texinfo chrpath \
>       ccache perl-Data-Dumper perl-Text-ParseWords perl-Thread-Queue perl-bignum socat \
> diff --git a/documentation/ref-manual/system-requirements.rst b/documentation/ref-manual/system-requirements.rst
> index 0fc92550a..5b481dd83 100644
> --- a/documentation/ref-manual/system-requirements.rst
> +++ b/documentation/ref-manual/system-requirements.rst
> @@ -152,6 +152,14 @@ with a supported Ubuntu or Debian Linux distribution::
>  
>     $ sudo apt install &UBUNTU_HOST_PACKAGES_ESSENTIAL;
>  
> +You also need to ensure you have locale ``en_US.UTF-8`` enabled::

s/you have locale/you have the locale/ would look a bit better IMO :)

> +   $ locale --all-locales | grep en_US.utf8
> +
> +If this is not the case, You can reconfigure ``locales`` package to add it::

s/You/you/
s/You can reconfigure ``locales``/you can reconfigure the ``locales``/

> +    $ sudo dpkg-reconfigure locales

Can you fix the indent here? It should be 3 like above.

Otherwise, I could verify this with an Ubuntu docker image and a Debian docker
image, indeed Debian does not take arguments, I guess it assumes the locales to
generate in a prior step. I was able to use the dpkg-reconfigure method on both
Ubuntu/Debian:

Tested-by: Antonin Godard <antonin.godard@bootlin.com>

Cheers,
Antonin

-- 
Antonin Godard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com