Re: [docs] [yocto-docs][PATCH v3] ref-manual: classes: fix bin_package description

["Antonin Godard" <antonin.godard@bootlin.com>]

Hi Quentin,

On Wed Nov 27, 2024 at 3:15 PM CET, Quentin Schulz wrote:
[...]
>>>> +``${S}/usr/lib/<library>.so`` to be installed in :term:`D` correctly.
>>>> +
>>>
>>> It'd be nice to encourage people to use versioned shared libraries even
>>> for binary packages but not sure how to word this here.
>> 
>> Replace by ``${S}/usr/lib/<library>.<version>.so``? and implicitly encourage it.
>> Not sure this is the place to give written advice on that.
>> 
>
> It's actually ``${S}/usr/lib/<library>.so.<version>`` :) But would work 

Oops, right thanks :)

> for me. Though considering FILES:${PN} = "/" once inheriting this class, 
> whether versioned or not doesn't matter to the packaging step (unlike 
> the default values, where .so goes to -dev package).
>
>>>> +.. note::
>>>>    
>>>> -      SRC_URI = "git://example.com/downloads/somepackage.rpm;branch=main;subpath=${BP}"
>>>> +   The extraction of the package passed in :term:`SRC_URI` is not handled by the
>>>> +   :ref:`ref-classes-bin-package` class, and is done by the appropriate
>
> s/, and is done/but rather/ ?

+1

>>>> +   :ref:`fetcher <bitbake-user-manual/bitbake-user-manual-fetching:fetchers>`
>>>> +   depending on the nature of the package.
>>>
>>> What do you mean by "depending on the nature of the package"?
>> 
>> I meant the type, like RPM, tarball, deb… I can replace by "type", and add a
>> "(RPM, Deb, tarball, …)" in parenthesis afterwards.
>> 
>
> I would simply remove "depending on the nature of the package", that's 
> already implied? Ah, or we can say depending on the file extension which 
> I believe is how the fetcher is actually figuring out how to extract them?

Sure! File extension's fine to me.

Thanks,
Antonin

-- 
Antonin Godard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com