Re: [docs] [yocto-docs PATCH] set_versions.py: use backward-compatible python argument in run

["Antonin Godard" <antonin.godard@bootlin.com>]

Hi Quentin,

On Tue Dec 17, 2024 at 12:05 PM CET, Quentin Schulz wrote:
> Hi Antonin,
>
> On 12/17/24 11:35 AM, Antonin Godard via lists.yoctoproject.org wrote:
>> Some workers on the autobuilder reported the following error:
>> 
>>    File "./set_versions.py", line 102, in <module>
>>      subprocess.run(["git", "show", "yocto-%s" % release_series[activereleases[0]]], capture_output=True, check=True)
>>    File "/usr/lib64/python3.6/subprocess.py", line 423, in run
>>      with Popen(*popenargs, **kwargs) as process:
>>    TypeError: __init__() got an unexpected keyword argument 'capture_output'
>> 
>> See https://valkyrie.yoctoproject.org/#/builders/34/builds/86.
>> 
>> This is because capture_output was introduced in Python 3.7, and some of
>> the support distributions are still on Python 3.6. Since capture_output
>> is essentially just setting stdout and stderr to PIPE
>> (https://github.com/python/cpython/blob/3.13/Lib/subprocess.py#L547), do
>> it manually here to be compatible with older python versions.
>> 
>> This is also the case for the "text" parameter, introduced in 3.7 to
>> alias the universal_newlines parameter. Use "universal_newlines" to be
>> backward-compatible.
>> 
>> [ YOCTO #15687 ]
>> 
>
> Do we really want to open that can of worms?
>
> https://docs.yoctoproject.org/ref-manual/system-requirements.html#required-git-tar-python-make-and-gcc-versions 
> clearly states the minimal supported Python version is 3.8.0 so maybe we 
> should just stop building the docs on those distros that are still on 
> old Python? I'm actually surprised building YP on AlmaLinux 8 works 
> then, is it because of uninative?

We still support 3.6 on Kirkstone. The docs build uses a buildtools tarball to
get a recent Sphinx version, rsvg-convert, etc. I wouldn't know how this is done
for other builds, though.

> Looks ok to me otherwise.

Thank you,
Antonin

-- 
Antonin Godard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com