Re: [docs] [PATCH 1/3] migration-guides: systemd.bbclass do not add Also services for 5.2

["Antonin Godard" <antonin.godard@bootlin.com>]

Hi Adrian,

Thanks for the update on this! Here below are some suggestions.

On Tue Dec 24, 2024 at 3:02 PM CET, Adrian Freihofer via lists.yoctoproject.org wrote:
> Covers the chagnes introduced by commit
> https://git.yoctoproject.org/poky/commit/?id=efa5f65c2214239ed7aaf7bd8998683e755c5660
>
> Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com>
> ---
>  .../migration-guides/migration-5.2.rst        | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>
> diff --git a/documentation/migration-guides/migration-5.2.rst b/documentation/migration-guides/migration-5.2.rst
> index cb70e19da..2ae8e73a7 100644
> --- a/documentation/migration-guides/migration-5.2.rst
> +++ b/documentation/migration-guides/migration-5.2.rst
> @@ -74,6 +74,25 @@ systemd changes
>     As a consequence, the ``systemd`` recipe no longer contains the ``usrmerge``
>     :term:`PACKAGECONFIG` option as it is now implied by default.
>  
> +-  ``systemd.bbclass``: If a systemd service file had referred to other service
> +   files by starting them as “Also”, the other service files were automatically added

s/by starting them as/with/?
s/“Also”/`Also <https://www.freedesktop.org/software/systemd/man/latest/systemd.unit.html#Also=>`__/?

> +   to the ``FILES`` variable of the same package. Example: 

s/``FILES``/:term:`FILES`/

Same for FILES and SYSTEMD_SERVICE below.

> +
> +   a.service contains:

Nitpick:

s/contains:/contains::/
and remove ".. code-block:: ini" below

> +
> +   .. code-block:: ini
> +
> +      [Install]
> +      Also=b.service
> +
> +   If a.service is packed in package A, b.service is automatically packed

s/packed/packaged/

> +   into package A as well. This happens even if b.service is explicitly
> +   added to package B using FILES and SYSTEMD_SERVICE variables.
> +
> +   This prevents such services from being packaged into different packages.
> +   Therefore, this automatic has been removed for service files (but not for socket files).

"automatic behavior"?

> +   Now all service files must be explicitly added to ``FILES``.
> +
>  Recipe changes
>  ~~~~~~~~~~~~~~
>  


Antonin

-- 
Antonin Godard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com