Re: [PATCH v6] ref-manual: uboot-sign: Add how to enable ATF, TEE and User defined snippet ITS for U-Boot FIT image

["Antonin Godard" <antonin.godard@bootlin.com>]

Hi Jamin,

On Fri Mar 14, 2025 at 3:15 AM CET, Jamin Lin wrote:
> Add how to enable ATF, TEE and User defined ITS for U-Boot FIT image generation.
>
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> ---
>  documentation/ref-manual/classes.rst   |  14 +++
>  documentation/ref-manual/variables.rst | 137 +++++++++++++++++++++++++
>  2 files changed, 151 insertions(+)
>
> diff --git a/documentation/ref-manual/classes.rst b/documentation/ref-manual/classes.rst
> index b93279ff6..0a73a956e 100644
> --- a/documentation/ref-manual/classes.rst
> +++ b/documentation/ref-manual/classes.rst
> @@ -3401,6 +3401,20 @@ The variables used by this class are:
>  -  :term:`UBOOT_FITIMAGE_ENABLE`: enable the generation of a U-Boot FIT image.
>  -  :term:`UBOOT_MKIMAGE_DTCOPTS`: DTC options for U-Boot ``mkimage`` when
>     rebuilding the FIT image containing the kernel.
> +-  :term:`UBOOT_FIT_ARM_TRUSTED_FIRMWARE`: include the Trusted Firmware-A
> +   (TF-A) binary in the U-Boot FIT binary.

Actually, I think Quentin suggested to replace "image" by "binary" for the TF-A
and others, but not the FIT image. I think it is more common to say "FIT image",
even though it is a binary. So, can you just replace occurences of "FIT binary"
by "FIT image" here and below?

Thanks for your work on this. The rest of the patch looks good to me otherwise.

Antonin

--
Antonin Godard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com