From: "Antonin Godard" <antonin.godard@bootlin.com>
To: <bhstalel@gmail.com>, <docs@lists.yoctoproject.org>
Subject: Re: [docs] [PATCH 1/2] dev-manual/building.rst: add note about globally inheriting externalsrc class
Date: Mon, 22 Sep 2025 16:18:50 +0200 [thread overview]
Message-ID: <DCZE7GR7DWSC.20I17FKZ0DHZK@bootlin.com> (raw)
In-Reply-To: <20250921132033.31644-2-bhstalel@gmail.com>
On Sun Sep 21, 2025 at 3:20 PM CEST, BELHADJ SALEM Talel via lists.yoctoproject.org wrote:
> Signed-off-by: Talel BELHAJ SALEM <bhstalel@gmail.com>
> ---
> documentation/dev-manual/building.rst | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/documentation/dev-manual/building.rst b/documentation/dev-manual/building.rst
> index 04c150094..8d00d908e 100644
> --- a/documentation/dev-manual/building.rst
> +++ b/documentation/dev-manual/building.rst
> @@ -736,6 +736,13 @@ are the statements to put in your ``local.conf`` file::
> INHERIT += "externalsrc"
> EXTERNALSRC:pn-myrecipe = "path-to-your-source-tree"
>
> +.. note::
> +
> + When you inherit :ref:`ref-classes-externalsrc` class globally make
> + sure to set the :term:`EXTERNALSRC` and :term:`EXTERNALSRC_BUILD`
> + variables to specific recipes, not doing that will redirect
> + all recipes to one external source directory.
> +
> This next example shows how to accomplish the same thing by setting
> :term:`EXTERNALSRC` in the recipe itself or in the recipe's append file::
>
Hi,
When reading this, I had the feeling that the previous paragraph shows how to
set EXTERNALSRC for a specific recipe, and the next paragraph shows how to set
both EXTERNALSRC and EXTERNALSRC_BUILD from a recipe - which is exactly what you
say in your note. So, why a note to repeat this? What was the intent?
Antonin
--
Antonin Godard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2025-09-22 14:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-21 13:20 [PATCH 0/2] Document some checks in externalsrc that could fail the build Talel BELHAJ SALEM
2025-09-21 13:20 ` [PATCH 1/2] dev-manual/building.rst: add note about globally inheriting externalsrc class Talel BELHAJ SALEM
2025-09-22 14:18 ` Antonin Godard [this message]
2025-09-22 18:08 ` [docs] " Talel BELHADJ SALEM
2025-09-23 16:08 ` Antonin Godard
2025-09-21 13:20 ` [PATCH 2/2] dev-manual/building.rst: add note about externalsrc variables absolute paths Talel BELHAJ SALEM
2025-10-06 8:07 ` Antonin Godard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DCZE7GR7DWSC.20I17FKZ0DHZK@bootlin.com \
--to=antonin.godard@bootlin.com \
--cc=bhstalel@gmail.com \
--cc=docs@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox