From: "Antonin Godard" <antonin.godard@bootlin.com>
To: <quentin.schulz@cherry.de>, <docs@lists.yoctoproject.org>
Cc: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
Subject: Re: [docs] [PATCH] tools/build-docs-container: use CONTAINERCMD to append args
Date: Mon, 13 Oct 2025 09:08:26 +0200 [thread overview]
Message-ID: <DDH07DARB8NA.N8W9T8G416WW@bootlin.com> (raw)
In-Reply-To: <df5d5e00-f950-4e52-a6fd-b7d1cd3822b6@cherry.de>
On Thu Oct 9, 2025 at 2:32 PM CEST, Quentin Schulz via lists.yoctoproject.org wrote:
> Hi Antonin,
>
> On 10/9/25 12:05 PM, Antonin Godard via lists.yoctoproject.org wrote:
>> What we have is OCI = $(which $CONTAINERCMD) = /usr/bin/{docker,podman}.
>> So we never pass these if conditions. Compare against CONTAINERCMD instead.
>>
>> Signed-off-by: Antonin Godard <antonin.godard@bootlin.com>
>
> Nope, this won't work if you call the script with docker but run with
> podman. This would be the case if you have podman-docker package
> installed on fedora for example, c.f.
> https://packages.fedoraproject.org/pkgs/podman/podman-docker/.
Oh I see... I did not guess that.
I'll send a v2.
Thanks,
Antonin
--
Antonin Godard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2025-10-13 7:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-09 10:05 [PATCH] tools/build-docs-container: use CONTAINERCMD to append args Antonin Godard
2025-10-09 12:32 ` [docs] " Quentin Schulz
2025-10-13 7:08 ` Antonin Godard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DDH07DARB8NA.N8W9T8G416WW@bootlin.com \
--to=antonin.godard@bootlin.com \
--cc=docs@lists.yoctoproject.org \
--cc=quentin.schulz@cherry.de \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox