public inbox for docs@lists.yoctoproject.org
 help / color / mirror / Atom feed
From: "Antonin Godard" <antonin.godard@bootlin.com>
To: <adam.blank.g@gmail.com>, <docs@lists.yoctoproject.org>
Subject: Re: [docs] [PATCH RESEND] ref-manual/variables.rst: update staging and packaging variables
Date: Wed, 08 Apr 2026 09:06:06 +0200	[thread overview]
Message-ID: <DHNL006AUIAP.CS7GW0LE4QRX@bootlin.com> (raw)
In-Reply-To: <20260408-staging_and_packaging_updates-v1-1-dddee2e38d7b@gmail.com>

Hi,

Thanks for the patch.

The problem with it is that you change multiple definitions at once but provide
no justification for why you changed them. Could you be more specific about why
these changes are needed, and possibly breakdown the changes into a
comprehensive list of patches? This would make reviewing your patch and
understanding your intentions easier.

On Wed Apr 8, 2026 at 8:35 AM CEST, Adam Blank via lists.yoctoproject.org wrote:
> Signed-off-by: Adam Blank <adam.blank.g@gmail.com>
> ---
> Updates of staging and packaging variables' descriptions following
> design and implementation changes of the last few years.

Note: your commit message also does not contain a body as this is below the
"---", I'm not sure whether this was intentional or not.

Antonin


      reply	other threads:[~2026-04-08  7:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-08  6:35 [PATCH RESEND] ref-manual/variables.rst: update staging and packaging variables Adam Blank
2026-04-08  7:06 ` Antonin Godard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DHNL006AUIAP.CS7GW0LE4QRX@bootlin.com \
    --to=antonin.godard@bootlin.com \
    --cc=adam.blank.g@gmail.com \
    --cc=docs@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox