From: Michael Opdenacker <michael.opdenacker@bootlin.com>
To: Cliff Brake <cbrake@bec-systems.com>,
OE-core <openembedded-core@lists.openembedded.org>
Cc: YP docs mailing list <docs@lists.yoctoproject.org>
Subject: Re: [OE-core] Keep scripts/create-pull-request and send-pull-request ?
Date: Thu, 10 Aug 2023 18:36:31 +0200 [thread overview]
Message-ID: <b2efe736-0613-a3cb-020c-2cba3562420f@bootlin.com> (raw)
In-Reply-To: <d03b0041-978c-40c0-8905-f4f3d62729be@bec-systems.com>
Hello,
On 10.08.23 at 16:18, Cliff Brake wrote:
> On 8/10/23 10:04, Michael Opdenacker via lists.openembedded.org wrote:
>> I'm wondering whether it's better to document how to create and send
>> pull requests from standard git tools.
>
> +1
>
> Cliff
All things considered, since scripts/create-pull-request is still in
use, in particular by Steve and Bruce, I'm leaning towards documenting
both variants:
* Creating a simple pull request using the standard git tools, as
several of us are doing. Richard doesn't seem to mind. At least in
my case, this applies to changes I previously submitted through the
lists.
* Creating a more elaborate pull request from a branch containing
commits that haven't been shared yet, typically like what Steve
does. This way, people can review each patch individually by e-mail.
Unless we want to standardize our pull requests, and make sure each
commit is submitted (sometimes once again) as a separate patch. In that
case, we'd only document the use of scripts/create-pull-request.
Cheers
Michael.
--
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2023-08-10 16:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 14:04 Keep scripts/create-pull-request and send-pull-request ? Michael Opdenacker
2023-08-10 14:09 ` [docs] " Bruce Ashfield
2023-08-10 14:13 ` Michael Opdenacker
2023-08-10 14:17 ` Bruce Ashfield
2023-08-10 14:39 ` Frédéric Martinsons
[not found] ` <d03b0041-978c-40c0-8905-f4f3d62729be@bec-systems.com>
2023-08-10 16:36 ` Michael Opdenacker [this message]
2023-08-10 16:38 ` [docs] [OE-core] " Alexander Kanavin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2efe736-0613-a3cb-020c-2cba3562420f@bootlin.com \
--to=michael.opdenacker@bootlin.com \
--cc=cbrake@bec-systems.com \
--cc=docs@lists.yoctoproject.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox