Yocto Project Documentation
 help / color / mirror / Atom feed
From: "Michael Opdenacker" <michael.opdenacker@bootlin.com>
To: Quentin Schulz <quentin.schulz@streamunlimited.com>
Cc: docs@lists.yoctoproject.org
Subject: Re: [docs] [PATCH] Fix typos and spacing
Date: Mon, 29 Mar 2021 18:03:27 +0200	[thread overview]
Message-ID: <ba20eef9-e082-e446-3013-4a15c13347e3@bootlin.com> (raw)
In-Reply-To: <20210329151903.vvooyzogdn3n7gxb@qschulz>

Hi Quentin,

Many thanks for your review!

On 3/29/21 5:19 PM, Quentin Schulz wrote:
>> @@ -2111,8 +2111,7 @@ accomplished using fakeroot.
>>     under fakeroot. Otherwise, the task cannot run root-only operations,
>>     and cannot see the fake file ownership and permissions set by the
>>     other task. You need to also add a dependency on
>> -   virtual/fakeroot-native:do_populate_sysroot
>> -   , giving the following:
>> +   virtual/fakeroot-native:do_populate_sysroot, giving the following:
>>     ::
> This is usually the tell of a bad outcome of the migration tool. I'm
> pretty sure what was meant here is:
> other task. You need to also add a dependency on
> ``virtual/fakeroot-native:do_populate_sysroot``, giving the following:

Oops, this definitely makes sense.

>>  
>>     It is not a requirement that a layer name begin with the prefix
>> -   meta-
>> -   , but it is a commonly accepted standard in the Yocto Project
>> +   meta-, but it is a commonly accepted standard in the Yocto Project
> Same here, ``meta-``.
>
> Basically, you just encountered the files we haven't manually reviewed
> yet :)
>
> Outside of obvious typos, anything with a weird indentation/syntax
> usually requires manual inspection. I used to compare with 3.0 docs to
> check what was intended and then fix it to match whatever was the state
> before.
>
> I would say it's better to leave those indentation/syntax issues as is
> and take the time to fix them properly because they are pretty easy to
> spot once your brain has picked up the patterns :)


Agreed. I'll drop these in the current patch and will address them
separately. Indeed, I've seen a few other looking like these ones.

Thanks again!

Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


      reply	other threads:[~2021-03-29 16:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-29 13:23 [PATCH] Fix typos and spacing Michael Opdenacker
2021-03-29 15:19 ` [docs] " Quentin Schulz
2021-03-29 16:03   ` Michael Opdenacker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba20eef9-e082-e446-3013-4a15c13347e3@bootlin.com \
    --to=michael.opdenacker@bootlin.com \
    --cc=docs@lists.yoctoproject.org \
    --cc=quentin.schulz@streamunlimited.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox