Re: [docs] [PATCH] ref-manual: document KERNEL_LOCALVERSION

Michael Opdenacker
2023-11-02T13:33:18Z

On 02.11.23 at 11:01, Ulrich Ölmann wrote:
> On Thu, Nov 02 2023 at 10:55 +0100, Ulrich Ölmann <u.oelmann@pengutronix.de> wrote:
>> Hi Michael,
>>
>> just a small typo, otherwise a good description.
>>
>> On Fri, Oct 27 2023 at 11:29 +0200, "Michael Opdenacker via lists.yoctoproject.org" <michael.opdenacker=bootlin.com@lists.yoctoproject.org> wrote:
>>> From: Michael Opdenacker <michael.opdenacker@bootlin.com>
>>>
>>> Introduced by
>>> https://git.yoctoproject.org/poky/commit/?id=66ed174ccdf7a89cb998f503cc6b631e2d1adcc0
>>>
>>> Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
>>> CC: Bruce Ashfield <bruce.ashfield@gmail.com>
>>> ---
>>> documentation/ref-manual/variables.rst | 10 ++++++++++
>>> 1 file changed, 10 insertions(+)
>>>
>>> diff --git a/documentation/ref-manual/variables.rst b/documentation/ref-manual/variables.rst
>>> index 03234d3f78..771eb91af6 100644
>>> --- a/documentation/ref-manual/variables.rst
>>> +++ b/documentation/ref-manual/variables.rst
>>> @@ -2485,6 +2485,16 @@ system and gives an overview of their function and contents.
>>> external tools. See the :ref:`ref-classes-kernel-yocto` class in
>>> ``meta/classes-recipe`` to see how the variable is used.
>>>
>>> + :term:`KERNEL_LOCALVERSION`
>>> + This variable allows to appends a string to the version
>> s/appends/append/
> Urgs, it's better to read the whole thread before replying - this has
> already been addressed before. Sorry for the noise!

No problem, I sometimes do this too.
Thanks for the review anyway!
Cheers
Michael.

--
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering