From: "Michael Opdenacker" <michael.opdenacker@bootlin.com>
To: Quentin Schulz <quentin.schulz@streamunlimited.com>
Cc: docs@lists.yoctoproject.org
Subject: Re: [docs] [PATCH] sdk-manual: fix broken references
Date: Thu, 17 Jun 2021 10:36:36 +0200 [thread overview]
Message-ID: <d60e15b4-153c-2127-ff44-6315b067fc80@bootlin.com> (raw)
In-Reply-To: <20210616095919.du3xmrpe2adlhge7@qschulz>
Hi Quentin,
Many thanks for the review!
On 6/16/21 11:59 AM, Quentin Schulz wrote:
> Hi Michael,
>
> On Tue, Jun 15, 2021 at 07:00:56PM +0200, Michael Opdenacker wrote:
>> Detected by running:
>> git grep "^[\ ]*\" section" | grep -v "\`"
>>
>> Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
>> ---
>> .../sdk-manual/appendix-customizing.rst | 12 ++++++------
>> documentation/sdk-manual/extensible.rst | 17 ++++++++---------
>> documentation/sdk-manual/working-projects.rst | 5 ++---
>> 3 files changed, 16 insertions(+), 18 deletions(-)
>>
>> diff --git a/documentation/sdk-manual/appendix-customizing.rst b/documentation/sdk-manual/appendix-customizing.rst
>> index 67b49d9f49..c122fb5836 100644
>> --- a/documentation/sdk-manual/appendix-customizing.rst
>> +++ b/documentation/sdk-manual/appendix-customizing.rst
>> @@ -74,9 +74,9 @@ adjustments:
>> is set using the "?=" operator. Consequently, you will need to
>> either define the entire list by using the "=" operator, or you
>> will need to append a value using either "_append" or the "+="
>> - operator. You can learn more about these operators in the "
>> - Basic Syntax
>> - " section of the BitBake User Manual.
>> + operator. You can learn more about these operators in the
>> + ":ref:`bitbake:bitbake-user-manual/bitbake-user-manual-metadata:basic syntax`"
>> + section of the BitBake User Manual.
>>
>> .
>>
> This seems like a spurious dot. (not introduced by your patch, I know :) )
Right! I caught it, but I wanted to address it through a separate patch.
I suspected you would catch it :-)
>
> Looks good otherwise, did you check that it's referring to the same page
> we had in earlier docs? I often check by going on
> https://www.yoctoproject.org/docs/current/mega-manual/mega-manual.html
> and click on links and check if the reference I'm giving is the expected
> one.
No, thanks for the reminder. I double checked and will try to remember
to do it from now on.
I merged this patch into "master-next".
Thanks again,
Michael.
--
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2021-06-17 8:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 17:00 [PATCH] sdk-manual: fix broken references Michael Opdenacker
2021-06-16 9:59 ` [docs] " Quentin Schulz
2021-06-17 8:36 ` Michael Opdenacker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d60e15b4-153c-2127-ff44-6315b067fc80@bootlin.com \
--to=michael.opdenacker@bootlin.com \
--cc=docs@lists.yoctoproject.org \
--cc=quentin.schulz@streamunlimited.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox