[docs][PATCH] migration-guides/release-notes-4.1.rst: remove bitbake-layers subcommand argument

[docs][PATCH] migration-guides/release-notes-4.1.rst: remove bitbake-layers subcommand argument

[Takayasu Ito]

Hi all

- remove bitbake-layers subcommand argument
---
  documentation/migration-guides/release-notes-4.1.rst | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/documentation/migration-guides/release-notes-4.1.rst b/documentation/migration-guides/release-notes-4.1.rst
index 0c552bf1a..a2d4b3d6c 100644
--- a/documentation/migration-guides/release-notes-4.1.rst
+++ b/documentation/migration-guides/release-notes-4.1.rst
@@ -18,7 +18,7 @@ New Features / Enhancements in 4.1

    - New ``scripts/oe-setup-layers`` standalone script to restore the layer
      configuration from a json file
-  - New ``bitbake-layers create-layers-setup destdir`` command to save the
+  - New ``bitbake-layers create-layers-setup`` command to save the
      layer configuration to a json file
    - New ``bitbake-layers save-build-conf`` command to save the active build
      configuration as a template into a layer
--
2.25.1

-- 
Takayasu Ito <ito@lineo.co.jp>
Lineo Solutions Inc.

Re: [docs][PATCH] migration-guides/release-notes-4.1.rst: remove bitbake-layers subcommand argument

[Michael Opdenacker]

Hi,

On 10/19/22 18:17, ito@lineo.co.jp wrote:
> Hi all
>
> - remove bitbake-layers subcommand argument
> ---
>  documentation/migration-guides/release-notes-4.1.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)


Thank you very much for the patch!
However, you're missing a "Signed-off-by" field in your patch. Make sure 
you produce your commit with "git commit -s".

You should also try to run the following command to get your full name 
as commit author when I accept your patch:
git config --global sendemail.from "ito@lineo.co.jp"

Could you send a new version after doing this, please?
Thanks again
Cheers
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [docs][PATCH v2] migration-guides/release-notes-4.1.rst: remove bitbake-layers subcommand argument

[Takayasu Ito]

Hi Michael

On 2022/10/20 1:26, Michael Opdenacker wrote:
> Hi,
> 
> On 10/19/22 18:17, ito@lineo.co.jp wrote:
>> Hi all
>>
>> - remove bitbake-layers subcommand argument
>> ---
>>  documentation/migration-guides/release-notes-4.1.rst | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> Thank you very much for the patch!
> However, you're missing a "Signed-off-by" field in your patch. Make sure you produce your commit with "git commit -s".
> 
> You should also try to run the following command to get your full name as commit author when I accept your patch:
> git config --global sendemail.from "ito@lineo.co.jp"
> 
> Could you send a new version after doing this, please?
> Thanks again
> Cheers
> Michael.
> 


I forgot to specify the "-s" option.

-- 


Signed-off-by: Takayasu Ito <ito@lineo.co.jp>
---
  documentation/migration-guides/release-notes-4.1.rst | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/documentation/migration-guides/release-notes-4.1.rst b/documentation/migration-guides/release-notes-4.1.rst
index 0c552bf1a..a2d4b3d6c 100644
--- a/documentation/migration-guides/release-notes-4.1.rst
+++ b/documentation/migration-guides/release-notes-4.1.rst
@@ -18,7 +18,7 @@ New Features / Enhancements in 4.1

    - New ``scripts/oe-setup-layers`` standalone script to restore the layer
      configuration from a json file
-  - New ``bitbake-layers create-layers-setup destdir`` command to save the
+  - New ``bitbake-layers create-layers-setup`` command to save the
      layer configuration to a json file
    - New ``bitbake-layers save-build-conf`` command to save the active build
      configuration as a template into a layer

Re: [docs][PATCH v2] migration-guides/release-notes-4.1.rst: remove bitbake-layers subcommand argument

[Michael Opdenacker]

Hi

On 10/19/22 19:14, ito@lineo.co.jp wrote:
> Hi Michael
>
> On 2022/10/20 1:26, Michael Opdenacker wrote:
>> Hi,
>>
>> On 10/19/22 18:17, ito@lineo.co.jp wrote:
>>> Hi all
>>>
>>> - remove bitbake-layers subcommand argument
>>> ---
>>>  documentation/migration-guides/release-notes-4.1.rst | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>
>> Thank you very much for the patch!
>> However, you're missing a "Signed-off-by" field in your patch. Make 
>> sure you produce your commit with "git commit -s".
>>
>> You should also try to run the following command to get your full 
>> name as commit author when I accept your patch:
>> git config --global sendemail.from "ito@lineo.co.jp"
>>
>> Could you send a new version after doing this, please?
>> Thanks again
>> Cheers
>> Michael.
>>
>
>
> I forgot to specify the "-s" option.


That's still not enough.
Could you also run the below command before sending the patch with "git 
send-email"?

git config --global sendemail.from "ito@lineo.co.jp"

See 
https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded#Sending_using_git-send-email

Thanks in advance
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com