Yocto Meta TI
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denis@denix.org>
To: fra.schnyder@gmail.com
Cc: meta-ti@lists.yoctoproject.org,
	Franz Schnyder <franz.schnyder@toradex.com>,
	Ryan Eatmon <reatmon@ti.com>,
	Francesco Dolcini <francesco@dolcini.it>
Subject: Re: [meta-ti][master][PATCH v1] conf: machine: j784s4: Move ti-eth-fw-j784s4 to EVM conf
Date: Wed, 15 Apr 2026 16:47:06 -0400	[thread overview]
Message-ID: <20260415204706.GC4186@denix.org> (raw)
In-Reply-To: <20260415114107.1643556-1-fra.schnyder@gmail.com>

On Wed, Apr 15, 2026 at 01:41:04PM +0200, Franz Schnyder via lists.yoctoproject.org wrote:
> From: Franz Schnyder <franz.schnyder@toradex.com>
> 
> The `ti-eth-fw-j784s4` firmware is added in the generic J784s4 SoC
> include, which is therefore used for all the J784s4-based machines.
> That firmware seems to be developed specifically for the EVM, as it
> takes control of pins used for the Ethernet board setup on the EVM. On
> non-EVM boards, like the Aquila-AM69, those signals are used for other
> functions, so enabling the firmware in the SoC include is too broad
> and breaks functionality.
> 
> Move the machine-essential recommend from the SoC include
> to the EVM configuration.
> 
> Signed-off-by: Franz Schnyder <franz.schnyder@toradex.com>
> ---
>  meta-ti-bsp/conf/machine/include/j784s4.inc | 2 +-
>  meta-ti-bsp/conf/machine/j784s4-evm.conf    | 2 ++
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-ti-bsp/conf/machine/include/j784s4.inc b/meta-ti-bsp/conf/machine/include/j784s4.inc
> index 4dc3a71b..e0ce81b5 100644
> --- a/meta-ti-bsp/conf/machine/include/j784s4.inc
> +++ b/meta-ti-bsp/conf/machine/include/j784s4.inc
> @@ -12,7 +12,7 @@ TFA_BOARD = "j784s4"
>  
>  OPTEEMACHINE = "k3-j784s4"
>  
> -MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS += "cadence-mhdp-fw cnm-wave-fw ti-eth-fw-j784s4"
> +MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS += "cadence-mhdp-fw cnm-wave-fw"
>  
>  TI_CORE_INITRAMFS_KERNEL_MODULES = "kernel-module-cdns-pltfrm kernel-module-ti-j721e-ufs"
>  TI_CORE_INITRAMFS_KERNEL_MODULES:bsp-ti-6_6 = ""
> diff --git a/meta-ti-bsp/conf/machine/j784s4-evm.conf b/meta-ti-bsp/conf/machine/j784s4-evm.conf
> index bf53b07c..f80e030f 100644
> --- a/meta-ti-bsp/conf/machine/j784s4-evm.conf
> +++ b/meta-ti-bsp/conf/machine/j784s4-evm.conf
> @@ -27,3 +27,5 @@ KERNEL_DEVICETREE = " \
>  "
>  
>  UBOOT_MACHINE = "j784s4_evm_a72_defconfig"
> +
> +MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS:append = " ti-eth-fw-j784s4"

Can this be done with += instead of :append?


      parent reply	other threads:[~2026-04-15 20:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-15 11:41 [meta-ti][master][PATCH v1] conf: machine: j784s4: Move ti-eth-fw-j784s4 to EVM conf Franz Schnyder
2026-04-15 11:58 ` Francesco Dolcini
2026-04-15 14:43   ` Andrew Davis
2026-04-15 15:16     ` Francesco Dolcini
2026-04-15 21:10     ` Denys Dmytriyenko
2026-04-16  8:42       ` Francesco Dolcini
2026-04-15 14:00 ` PRC Automation
2026-04-15 20:47 ` Denys Dmytriyenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260415204706.GC4186@denix.org \
    --to=denis@denix.org \
    --cc=fra.schnyder@gmail.com \
    --cc=francesco@dolcini.it \
    --cc=franz.schnyder@toradex.com \
    --cc=meta-ti@lists.yoctoproject.org \
    --cc=reatmon@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox