Yocto Meta Virtualization
 help / color / mirror / Atom feed
From: "Bruce Ashfield" <bruce.ashfield@gmail.com>
To: kai <kai.kang@windriver.com>
Cc: meta-virtualization@lists.yoctoproject.org
Subject: Re: [meta-virtualization] [PATCH] kubernetes: update sed expression
Date: Thu, 30 Sep 2021 22:30:11 -0400	[thread overview]
Message-ID: <20211001023008.GA11771@gmail.com> (raw)
In-Reply-To: <20210926094115.14844-1-kai.kang@windriver.com>


In message: [meta-virtualization] [PATCH] kubernetes: update sed expression
on 26/09/2021 kai wrote:

> From: Kai Kang <kai.kang@windriver.com>
> 
> It misses a backslash in sed expression and causes warning when
> run do_compile:

Since this wasn't actually doing anything, we could likely drop it now.
I remember adding it, and without it, we'd have build issues .. so the
fact that it was building without it being properly done is a good
sign.

That being said, since we are far along in the dev cycle, I'd rather
not experiment with dropping it completely, so I've merged and pushed
the change.

Bruce

> 
> | sed: -e expression #1, char 35: Unmatched ) or \)
> 
> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> ---
>  recipes-containers/kubernetes/kubernetes_git.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/recipes-containers/kubernetes/kubernetes_git.bb b/recipes-containers/kubernetes/kubernetes_git.bb
> index e165ebe..1ba52b6 100644
> --- a/recipes-containers/kubernetes/kubernetes_git.bb
> +++ b/recipes-containers/kubernetes/kubernetes_git.bb
> @@ -50,7 +50,7 @@ do_compile() {
>  	export CGO_CFLAGS="${BUILD_CFLAGS}"
>  	# as of go 1.15.5, there are some flags the CGO doesn't like. Rather than
>  	# clearing them all, we sed away the ones we don't want.
> -	export CGO_LDFLAGS="$(echo ${BUILD_LDFLAGS} | sed 's/-Wl,-O1//g' | sed 's/-Wl,--dynamic-linker.*?( \|$\)//g')"
> +	export CGO_LDFLAGS="$(echo ${BUILD_LDFLAGS} | sed 's/-Wl,-O1//g' | sed 's/-Wl,--dynamic-linker.*?\( \|$\)//g')"
>  	export CC="${BUILD_CC}"
>  	export LD="${BUILD_LD}"
>  
> -- 
> 2.17.1
> 

> 
> 
> 


      reply	other threads:[~2021-10-01  2:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-26  9:41 [PATCH] kubernetes: update sed expression kai
2021-10-01  2:30 ` Bruce Ashfield [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211001023008.GA11771@gmail.com \
    --to=bruce.ashfield@gmail.com \
    --cc=kai.kang@windriver.com \
    --cc=meta-virtualization@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox