Yocto Meta Virtualization
 help / color / mirror / Atom feed
From: "Bruce Ashfield" <bruce.ashfield@gmail.com>
To: Yi Zhao <yi.zhao@windriver.com>
Cc: meta-virtualization@lists.yoctoproject.org
Subject: Re: [meta-virtualization] [meta-cloud-services][PATCH 1/3] openstack-image-compute: fix warning of operator append combined with +=
Date: Wed, 24 Nov 2021 17:03:12 -0500	[thread overview]
Message-ID: <20211124220312.GB41710@gmail.com> (raw)
In-Reply-To: <20211120041652.583066-3-yi.zhao@windriver.com> <20211120041652.583066-2-yi.zhao@windriver.com> <20211120041652.583066-1-yi.zhao@windriver.com>

merged.

Bruce

In message: [meta-virtualization] [meta-cloud-services][PATCH 1/3] openstack-image-compute: fix warning of operator append combined with +=
on 20/11/2021 Yi Zhao wrote:

> Fixes:
> WARNING: openstack-image-compute.bb: IMAGE_ROOTFS_EXTRA_SPACE:append +=
> is not a recommended operator combination, please replace it.
> 
> Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
> ---
>  .../recipes-extended/images/openstack-image-compute.bb          | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-openstack/recipes-extended/images/openstack-image-compute.bb b/meta-openstack/recipes-extended/images/openstack-image-compute.bb
> index 15726fd..a725e2e 100644
> --- a/meta-openstack/recipes-extended/images/openstack-image-compute.bb
> +++ b/meta-openstack/recipes-extended/images/openstack-image-compute.bb
> @@ -19,6 +19,6 @@ inherit monitor
>  
>  # Ensure extra space for guest images, and rabbit MQ has a hard coded
>  # check for 2G of free space, so we use 3G as a starting point.
> -IMAGE_ROOTFS_EXTRA_SPACE:append += "+ 3000000"
> +IMAGE_ROOTFS_EXTRA_SPACE:append = " + 3000000"
>  
>  # ROOTFS_POSTPROCESS_COMMAND += "remove_packaging_data_files ; "
> -- 
> 2.25.1
> 

> 
> 
> 



      parent reply	other threads:[~2021-11-24 22:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-20  4:16 [meta-cloud-services][PATCH 1/3] openstack-image-compute: fix warning of operator append combined with += Yi Zhao
2021-11-20  4:16 ` [meta-cloud-services][PATCH 2/3] openstack-image-controller: " Yi Zhao
2021-11-20  4:16 ` [meta-cloud-services][PATCH 3/3] meta-openstack/README: fix for " Yi Zhao
2021-11-24 22:03 ` Bruce Ashfield [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211124220312.GB41710@gmail.com \
    --to=bruce.ashfield@gmail.com \
    --cc=meta-virtualization@lists.yoctoproject.org \
    --cc=yi.zhao@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox