Yocto Meta Virtualization
 help / color / mirror / Atom feed
From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: sakib.sajal@windriver.com
Cc: meta-virtualization@lists.yoctoproject.org
Subject: Re: [meta-virtualization][PATCH V2] ceph: set CXXFLAGS and CFLAGS
Date: Thu, 24 Mar 2022 08:51:49 -0400	[thread overview]
Message-ID: <20220324125146.GA54203@gmail.com> (raw)
In-Reply-To: <20220322205443.65641-1-sakib.sajal@windriver.com>

thanks for V2!

I forgot that I was testing with v1, and pushed it instead of
this .. but since the functional change is the same, we'll
leave it as-is.

Cheers,

Bruce

In message: [meta-virtualization][PATCH V2] ceph: set CXXFLAGS and CFLAGS
on 22/03/2022 sakib.sajal@windriver.com wrote:

> In oe-core, the commit:
>    a83623a54a Revert "cmake.bbclass: Set CXXFLAGS and CFLAGS"
> 
> drops compiler flags overrides for all cmake-based recipes,
> causing the ceph compile to fail with the error:
>   ld: cannot find crtn.o: No such file or directory
> 
>   collect2: error: ld returned 1 exit status
> 
> Add the override back for ceph to fix the build error.
> 
> Signed-off-by: Sakib Sajal <sakib.sajal@windriver.com>
> ---
>  recipes-extended/ceph/ceph_15.2.15.bb | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/recipes-extended/ceph/ceph_15.2.15.bb b/recipes-extended/ceph/ceph_15.2.15.bb
> index c72953a..17dbcf3 100644
> --- a/recipes-extended/ceph/ceph_15.2.15.bb
> +++ b/recipes-extended/ceph/ceph_15.2.15.bb
> @@ -66,6 +66,9 @@ EXTRA_OECMAKE = "-DWITH_MANPAGE=OFF \
>                   -DWITH_REENTRANT_STRSIGNAL=ON \
>  "
>  
> +CXXFLAGS += "${HOST_CC_ARCH} ${TOOLCHAIN_OPTIONS}"
> +CFLAGS += "${HOST_CC_ARCH} ${TOOLCHAIN_OPTIONS}"
> +
>  export STAGING_DIR_HOST
>  
>  do_configure:prepend () {
> -- 
> 2.25.1
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#7105): https://lists.yoctoproject.org/g/meta-virtualization/message/7105
> Mute This Topic: https://lists.yoctoproject.org/mt/89962111/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 



      reply	other threads:[~2022-03-24 12:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-22 20:54 [meta-virtualization][PATCH V2] ceph: set CXXFLAGS and CFLAGS Sakib Sajal
2022-03-24 12:51 ` Bruce Ashfield [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220324125146.GA54203@gmail.com \
    --to=bruce.ashfield@gmail.com \
    --cc=meta-virtualization@lists.yoctoproject.org \
    --cc=sakib.sajal@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox