Re: [meta-virtualization] [PATCH 1/3] metadata: add whitespace around assignments

Re: [meta-virtualization] [PATCH 1/3] metadata: add whitespace around assignments

[Martin Jansa]

On Wed, Apr 2, 2025 at 5:59 PM Martin Jansa via lists.yoctoproject.org
<martin.jansa=gmail.com@lists.yoctoproject.org> wrote:
>
> From: Martin Jansa <martin.jansa@gmail.com>
>
> With:
> https://lists.openembedded.org/g/bitbake-devel/message/17508
> there are many WARNINGs from this layer will cover src_uri.inc files
> in next commit.

Hi Bruce,

I see you already have them in master-next and I've noticed your
fix-up for cri-tools.

There is one more case like that in:
recipes-containers/docker-distribution/docker-distribution_git.bb:EXTRA_OEMAKE
= "BUILDTAGS = ''"
do you want me to send v2 with both fix-ups included or additional one
for docker-distribution or will you fix it yourself?

I did run a world build with these changes, but some recipes aren't
included for our DISTRO even with world build. Sorry about missing
these 2.

Cheers,

Re: [meta-virtualization] [PATCH 1/3] metadata: add whitespace around assignments

[Bruce Ashfield]

[-- Attachment #1: Type: text/plain, Size: 2058 bytes --]

On Fri, Apr 4, 2025 at 2:34 AM Martin Jansa via lists.yoctoproject.org
<martin.jansa=gmail.com@lists.yoctoproject.org> wrote:

> On Wed, Apr 2, 2025 at 5:59 PM Martin Jansa via lists.yoctoproject.org
> <martin.jansa=gmail.com@lists.yoctoproject.org> wrote:
> >
> > From: Martin Jansa <martin.jansa@gmail.com>
> >
> > With:
> > https://lists.openembedded.org/g/bitbake-devel/message/17508
> > there are many WARNINGs from this layer will cover src_uri.inc files
> > in next commit.
>
> Hi Bruce,
>
> I see you already have them in master-next and I've noticed your
> fix-up for cri-tools.
>
> There is one more case like that in:
> recipes-containers/docker-distribution/docker-distribution_git.bb:
> EXTRA_OEMAKE
> = "BUILDTAGS = ''"
> do you want me to send v2 with both fix-ups included or additional one
> for docker-distribution or will you fix it yourself?
>

I have it tweaked locally, I'll just push it shortly once I've done a bit
more testing on
some unrelated changes.


>
> I did run a world build with these changes, but some recipes aren't
> included for our DISTRO even with world build. Sorry about missing
> these 2.
>

2 really minor issues out of that many changes is excellent. I was just
starting
to write a script (or should I say "generate" a script) to do the same
changes
and you saved me quite a bit of time, so you have my thanks for the
contribution!

Bruce



>
> Cheers,
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#9199):
> https://lists.yoctoproject.org/g/meta-virtualization/message/9199
> Mute This Topic: https://lists.yoctoproject.org/mt/112049203/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [
> bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II

[-- Attachment #2: Type: text/html, Size: 4283 bytes --]