[meta-virtualization][PATCH] cni: make ca-certificates rrecommends

[meta-virtualization][PATCH] cni: make ca-certificates rrecommends

[Patrick Vogelaar]

Moving ca-certificates from RDEPENDS to RRECOMMENDS allows using cni without
installing all the certificates.

Signed-off-by: Patrick Vogelaar <patrick.vogelaar@belden.com>
---
 recipes-networking/cni/cni_git.bb | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/recipes-networking/cni/cni_git.bb b/recipes-networking/cni/cni_git.bb
index e6d71aa2..bd67cd0d 100644
--- a/recipes-networking/cni/cni_git.bb
+++ b/recipes-networking/cni/cni_git.bb
@@ -109,5 +109,4 @@ INSANE_SKIP:${PN} += "ldflags already-stripped"
 
 deltask compile_ptest_base
 
-RDEPENDS:${PN} += " ca-certificates"
-RRECOMMENDS:${PN} += "iptables iproute2"
+RRECOMMENDS:${PN} += "ca-certificates iptables iproute2"
-- 
2.34.1


**********************************************************************
DISCLAIMER:
Privileged and/or Confidential information may be contained in this message. If you are not the addressee of this message, you may not copy, use or deliver this message to anyone. In such event, you should destroy the message and kindly notify the sender by reply e-mail. It is understood that opinions or conclusions that do not relate to the official business of the company are neither given nor endorsed by the company. Thank You.

Re: [meta-virtualization][PATCH] cni: make ca-certificates rrecommends

[Bruce Ashfield]

[-- Attachment #1: Type: text/plain, Size: 2467 bytes --]

On Thu, May 22, 2025 at 4:19 PM Patrick Vogelaar via B4 Relay via
lists.yoctoproject.org <patrick.vogelaar=belden.com@lists.yoctoproject.org>
wrote:

> Moving ca-certificates from RDEPENDS to RRECOMMENDS allows using cni
> without
> installing all the certificates.

Hmmm. This was done on purpose as kubernetes images using cni won't
Come up with the certificates.

So if this changes, those sorts of images will indirectly break.

If this was a configurable option for the recipe (packageconfig), then
It would be acceptable and consuming distros could modify the
Depends if they don't want the certificates to be installed.

Bruce


>
> Signed-off-by: Patrick Vogelaar <patrick.vogelaar@belden.com>
> ---
>  recipes-networking/cni/cni_git.bb | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/recipes-networking/cni/cni_git.bb b/recipes-networking/cni/
> cni_git.bb
> index e6d71aa2..bd67cd0d 100644
> --- a/recipes-networking/cni/cni_git.bb
> +++ b/recipes-networking/cni/cni_git.bb
> @@ -109,5 +109,4 @@ INSANE_SKIP:${PN} += "ldflags already-stripped"
>
>  deltask compile_ptest_base
>
> -RDEPENDS:${PN} += " ca-certificates"
> -RRECOMMENDS:${PN} += "iptables iproute2"
> +RRECOMMENDS:${PN} += "ca-certificates iptables iproute2"
> --
> 2.34.1
>
>
> **********************************************************************
> DISCLAIMER:
> Privileged and/or Confidential information may be contained in this
> message. If you are not the addressee of this message, you may not copy,
> use or deliver this message to anyone. In such event, you should destroy
> the message and kindly notify the sender by reply e-mail. It is understood
> that opinions or conclusions that do not relate to the official business of
> the company are neither given nor endorsed by the company. Thank You.
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#9256):
> https://lists.yoctoproject.org/g/meta-virtualization/message/9256
> Mute This Topic: https://lists.yoctoproject.org/mt/113254268/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [
> bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II

[-- Attachment #2: Type: text/html, Size: 4896 bytes --]

[PATCH] cni: make ca-certificates rrecommends

[Patrick Vogelaar via B4 Relay]

[-- Attachment #1: Type: text/plain, Size: 2663 bytes --]

On Thu, May 22, 2025 at 11:59 PM, Bruce Ashfield wrote:

> 
> 
> 
> On Thu, May 22, 2025 at 4:19 PM Patrick Vogelaar via B4 Relay via lists.yoctoproject.org
> ( http://lists.yoctoproject.org ) <patrick.vogelaar= belden.com@lists.yoctoproject.org
> > wrote:
> 
>> Moving ca-certificates from RDEPENDS to RRECOMMENDS allows using cni
>> without
>> installing all the certificates.
> 
> 
> Hmmm. This was done on purpose as kubernetes images using cni won't
> Come up with the certificates.
> 
> 

Shouldn't this be then a dependency of kubernetes?
> 
> 
> 
> So if this changes, those sorts of images will indirectly break.
> 
> 

This was the reason why I added it as RRECOMMENDS, because it will still be added but can be removed by adding. PACKAGE_EXCLUDE="ca-certificates"

> 
> 
> 
> If this was a configurable option for the recipe (packageconfig), then
> It would be acceptable and consuming distros could modify the
> Depends if they don't want the certificates to be installed.
> 
> 

Should I add it as packageconfig or as dependency of kubernetes?
Patrick

> 
> 
> 
> Bruce
> 
> 
>> Signed-off-by: Patrick Vogelaar < patrick.vogelaar@belden.com >
>> ---
>> recipes-networking/cni/ cni_git.bb ( http://cni_git.bb ) | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>> 
>> diff --git a/recipes-networking/cni/ cni_git.bb ( http://cni_git.bb ) b/recipes-networking/cni/
>> cni_git.bb ( http://cni_git.bb )
>> index e6d71aa2..bd67cd0d 100644
>> --- a/recipes-networking/cni/ cni_git.bb ( http://cni_git.bb )
>> +++ b/recipes-networking/cni/ cni_git.bb ( http://cni_git.bb )
>> @@ -109,5 +109,4 @@ INSANE_SKIP:${PN} += "ldflags already-stripped"
>> 
>> deltask compile_ptest_base
>> 
>> -RDEPENDS:${PN} += " ca-certificates"
>> -RRECOMMENDS:${PN} += "iptables iproute2"
>> +RRECOMMENDS:${PN} += "ca-certificates iptables iproute2"
>> --
>> 2.34.1
>> 
>> 
>> **********************************************************************
>> DISCLAIMER:
>> Privileged and/or Confidential information may be contained in this
>> message. If you are not the addressee of this message, you may not copy,
>> use or deliver this message to anyone. In such event, you should destroy
>> the message and kindly notify the sender by reply e-mail. It is understood
>> that opinions or conclusions that do not relate to the official business
>> of the company are neither given nor endorsed by the company. Thank You.
> 
> 
> 
> 
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await thee
> at its end
> - "Use the force Harry" - Gandalf, Star Trek II
> 
> 
>

[-- Attachment #2: Type: text/html, Size: 5125 bytes --]

Re: [meta-virtualization] [PATCH] cni: make ca-certificates rrecommends

[Bruce Ashfield]

[-- Attachment #1: Type: text/plain, Size: 3671 bytes --]

On Mon, May 26, 2025 at 3:10 AM Patrick Vogelaar via B4 Relay via
lists.yoctoproject.org <patrick.vogelaar=belden.com@lists.yoctoproject.org>
wrote:

> On Thu, May 22, 2025 at 11:59 PM, Bruce Ashfield wrote:
>
>
>
> On Thu, May 22, 2025 at 4:19 PM Patrick Vogelaar via B4 Relay via
> lists.yoctoproject.org <patrick.vogelaar=belden.com@lists.yoctoproject.org>
> wrote:
>
>> Moving ca-certificates from RDEPENDS to RRECOMMENDS allows using cni
>> without
>> installing all the certificates.
>
>
> Hmmm. This was done on purpose as kubernetes images using cni won't
> Come up with the certificates.
>
>
> Shouldn't this be then a dependency of kubernetes?
>
Nope. In this configuration, it is definitely cni that needs the
certificates in the tests that were failing for me, not k8s, so the
dependency belongs here.

>
>
> So if this changes, those sorts of images will indirectly break.
>
>
> This was the reason why I added it as RRECOMMENDS, because it will still
> be added but can be removed by adding. PACKAGE_EXCLUDE="ca-certificates"
>
> Rreccommends are just that .. recommends, they are off in all  the images
I build and test (as an example), so to move it to this, we'd have to show
that all of the various combinations still function with rreccomends
disabled.


>
> If this was a configurable option for the recipe (packageconfig), then
> It would be acceptable and consuming distros could modify the
> Depends if they don't want the certificates to be installed.
>
>
> Should I add it as packageconfig or as dependency of kubernetes?
>
Packageconfig, as I explained above.

Patrick
>
>
>
> Bruce
>
>
>> Signed-off-by: Patrick Vogelaar <patrick.vogelaar@belden.com>
>> ---
>>  recipes-networking/cni/cni_git.bb | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/recipes-networking/cni/cni_git.bb b/recipes-networking/cni/
>> cni_git.bb
>> index e6d71aa2..bd67cd0d 100644
>> --- a/recipes-networking/cni/cni_git.bb
>> +++ b/recipes-networking/cni/cni_git.bb
>> @@ -109,5 +109,4 @@ INSANE_SKIP:${PN} += "ldflags already-stripped"
>>
>>  deltask compile_ptest_base
>>
>> -RDEPENDS:${PN} += " ca-certificates"
>> -RRECOMMENDS:${PN} += "iptables iproute2"
>> +RRECOMMENDS:${PN} += "ca-certificates iptables iproute2"
>> --
>> 2.34.1
>>
>>
>> **********************************************************************
>> DISCLAIMER:
>> Privileged and/or Confidential information may be contained in this
>> message. If you are not the addressee of this message, you may not copy,
>> use or deliver this message to anyone. In such event, you should destroy
>> the message and kindly notify the sender by reply e-mail. It is understood
>> that opinions or conclusions that do not relate to the official business of
>> the company are neither given nor endorsed by the company. Thank You.
>
>
>
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await thee
> at its end
> - "Use the force Harry" - Gandalf, Star Trek II
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#9258):
> https://lists.yoctoproject.org/g/meta-virtualization/message/9258
> Mute This Topic: https://lists.yoctoproject.org/mt/113254268/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [
> bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II

[-- Attachment #2: Type: text/html, Size: 7942 bytes --]