From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: Divya.Chellam@windriver.com
Cc: meta-virtualization@lists.yoctoproject.org
Subject: Re: [meta-virtualization][walnascar][PATCH 1/2] podman: remove ptest
Date: Mon, 13 Oct 2025 21:59:39 -0400 [thread overview]
Message-ID: <aO2uiwdx3jXAHSQ9@gmail.com> (raw)
In-Reply-To: <20251013114725.2268483-1-divya.chellam@windriver.com>
The tests don't do anything, but shouldn't actually break a build, etc.
As such, I don't think we really need to backport this to walnascar.
I've grabbed the CVE fix though.
Bruce
In message: [meta-virtualization][walnascar][PATCH 1/2] podman: remove ptest
on 13/10/2025 dchellam via lists.yoctoproject.org wrote:
> From: Divya Chellam <divya.chellam@windriver.com>
>
> The ptest was added almost three years ago and since then nobody
> ever fixed anything. It's almost impossible that the ptest never
> failed. As an evidence, for the current version, the test cases
> cannot even run.
>
> Remove this ptest. People who care about podman ptest should be
> maintaining it.
>
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> Signed-off-by: Bruce Ashfield <bruce.ashfield@gmail.com>
> (master rev: a8175deded4decb9b889901caabb48bf8c4edc73)
>
> Signed-off-by: Divya Chellam <divya.chellam@windriver.com>
> ---
> recipes-containers/podman/podman/run-ptest | 13 -----------
> recipes-containers/podman/podman_git.bb | 27 +---------------------
> 2 files changed, 1 insertion(+), 39 deletions(-)
> delete mode 100644 recipes-containers/podman/podman/run-ptest
>
> diff --git a/recipes-containers/podman/podman/run-ptest b/recipes-containers/podman/podman/run-ptest
> deleted file mode 100644
> index 108ff451..00000000
> --- a/recipes-containers/podman/podman/run-ptest
> +++ /dev/null
> @@ -1,13 +0,0 @@
> -#!/bin/sh
> -
> -# SPDX-FileCopyrightText: Huawei Inc.
> -#
> -# SPDX-License-Identifier: MIT
> -
> -#
> -# Podman system tests
> -#
> -
> -# The system tests don't need any go related variables. Dummy-define them to
> -# avoid useless warnings/errors.
> -GOOS=undefined GO=true BUILDTAGS= make localsystem
> diff --git a/recipes-containers/podman/podman_git.bb b/recipes-containers/podman/podman_git.bb
> index d98521ba..a83764fc 100644
> --- a/recipes-containers/podman/podman_git.bb
> +++ b/recipes-containers/podman/podman_git.bb
> @@ -20,7 +20,6 @@ SRCREV = "227df90eb7c021097c9ba5f8000c83648a598028"
> SRC_URI = " \
> git://github.com/containers/libpod.git;branch=v5.4;protocol=https;destsuffix=${GO_SRCURI_DESTSUFFIX} \
> ${@bb.utils.contains('PACKAGECONFIG', 'rootless', 'file://50-podman-rootless.conf', '', d)} \
> - file://run-ptest \
> file://CVE-2025-6032.patch;patchdir=src/import \
> "
>
> @@ -56,7 +55,7 @@ export BUILDFLAGS = "${GOBUILDFLAGS}"
>
> inherit go goarch
> inherit container-host
> -inherit systemd pkgconfig ptest
> +inherit systemd pkgconfig
>
> do_configure[noexec] = "1"
>
> @@ -129,17 +128,6 @@ do_install() {
> fi
> }
>
> -do_install_ptest () {
> - cp ${S}/src/import/Makefile ${D}${PTEST_PATH}
> - install -d ${D}${PTEST_PATH}/test
> - cp -r ${S}/src/import/test/system ${D}${PTEST_PATH}/test
> -
> - # Some compatibility links for the Makefile assumptions.
> - install -d ${D}${PTEST_PATH}/bin
> - ln -s ${bindir}/podman ${D}${PTEST_PATH}/bin/podman
> - ln -s ${bindir}/podman-remote ${D}${PTEST_PATH}/bin/podman-remote
> -}
> -
> FILES:${PN} += " \
> ${systemd_unitdir}/system/* \
> ${nonarch_libdir}/systemd/* \
> @@ -170,16 +158,3 @@ RRECOMMENDS:${PN} += "slirp4netns \
> kernel-module-xt-tcpudp \
> "
> RCONFLICTS:${PN} = "${@bb.utils.contains('PACKAGECONFIG', 'docker', 'docker', '', d)}"
> -
> -RDEPENDS:${PN}-ptest += " \
> - bash \
> - bats \
> - buildah \
> - coreutils \
> - file \
> - gnupg \
> - jq \
> - make \
> - skopeo \
> - tar \
> -"
> --
> 2.40.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#9414): https://lists.yoctoproject.org/g/meta-virtualization/message/9414
> Mute This Topic: https://lists.yoctoproject.org/mt/115732681/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
prev parent reply other threads:[~2025-10-14 1:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 11:47 [meta-virtualization][walnascar][PATCH 1/2] podman: remove ptest dchellam
2025-10-13 11:47 ` [meta-virtualization][walnascar][PATCH 2/2] podman: fix CVE-2025-9566 dchellam
2025-10-14 1:59 ` Bruce Ashfield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aO2uiwdx3jXAHSQ9@gmail.com \
--to=bruce.ashfield@gmail.com \
--cc=Divya.Chellam@windriver.com \
--cc=meta-virtualization@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox