Yocto Meta Virtualization
 help / color / mirror / Atom feed
From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: Kris.Gavvala@windriver.com
Cc: meta-virtualization@lists.yoctoproject.org
Subject: Re: [meta-virtualization][PATCH] lxc: delete extraneous PACKAGECONFIG[systemd] line
Date: Tue, 28 Apr 2026 11:46:56 +0000	[thread overview]
Message-ID: <afCeMLdDVYBek9c8@gmail.com> (raw)
In-Reply-To: <20260427204856.86829-1-kris.gavvala@windriver.com>

In message: [meta-virtualization][PATCH] lxc: delete extraneous PACKAGECONFIG[systemd] line
on 27/04/2026 Gavvala, Kris via lists.yoctoproject.org wrote:

> The PACKAGECONFIG[systemd] variable is assigned twice, with the second assignment overriding the first.
> This patch removes the unused assignment to avoid confusion.
> 
> The duplication was introduced in an August 25, 2022 patch:
> 	05f316f7 lxc: update to 5.x and meson

Ha! I messed that up some time ago :)

Thanks for the fix, it is merged to master

Bruce

> 
> Verfied that the build did not change after this deletion by checking the log files before and after
> and finding the same message:
> 
> 	export systemd_system_unitdir="/usr/lib/systemd/system"
> 	export systemd_unitdir="/usr/lib/systemd"
> 	export systemd_user_unitdir="/usr/lib/systemd/user"
> 
> Signed-off-by: Kris Gavvala <kris.gavvala@windriver.com>
> ---
>  recipes-containers/lxc/lxc_git.bb | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/recipes-containers/lxc/lxc_git.bb b/recipes-containers/lxc/lxc_git.bb
> index f08d793d..3de9a8e9 100644
> --- a/recipes-containers/lxc/lxc_git.bb
> +++ b/recipes-containers/lxc/lxc_git.bb
> @@ -80,7 +80,6 @@ PACKAGECONFIG[apparmor] = "-Dapparmor=true,-Dapparmor=false,apparmor,apparmor"
>  PACKAGECONFIG[templates] = ",,, ${PN}-templates"
>  PACKAGECONFIG[selinux] = "-Dselinux=true,-Dselinux=false,libselinux,libselinux"
>  PACKAGECONFIG[seccomp] = "-Dseccomp=true,-Dseccomp=false,libseccomp,libseccomp"
> -PACKAGECONFIG[systemd] = "-Dsystemd-unitdir=${sysconfdir}/systemd/system/, -Dsystemd-unitdir=, systemd,"
>  PACKAGECONFIG[systemd] = "-Dinit-script=systemd,-Dinit-script=sysvinit,systemd,"
>  
>  # required by python3 to run setup.py
> -- 
> 2.49.0
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#9747): https://lists.yoctoproject.org/g/meta-virtualization/message/9747
> Mute This Topic: https://lists.yoctoproject.org/mt/119038529/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 



      reply	other threads:[~2026-04-28 11:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-27 20:48 [meta-virtualization][PATCH] lxc: delete extraneous PACKAGECONFIG[systemd] line Kris Gavvala
2026-04-28 11:46 ` Bruce Ashfield [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afCeMLdDVYBek9c8@gmail.com \
    --to=bruce.ashfield@gmail.com \
    --cc=Kris.Gavvala@windriver.com \
    --cc=meta-virtualization@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox