From: Trevor Woerner <twoerner@gmail.com>
To: yocto-patches@lists.yoctoproject.org
Subject: [wic][PATCH 1/5] ksparser: reject negative sizes in sizetype()
Date: Wed, 15 Jul 2026 18:32:22 -0400 [thread overview]
Message-ID: <20260715223226.3371498-2-twoerner@gmail.com> (raw)
In-Reply-To: <20260715223226.3371498-1-twoerner@gmail.com>
sizetype() splits "<num>[S|s|K|k|M|G]" into an integer count and a unit
suffix, then multiplies. int() happily parses a leading minus, so "-1M"
produced -1024 and "-5" produced -5120 with no complaint. A negative
size is meaningless for every consumer of sizetype() (--size,
--fixed-size, --offset, --extra-*-space, and the empty source plugin's
size=/bs= params); it can only corrupt the resulting image layout.
Reject a negative size with the same ArgumentTypeError the parser already
raises for other malformed sizes.
AI-Generated: codex/claude-opus 4.8 (xhigh)
Signed-off-by: Trevor Woerner <twoerner@gmail.com>
---
src/wic/ksparser.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/wic/ksparser.py b/src/wic/ksparser.py
index 8e5fbfadd81f..24c7015b336d 100644
--- a/src/wic/ksparser.py
+++ b/src/wic/ksparser.py
@@ -68,6 +68,8 @@ def sizetype(default, size_in_bytes=False):
except ValueError:
raise ArgumentTypeError("Invalid size: %r" % arg)
+ if size < 0:
+ raise ArgumentTypeError("Invalid size: %r" % arg)
if size_in_bytes:
if suffix == 's' or suffix == 'S':
--
2.50.0.173.g8b6f19ccfc3a
next prev parent reply other threads:[~2026-07-15 22:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 22:32 [wic][PATCH 0/5] ksparser: four argparse-type fixes plus unit coverage Trevor Woerner
2026-07-15 22:32 ` Trevor Woerner [this message]
2026-07-15 22:32 ` [wic][PATCH 2/5] ksparser: fix crash on out-of-range overhead factor Trevor Woerner
2026-07-15 22:32 ` [wic][PATCH 3/5] ksparser: reject non-finite overhead factors Trevor Woerner
2026-07-15 22:32 ` [wic][PATCH 4/5] ksparser: require an explicit 0x prefix for --system-id Trevor Woerner
2026-07-15 22:32 ` [wic][PATCH 5/5] tests/unit/test_ksparser_types: cover ksparser's argparse types Trevor Woerner
2026-07-16 7:37 ` [yocto-patches] [wic][PATCH 0/5] ksparser: four argparse-type fixes plus unit coverage Paul Barker
2026-07-17 14:01 ` Trevor Woerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260715223226.3371498-2-twoerner@gmail.com \
--to=twoerner@gmail.com \
--cc=yocto-patches@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox