From: Marcel Hamer <marcel@solidxs.se>
To: yocto-patches@lists.yoctoproject.org, twoerner@gmail.com
Subject: Re: [yocto-patches] [wic][PATCH] wic/plugins: allow timeout of 0 for systemd-boot
Date: Mon, 5 Oct 2026 13:27:58 +0200 [thread overview]
Message-ID: <asOJvoJhF9ejKGC1@debian> (raw)
In-Reply-To: <18CF5E858E7BBEE2.642712@lists.yoctoproject.org>
On Wed, Aug 26, 2026 at 03:38:17PM +0200, Marcel Hamer via lists.yoctoproject.org wrote:
> Setting a timeout value of 0 for systemd-boot evaluated to False and
> caused for a default timeout value of 5 to be set instead of 0.
>
> A timeout of 0 is a valid loader.conf value for systemd-boot.
>
> Signed-off-by: Marcel Hamer <marcel@solidxs.se>
> ---
> src/wic/plugins/source/bootimg_efi.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/wic/plugins/source/bootimg_efi.py b/src/wic/plugins/source/bootimg_efi.py
> index fe6c222..1f73f85 100644
> --- a/src/wic/plugins/source/bootimg_efi.py
> +++ b/src/wic/plugins/source/bootimg_efi.py
> @@ -145,7 +145,8 @@ class BootimgEFIPlugin(SourcePlugin):
> loader_conf = ""
>
> # 5 seconds is a sensible default timeout
> - loader_conf += "timeout %d\n" % (bootloader.timeout or 5)
> + timeout_val = bootloader.timeout if bootloader.timeout is not None else 5
> + loader_conf += f"timeout {timeout_val}\n"
>
> logger.debug("Writing systemd-boot config "
> "%s/hdd/boot/loader/loader.conf", cr_workdir)
> --
> 2.47.3
>
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#4688): https://lists.yoctoproject.org/g/yocto-patches/message/4688
> Mute This Topic: https://lists.yoctoproject.org/mt/120937070/10601239
> Group Owner: yocto-patches+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/yocto-patches/leave/15379525/10601239/1389662109/xyzzy [marcel@solidxs.se]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
Hello,
Just wanted to a gentle ping on this patch proposal. Just wondering if
this was wrongly addressed or if something is missing.
It seems a similar solution is proposed in:
https://lists.yoctoproject.org/g/yocto-patches/message/4960
Thanks!
Kind regards,
Marcel
parent reply other threads:[~2026-10-05 11:28 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <18CF5E858E7BBEE2.642712@lists.yoctoproject.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asOJvoJhF9ejKGC1@debian \
--to=marcel@solidxs.se \
--cc=twoerner@gmail.com \
--cc=yocto-patches@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox