From: "Trevor Woerner" <twoerner@gmail.com>
To: Joshua Watt <jpewhacker@gmail.com>
Cc: yocto@lists.yoctoproject.org
Subject: Re: [meta-rockchip][PATCH] Use TF-A recipe from meta-arm
Date: Thu, 25 Jun 2020 16:41:47 -0400 [thread overview]
Message-ID: <20200625204147.GA14796@linux-uys3> (raw)
In-Reply-To: <8c7bac88-d8f1-1ce9-1128-40a29fa5b60d@gmail.com>
On Thu 2020-06-25 @ 11:03:17 AM, Joshua Watt wrote:
>
> On 6/24/20 10:44 PM, Trevor Woerner wrote:
> > On Wed 2020-06-24 @ 11:30:57 PM, Trevor Woerner wrote:
> > > On Fri 2020-06-12 @ 12:38:23 PM, Joshua Watt wrote:
> > > > diff --git a/recipes-bsp/u-boot/u-boot%.bbappend b/recipes-bsp/u-boot/u-boot%.bbappend
> > > > index 401d649..042507d 100644
> > > > --- a/recipes-bsp/u-boot/u-boot%.bbappend
> > > > +++ b/recipes-bsp/u-boot/u-boot%.bbappend
> > > > @@ -7,8 +7,8 @@ do_compile_append_rock2-square () {
> > > > ATF_DEPENDS ??= ""
> > > > -EXTRA_OEMAKE_append_rk3399 = " BL31=${DEPLOY_DIR_IMAGE}/bl31.elf"
> > > > -ATF_DEPENDS_rk3399 = "virtual/atf:do_deploy"
> > > > +EXTRA_OEMAKE_append_rk3399 = " BL31=${DEPLOY_DIR_IMAGE}/bl31-rk3399.elf"
> > > The space you've included at the start of the following string makes me stop
> > > and double-check... did you mean to add an "_append" in the following symbol?
> > >
> > > > +ATF_DEPENDS_rk3399 = " virtual/trusted-firmware-a:do_deploy"
> > Ah… I should have read the next line before replying. I see you switched from
> > += to .= and hence the space. A bit curious, though?
>
> It prevents the recipe adding in an extra space to the task depends when the
> machine is not an rk3399, which helps the layer by YP 2.0 compatible
Ah, thanks for the clarification.
Applied to master, thanks!
prev parent reply other threads:[~2020-06-25 20:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 17:38 [meta-rockchip][PATCH] Use TF-A recipe from meta-arm Joshua Watt
2020-06-25 3:30 ` Trevor Woerner
2020-06-25 3:44 ` Trevor Woerner
2020-06-25 16:03 ` Joshua Watt
2020-06-25 20:41 ` Trevor Woerner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200625204147.GA14796@linux-uys3 \
--to=twoerner@gmail.com \
--cc=jpewhacker@gmail.com \
--cc=yocto@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox