From: Trevor Woerner <twoerner@gmail.com>
To: Quentin Schulz <foss@0leil.net>
Cc: yocto@lists.yoctoproject.org,
Quentin Schulz <quentin.schulz@theobroma-systems.com>,
Quentin Schulz <foss+yocto@0leil.net>
Subject: Re: [yocto] [meta-rockchip][kirkstone][PATCH] bsp: rkbin: fix default COMPATIBLE_MACHINE matching all
Date: Wed, 25 Oct 2023 09:43:31 -0400 [thread overview]
Message-ID: <20231025134331.GB9170@localhost> (raw)
In-Reply-To: <20231016112233.221066-1-foss+yocto@0leil.net>
On Mon 2023-10-16 @ 01:22:33 PM, Quentin Schulz wrote:
> From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
>
> The goal of the default COMPATIBLE_MACHINE was to not allow
> rockchip-rkbin to be even parsed if a MACHINE isn't part of the
> COMPATIBLE_MACHINE.
>
> However, COMPATIBLE_MACHINE is a regexp checked using Python's re module
> approximately like:
> """
> if re.match(COMPATIBLE_MACHINE, MACHINE):
> return True
> """
>
> and re.match() returns a match whatever MACHINE is if COMPATIBLE_MACHINE
> is the empty string.
>
> Therefore, let's change it to `^$` which only matches the empty string,
> which shouldn't be possible for anything in MACHINEOVERRIDES, and if it
> is there are probably bigger problems than parsing rockchip-rkbin.
>
> Fixes: 3c7f532c2e25 ("rk3588(s): add")
> Cc: Quentin Schulz <foss+yocto@0leil.net>
> Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
> ---
> recipes-bsp/rkbin/rockchip-rkbin_git.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to meta-rockchip, kirkstone branch. Thanks!
prev parent reply other threads:[~2023-10-25 13:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 11:22 [meta-rockchip][kirkstone][PATCH] bsp: rkbin: fix default COMPATIBLE_MACHINE matching all Quentin Schulz
2023-10-16 15:27 ` [yocto] Using cmake... how? Dave Hitchman
2023-10-16 19:48 ` Khem Raj
2023-10-17 5:49 ` Mikko Rapeli
2023-10-17 9:21 ` Dave Hitchman
2023-10-17 9:52 ` Mikko Rapeli
2023-10-17 10:09 ` Dave Hitchman
2023-10-17 10:22 ` Mikko Rapeli
2023-10-17 11:35 ` Dave Hitchman
2023-10-17 11:42 ` Mikko Rapeli
2023-10-17 11:53 ` Mikko Rapeli
2023-10-17 11:58 ` Dave Hitchman
2023-10-17 12:23 ` Mikko Rapeli
2023-10-17 13:32 ` Ross Burton
2023-10-17 15:18 ` Dave Hitchman
2023-10-25 13:43 ` Trevor Woerner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231025134331.GB9170@localhost \
--to=twoerner@gmail.com \
--cc=foss+yocto@0leil.net \
--cc=foss@0leil.net \
--cc=quentin.schulz@theobroma-systems.com \
--cc=yocto@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox