Yocto Project Discussions
 help / color / mirror / Atom feed
From: Trevor Woerner <twoerner@gmail.com>
To: Quentin Schulz <quentin.schulz@theobroma-systems.com>
Cc: yocto@lists.yoctoproject.org
Subject: Re: [yocto] [meta-rockchip][PATCH] u-boot: make rock-pi-e patches only for rock-pi-e
Date: Wed, 24 Jan 2024 13:21:35 -0500	[thread overview]
Message-ID: <20240124182135.GA4040@localhost> (raw)
In-Reply-To: <c1918525-5ebc-4df6-9bf7-5ca09c553f91@theobroma-systems.com>

On Wed 2024-01-24 @ 06:56:01 PM, Quentin Schulz wrote:
> Hi Trevor,
> 
> On 1/24/24 18:51, Trevor Woerner via lists.yoctoproject.org wrote:
> > The U-Boot patches that were added recently are only for the rock-pi-e
> > MACHINE, therefore only apply them when building for rock-pi-e.
> > 
> > Fixes: b5bba3a01197 ("rock-pi-e: apply upstream PHY fix")
> > Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> 
> Reviewed-by: Quentin Schulz <foss+yocto@0leil.net>
> 
> What a nice timing, got "bothered" by this a few hours ago but got
> sidetracked :)
> 
> I **think** this would make more sense in a u-boot_2024.01.bbappend though,
> since it'll likely only apply on top of that version :)

Hopefully these patches go upstream soon, when it does my nightly build will
fail, and I can remove it the next day. But if the patches don't get into the
next release then rock-pi-e's second ethernet will stop working again if we
make it version-specific.

> Cheers,
> Quentin


  reply	other threads:[~2024-01-24 18:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-24 17:51 [meta-rockchip][PATCH] u-boot: make rock-pi-e patches only for rock-pi-e Trevor Woerner
2024-01-24 17:56 ` [yocto] " Quentin Schulz
2024-01-24 18:21   ` Trevor Woerner [this message]
     [not found] <17AD59E5EC73CFB5.23445@lists.yoctoproject.org>
2024-01-25  2:01 ` Trevor Woerner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240124182135.GA4040@localhost \
    --to=twoerner@gmail.com \
    --cc=quentin.schulz@theobroma-systems.com \
    --cc=yocto@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox