From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Armin Kuster <akuster808@gmail.com>, yocto@lists.yoctoproject.org
Subject: Re: [yocto] [meta-security][PATCH] layer: add more memory for Qemu machines
Date: Wed, 28 Jun 2023 17:47:21 +0100 [thread overview]
Message-ID: <bb92fedccd554006ed61fdb765c6655b7d9eb539.camel@linuxfoundation.org> (raw)
In-Reply-To: <20230628125609.1327477-1-akuster808@gmail.com>
On Wed, 2023-06-28 at 08:56 -0400, Armin Kuster wrote:
> Signed-off-by: Armin Kuster <akuster808@gmail.com>
> ---
> conf/layer.conf | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/conf/layer.conf b/conf/layer.conf
> index 334a945..5f289cb 100644
> --- a/conf/layer.conf
> +++ b/conf/layer.conf
> @@ -28,4 +28,7 @@ INHERIT += "sanity-meta-security"
>
> QB_KERNEL_CMDLINE_APPEND = " ${@bb.utils.contains('DISTRO_FEATURES', 'apparmor', 'apparmor=1 security=apparmor', '', d)}"
>
> +# We need more mem to run many apps in this layer
> +QB_MEM="-m 2048"
> +
> addpylib ${LAYERDIR}/lib oeqa
Putting that unconditionally in a layer.conf is a pretty poor thing to
do for usability IMO as it effectively forces that decision on anyone
including the layer. There has to be a better way to handle that, at
least conditionally on some override?
Cheers,
Richard
next prev parent reply other threads:[~2023-06-28 16:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 12:56 [meta-security][PATCH] layer: add more memory for Qemu machines Armin Kuster
2023-06-28 16:47 ` Richard Purdie [this message]
2023-06-28 18:18 ` [yocto] " akuster808
2023-06-29 10:45 ` Mikko Rapeli
2023-06-29 10:48 ` Richard Purdie
2023-06-29 14:12 ` Ross Burton
[not found] ` <176D1B62EFBE2E3C.12483@lists.yoctoproject.org>
2023-06-29 10:48 ` Mikko Rapeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb92fedccd554006ed61fdb765c6655b7d9eb539.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=akuster808@gmail.com \
--cc=yocto@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox