Re: [yocto] [meta-gplv2] [PATCH] gnupg: Make it build with GCC 10 (which uses -fno-common by default)

["Joshua Watt" <JPEWhacker@gmail.com>]

On 10/5/20 3:36 PM, Peter Kjellerstedt wrote:
>> -----Original Message-----
>> From: yocto@lists.yoctoproject.org <yocto@lists.yoctoproject.org> On
>> Behalf Of Joshua Watt
>> Sent: den 1 oktober 2020 15:27
>> To: Khem Raj <raj.khem@gmail.com>
>> Cc: Peter Kjellerstedt <peter.kjellerstedt@axis.com>;
>> yocto@lists.yoctoproject.org
>> Subject: Re: [yocto] [meta-gplv2] [PATCH] gnupg: Make it build with GCC
>> 10 (which uses -fno-common by default)
>>
>> On Wed, Sep 30, 2020 at 4:34 PM Khem Raj <raj.khem@gmail.com> wrote:
>>> On Wed, Sep 30, 2020 at 1:37 PM Joshua Watt <JPEWhacker@gmail.com>
>> wrote:
>>>> With this patch applied, I get the following errors when using the
>>>> latest master branches:
>>>>
>>>> | ../mpi/libmpi.a(mpiutil.o): In function `mpi_alloc_limb_space':
>>>> | mpiutil.c:(.text+0x84): undefined reference to `memory_debug_mode'
>>>> | ../mpi/libmpi.a(mpiutil.o): In function `mpi_alloc':
>>>> | mpiutil.c:(.text+0xda): undefined reference to `memory_debug_mode'
>>>> | ../mpi/libmpi.a(mpiutil.o): In function `mpi_alloc_secure':
>>>> | mpiutil.c:(.text+0x14a): undefined reference to `memory_debug_mode'
>>>> | ../mpi/libmpi.a(mpiutil.o): In function `mpi_free_limb_space':
>>>> | mpiutil.c:(.text+0x1c7): undefined reference to `memory_debug_mode'
>>>> | ../mpi/libmpi.a(mpiutil.o): In function `mpi_free':
>>>> | mpiutil.c:(.text+0x267): undefined reference to `memory_debug_mode'
>>>> | ../util/libutil.a(iobuf.o): In function `file_filter':
>>>> | iobuf.c:(.text+0x1c0): undefined reference to `iobuf_debug_mode'
>>>> | iobuf.c:(.text+0x1ea): undefined reference to `iobuf_debug_mode'
>>>> | iobuf.c:(.text+0x2e0): undefined reference to `iobuf_debug_mode'
>>>> | iobuf.c:(.text+0x305): undefined reference to `iobuf_debug_mode'
>>>> | ../util/libutil.a(iobuf.o): In function `underflow':
>>>> | iobuf.c:(.text+0x4b3): undefined reference to `iobuf_debug_mode'
>>>> | ../util/libutil.a(iobuf.o):iobuf.c:(.text+0x567): more undefined
>>>> references to `iobuf_debug_mode' follow
>>>> | collect2: error: ld returned 1 exit status
>>>>
>>>> If I revert this commit, gnupg-native will again build correctly. Any
>>>> ideas?
> Interesting. I had not considered building the recipes from
> meta-gplv2 for native as we only use them for target builds.
>
>>> does it help if you add -fno-common to native CFLAGS
>> No. It works in all cases if I remove the patch and use "-fcommon"
>> though. Oddly enough, in my build having the patch caused the target
>> recipe to fail one way, and not having it caused it to fail another
>> way....
> Are you saying you still have build failures when building gnupg for
> target as well, with the patch applied?
>
>> not sure what's going on there, but I suspect for something
>> this old, adding "-fcommon" to restore the original behavior makes the
>> most sense.
> Anyway, I get the same errors as above when I try building it for
> native using gcc 9.3.1. I'll look into it and see if I can improve
> the patch, or if I will have to resort to using -fcommon.

Any update on this?

FWIW, I think with something this old it's probably best to keep the 
-fcommon behavior rather than try to patch around it.


>
> //Peter
>