Re: S3 is broken again in xen-unstable

[Ben Guthro <ben.guthro@gmail.com>]

On May 7, 2013, at 4:40 AM, Jan Beulich <JBeulich@suse.com> wrote:

>>>> On 07.05.13 at 10:34, Pasi Kärkkäinen<pasik@iki.fi> wrote:
>> On Fri, Apr 26, 2013 at 07:41:07PM -0400, Ben Guthro wrote:
>>> Then, also the ns16550 change.
>>> While strictly not necessary to fix S3 in the normal path, it does fix
>>> a bug that can lead to S3 not working if you
>>>   a. have one of these SuperIO controllers on the LPC bus.
>>>   b. have serial enabled.
>> http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;hn96c186d23873597896051b0
>> 43cfeb119c4a7d5
>>
>> Jan: I think this ns16550 patch should be backported to 4.2 branch aswell..
>
> Yeah, as being secondary I left this off until we know that this
> really is the only thing known to break resume (i.e. I saw no point
> in backporting this when in the end S3 still wouldn't work anyway).
>
> Ben - am I right in understanding your earlier summary in this
> thread to mean that the 4.2 branch, according to your testing,
> is now is such a state?
>

Yea, S3 works on the 4.2.3 branch without this patch. This fixes a
specific corner case on some machines with the SuperIO hardware.