* ceph_setattr mask
@ 2012-02-14 0:05 Noah Watkins
2012-02-14 16:50 ` Gregory Farnum
2012-02-14 16:59 ` Sławomir Skowron
0 siblings, 2 replies; 6+ messages in thread
From: Noah Watkins @ 2012-02-14 0:05 UTC (permalink / raw)
To: ceph-devel
Howdy,
It looks like ceph_fs.h contains the mask flags (e.g. CEPH_SETATTR_MODE) used in ceph_setattr, but I do not see these flags in any header installed from .deb files (grep /usr/include/*).
Am I missing a location? Should these flags be part of the installed headers?
Thanks,
-Noah
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ceph_setattr mask
2012-02-14 0:05 ceph_setattr mask Noah Watkins
@ 2012-02-14 16:50 ` Gregory Farnum
2012-02-14 17:00 ` Noah Watkins
2012-02-14 16:59 ` Sławomir Skowron
1 sibling, 1 reply; 6+ messages in thread
From: Gregory Farnum @ 2012-02-14 16:50 UTC (permalink / raw)
To: Noah Watkins; +Cc: ceph-devel
On Mon, Feb 13, 2012 at 4:05 PM, Noah Watkins <jayhawk@cs.ucsc.edu> wrote:
> Howdy,
>
> It looks like ceph_fs.h contains the mask flags (e.g. CEPH_SETATTR_MODE) used in ceph_setattr, but I do not see these flags in any header installed from .deb files (grep /usr/include/*).
>
> Am I missing a location? Should these flags be part of the installed headers?
You're right, those flags are only specified in ceph_fs.h. I don't
think it's appropriate to include that file in user-facing stuff as
it's mostly things that I'd consider to be Ceph internals, but the
CEPH_SETATTR_* stuff is obviously public since you need them for
ceph_setattr. My inclination would be to either move or duplicate them
into a header that's already installed, but I'm not sure which one is
best for that. Do you have any thoughts as a user? :)
-Greg
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ceph_setattr mask
2012-02-14 16:50 ` Gregory Farnum
@ 2012-02-14 17:00 ` Noah Watkins
2012-02-14 17:03 ` Sage Weil
0 siblings, 1 reply; 6+ messages in thread
From: Noah Watkins @ 2012-02-14 17:00 UTC (permalink / raw)
To: Gregory Farnum; +Cc: ceph-devel
On Feb 14, 2012, at 8:50 AM, Gregory Farnum wrote:
>
> You're right, those flags are only specified in ceph_fs.h. I don't
> think it's appropriate to include that file in user-facing stuff as
> it's mostly things that I'd consider to be Ceph internals, but the
> CEPH_SETATTR_* stuff is obviously public since you need them for
> ceph_setattr. My inclination would be to either move or duplicate them
> into a header that's already installed, but I'm not sure which one is
> best for that. Do you have any thoughts as a user? :)
java-libcephfs has a build dependency on libcephfs-dev deb that only contains libcephfs.h. These flags must be available during build and it seems to make little sense to add another header just for these bits. So as far as moving vs copying I'm not sure, but exposing all of ceph_fs.h seems like overkill. Related: does Ceph re-use the POSIX bit masks for mode_t?
-Noah
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ceph_setattr mask
2012-02-14 17:00 ` Noah Watkins
@ 2012-02-14 17:03 ` Sage Weil
2012-02-14 18:48 ` Noah Watkins
0 siblings, 1 reply; 6+ messages in thread
From: Sage Weil @ 2012-02-14 17:03 UTC (permalink / raw)
To: Noah Watkins; +Cc: Gregory Farnum, ceph-devel
On Tue, 14 Feb 2012, Noah Watkins wrote:
> On Feb 14, 2012, at 8:50 AM, Gregory Farnum wrote:
> > You're right, those flags are only specified in ceph_fs.h. I don't
> > think it's appropriate to include that file in user-facing stuff as
> > it's mostly things that I'd consider to be Ceph internals, but the
> > CEPH_SETATTR_* stuff is obviously public since you need them for
> > ceph_setattr. My inclination would be to either move or duplicate them
> > into a header that's already installed, but I'm not sure which one is
> > best for that. Do you have any thoughts as a user? :)
>
> java-libcephfs has a build dependency on libcephfs-dev deb that only
> contains libcephfs.h. These flags must be available during build and it
> seems to make little sense to add another header just for these bits. So
> as far as moving vs copying I'm not sure, but exposing all of ceph_fs.h
> seems like overkill.
The simplest thing is to probably duplicate them (with an #ifndef guard)
in libcephfs.h. I'll push something to do that now.
> Related: does Ceph re-use the POSIX bit masks for mode_t?
Yep!
sage
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ceph_setattr mask
2012-02-14 17:03 ` Sage Weil
@ 2012-02-14 18:48 ` Noah Watkins
0 siblings, 0 replies; 6+ messages in thread
From: Noah Watkins @ 2012-02-14 18:48 UTC (permalink / raw)
To: Sage Weil; +Cc: ceph-devel
On Feb 14, 2012, at 9:03 AM, Sage Weil wrote:
>>
>> java-libcephfs has a build dependency on libcephfs-dev deb that only
>> contains libcephfs.h. These flags must be available during build and it
>> seems to make little sense to add another header just for these bits. So
>> as far as moving vs copying I'm not sure, but exposing all of ceph_fs.h
>> seems like overkill.
>
> The simplest thing is to probably duplicate them (with an #ifndef guard)
> in libcephfs.h. I'll push something to do that now.
Works great. Thanks.
- Noah
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ceph_setattr mask
2012-02-14 0:05 ceph_setattr mask Noah Watkins
2012-02-14 16:50 ` Gregory Farnum
@ 2012-02-14 16:59 ` Sławomir Skowron
1 sibling, 0 replies; 6+ messages in thread
From: Sławomir Skowron @ 2012-02-14 16:59 UTC (permalink / raw)
To: Noah Watkins; +Cc: ceph-devel@vger.kernel.org
Pozdrawiam
iSS
On 14 lut 2012, at 01:05, Noah Watkins <jayhawk@cs.ucsc.edu> wrote:
> Howdy,
>
> It looks like ceph_fs.h contains the mask flags (e.g. CEPH_SETATTR_MODE) used in ceph_setattr, but I do not see these flags in any header installed from .deb files (grep /usr/include/*).
>
> Am I missing a location? Should these flags be part of the installed headers?
>
> Thanks,
> -Noah--
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-02-14 18:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-14 0:05 ceph_setattr mask Noah Watkins
2012-02-14 16:50 ` Gregory Farnum
2012-02-14 17:00 ` Noah Watkins
2012-02-14 17:03 ` Sage Weil
2012-02-14 18:48 ` Noah Watkins
2012-02-14 16:59 ` Sławomir Skowron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.