* Re: [syzbot] [ntfs3?] possible deadlock in ni_fiemap
[not found] <023c2035-91d2-4e0d-a2ce-7aacd763ac0d@paragon-software.com>
@ 2024-07-20 8:38 ` syzbot
0 siblings, 0 replies; 3+ messages in thread
From: syzbot @ 2024-07-20 8:38 UTC (permalink / raw)
To: almaz.alexandrovich, linux-kernel, syzkaller-bugs
Hello,
syzbot has tested the proposed patch but the reproducer is still triggering an issue:
possible deadlock in attr_data_get_block
======================================================
WARNING: possible circular locking dependency detected
6.10.0-rc1-syzkaller-00035-gd57431c6f511 #0 Not tainted
------------------------------------------------------
syz-executor.0/5470 is trying to acquire lock:
ffff88807655e840 (&ni->ni_lock/4){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1107 [inline]
ffff88807655e840 (&ni->ni_lock/4){+.+.}-{3:3}, at: attr_data_get_block+0x463/0x2ff0 fs/ntfs3/attrib.c:917
but task is already holding lock:
ffff88807e94ea18 (&mm->mmap_lock){++++}-{3:3}, at: mmap_write_lock_killable include/linux/mmap_lock.h:122 [inline]
ffff88807e94ea18 (&mm->mmap_lock){++++}-{3:3}, at: vm_mmap_pgoff+0x17c/0x3d0 mm/util.c:571
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #1 (&mm->mmap_lock){++++}-{3:3}:
lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754
__might_fault+0xc6/0x120 mm/memory.c:6233
_copy_to_user+0x2a/0xb0 lib/usercopy.c:41
copy_to_user include/linux/uaccess.h:191 [inline]
fiemap_fill_next_extent+0x235/0x410 fs/ioctl.c:145
ni_fiemap+0x4f5/0x1910 fs/ntfs3/frecord.c:1993
ntfs_fiemap+0x132/0x180 fs/ntfs3/file.c:1213
ioctl_fiemap fs/ioctl.c:220 [inline]
do_vfs_ioctl+0x1c07/0x2e50 fs/ioctl.c:841
__do_sys_ioctl fs/ioctl.c:905 [inline]
__se_sys_ioctl+0x81/0x170 fs/ioctl.c:893
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
-> #0 (&ni->ni_lock/4){+.+.}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3134 [inline]
check_prevs_add kernel/locking/lockdep.c:3253 [inline]
validate_chain+0x18e0/0x5900 kernel/locking/lockdep.c:3869
__lock_acquire+0x1346/0x1fd0 kernel/locking/lockdep.c:5137
lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754
__mutex_lock_common kernel/locking/mutex.c:608 [inline]
__mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752
ni_lock fs/ntfs3/ntfs_fs.h:1107 [inline]
attr_data_get_block+0x463/0x2ff0 fs/ntfs3/attrib.c:917
ntfs_file_mmap+0x50e/0x860 fs/ntfs3/file.c:294
call_mmap include/linux/fs.h:2107 [inline]
mmap_region+0xe8f/0x2090 mm/mmap.c:2886
do_mmap+0x8ad/0xfa0 mm/mmap.c:1397
vm_mmap_pgoff+0x1dd/0x3d0 mm/util.c:573
ksys_mmap_pgoff+0x4f1/0x720 mm/mmap.c:1443
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
other info that might help us debug this:
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&mm->mmap_lock);
lock(&ni->ni_lock/4);
lock(&mm->mmap_lock);
lock(&ni->ni_lock/4);
*** DEADLOCK ***
1 lock held by syz-executor.0/5470:
#0: ffff88807e94ea18 (&mm->mmap_lock){++++}-{3:3}, at: mmap_write_lock_killable include/linux/mmap_lock.h:122 [inline]
#0: ffff88807e94ea18 (&mm->mmap_lock){++++}-{3:3}, at: vm_mmap_pgoff+0x17c/0x3d0 mm/util.c:571
stack backtrace:
CPU: 0 PID: 5470 Comm: syz-executor.0 Not tainted 6.10.0-rc1-syzkaller-00035-gd57431c6f511 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 06/27/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x241/0x360 lib/dump_stack.c:114
check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2187
check_prev_add kernel/locking/lockdep.c:3134 [inline]
check_prevs_add kernel/locking/lockdep.c:3253 [inline]
validate_chain+0x18e0/0x5900 kernel/locking/lockdep.c:3869
__lock_acquire+0x1346/0x1fd0 kernel/locking/lockdep.c:5137
lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754
__mutex_lock_common kernel/locking/mutex.c:608 [inline]
__mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752
ni_lock fs/ntfs3/ntfs_fs.h:1107 [inline]
attr_data_get_block+0x463/0x2ff0 fs/ntfs3/attrib.c:917
ntfs_file_mmap+0x50e/0x860 fs/ntfs3/file.c:294
call_mmap include/linux/fs.h:2107 [inline]
mmap_region+0xe8f/0x2090 mm/mmap.c:2886
do_mmap+0x8ad/0xfa0 mm/mmap.c:1397
vm_mmap_pgoff+0x1dd/0x3d0 mm/util.c:573
ksys_mmap_pgoff+0x4f1/0x720 mm/mmap.c:1443
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f2f0687dea9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f2f075d70c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000009
RAX: ffffffffffffffda RBX: 00007f2f069abf80 RCX: 00007f2f0687dea9
RDX: 00000000027fffff RSI: 0000000000600000 RDI: 0000000020000000
RBP: 00007f2f068ca4a4 R08: 0000000000000004 R09: 0000000000000000
R10: 0000000004002011 R11: 0000000000000246 R12: 0000000000000000
R13: 000000000000000b R14: 00007f2f069abf80 R15: 00007ffd044d5088
</TASK>
Tested on:
commit: d57431c6 fs/ntfs3: Do copy_to_user out of run_lock
git tree: https://github.com/Paragon-Software-Group/linux-ntfs3.git
console output: https://syzkaller.appspot.com/x/log.txt?x=17849349980000
kernel config: https://syzkaller.appspot.com/x/.config?x=47d282ddffae809f
dashboard link: https://syzkaller.appspot.com/bug?extid=c300ab283ba3bc072439
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
Note: no patches were applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [syzbot] [ntfs3?] possible deadlock in ni_fiemap
[not found] <9dfe6ab434654f52a317b26f799d5ddb@paragon-software.com>
@ 2024-08-23 17:56 ` syzbot
0 siblings, 0 replies; 3+ messages in thread
From: syzbot @ 2024-08-23 17:56 UTC (permalink / raw)
To: almaz.alexandrovich, linux-kernel, syzkaller-bugs
Hello,
syzbot has tested the proposed patch but the reproducer is still triggering an issue:
possible deadlock in attr_data_get_block
loop0: detected capacity change from 0 to 4096
======================================================
WARNING: possible circular locking dependency detected
6.11.0-rc1-syzkaller-00016-g7529036a025a #0 Not tainted
------------------------------------------------------
syz-executor.0/5510 is trying to acquire lock:
ffff88806c041e60 (&ni->ni_lock/5){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1111 [inline]
ffff88806c041e60 (&ni->ni_lock/5){+.+.}-{3:3}, at: attr_data_get_block+0x44b/0x2f20 fs/ntfs3/attrib.c:917
but task is already holding lock:
ffff888023f4d718 (&mm->mmap_lock){++++}-{3:3}, at: mmap_write_lock_killable include/linux/mmap_lock.h:122 [inline]
ffff888023f4d718 (&mm->mmap_lock){++++}-{3:3}, at: vm_mmap_pgoff+0x17c/0x3d0 mm/util.c:586
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #1 (&mm->mmap_lock){++++}-{3:3}:
lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5759
__might_fault+0xc6/0x120 mm/memory.c:6388
_inline_copy_to_user include/linux/uaccess.h:176 [inline]
_copy_to_user+0x2a/0xb0 lib/usercopy.c:26
copy_to_user include/linux/uaccess.h:209 [inline]
fiemap_fill_next_extent+0x235/0x410 fs/ioctl.c:145
ni_fiemap+0x4f5/0x1910 fs/ntfs3/frecord.c:1993
ntfs_fiemap+0x132/0x180 fs/ntfs3/file.c:1346
ioctl_fiemap fs/ioctl.c:220 [inline]
do_vfs_ioctl+0x1c07/0x2e50 fs/ioctl.c:841
__do_sys_ioctl fs/ioctl.c:905 [inline]
__se_sys_ioctl+0x81/0x170 fs/ioctl.c:893
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
-> #0 (&ni->ni_lock/5){+.+.}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3133 [inline]
check_prevs_add kernel/locking/lockdep.c:3252 [inline]
validate_chain+0x18e0/0x5900 kernel/locking/lockdep.c:3868
__lock_acquire+0x137a/0x2040 kernel/locking/lockdep.c:5142
lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5759
__mutex_lock_common kernel/locking/mutex.c:608 [inline]
__mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752
ni_lock fs/ntfs3/ntfs_fs.h:1111 [inline]
attr_data_get_block+0x44b/0x2f20 fs/ntfs3/attrib.c:917
ntfs_file_mmap+0x4f5/0x850 fs/ntfs3/file.c:370
call_mmap include/linux/fs.h:2129 [inline]
mmap_region+0xe8f/0x2090 mm/mmap.c:2957
do_mmap+0x8f9/0x1010 mm/mmap.c:1468
vm_mmap_pgoff+0x1dd/0x3d0 mm/util.c:588
ksys_mmap_pgoff+0x4f1/0x720 mm/mmap.c:1514
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
other info that might help us debug this:
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&mm->mmap_lock);
lock(&ni->ni_lock/5);
lock(&mm->mmap_lock);
lock(&ni->ni_lock/5);
*** DEADLOCK ***
1 lock held by syz-executor.0/5510:
#0: ffff888023f4d718 (&mm->mmap_lock){++++}-{3:3}, at: mmap_write_lock_killable include/linux/mmap_lock.h:122 [inline]
#0: ffff888023f4d718 (&mm->mmap_lock){++++}-{3:3}, at: vm_mmap_pgoff+0x17c/0x3d0 mm/util.c:586
stack backtrace:
CPU: 1 UID: 0 PID: 5510 Comm: syz-executor.0 Not tainted 6.11.0-rc1-syzkaller-00016-g7529036a025a #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:93 [inline]
dump_stack_lvl+0x241/0x360 lib/dump_stack.c:119
check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2186
check_prev_add kernel/locking/lockdep.c:3133 [inline]
check_prevs_add kernel/locking/lockdep.c:3252 [inline]
validate_chain+0x18e0/0x5900 kernel/locking/lockdep.c:3868
__lock_acquire+0x137a/0x2040 kernel/locking/lockdep.c:5142
lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5759
__mutex_lock_common kernel/locking/mutex.c:608 [inline]
__mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752
ni_lock fs/ntfs3/ntfs_fs.h:1111 [inline]
attr_data_get_block+0x44b/0x2f20 fs/ntfs3/attrib.c:917
ntfs_file_mmap+0x4f5/0x850 fs/ntfs3/file.c:370
call_mmap include/linux/fs.h:2129 [inline]
mmap_region+0xe8f/0x2090 mm/mmap.c:2957
do_mmap+0x8f9/0x1010 mm/mmap.c:1468
vm_mmap_pgoff+0x1dd/0x3d0 mm/util.c:588
ksys_mmap_pgoff+0x4f1/0x720 mm/mmap.c:1514
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fcf3647dea9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fcf372630c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000009
RAX: ffffffffffffffda RBX: 00007fcf365abf80 RCX: 00007fcf3647dea9
RDX: 00000000027fffff RSI: 0000000000600000 RDI: 0000000020000000
RBP: 00007fcf364ca4a4 R08: 0000000000000004 R09: 0000000000000000
R10: 0000000004002011 R11: 0000000000000246 R12: 0000000000000000
R13: 000000000000000b R14: 00007fcf365abf80 R15: 00007ffdefad79e8
</TASK>
Tested on:
commit: 7529036a fs/ntfs3: Rename ntfs3_setattr into ntfs_seta..
git tree: https://github.com/Paragon-Software-Group/linux-ntfs3.git master
console output: https://syzkaller.appspot.com/x/log.txt?x=17478b91980000
kernel config: https://syzkaller.appspot.com/x/.config?x=500271480f7d801c
dashboard link: https://syzkaller.appspot.com/bug?extid=c300ab283ba3bc072439
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
Note: no patches were applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [syzbot] [ntfs3?] possible deadlock in ni_fiemap
2022-10-18 5:47 [syzbot] " syzbot
@ 2024-11-18 6:58 ` syzbot
0 siblings, 0 replies; 3+ messages in thread
From: syzbot @ 2024-11-18 6:58 UTC (permalink / raw)
To: almaz.alexandrovich, axboe, brauner, jack, linux-kernel, ntfs3,
syzkaller-bugs
syzbot suspects this issue was fixed by commit:
commit 6f861765464f43a71462d52026fbddfc858239a5
Author: Jan Kara <jack@suse.cz>
Date: Wed Nov 1 17:43:10 2023 +0000
fs: Block writes to mounted block devices
bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=120c0ac0580000
start commit: d537ae43f8a1 Merge tag 'gpio-fixes-for-v6.6-rc7' of git://..
git tree: upstream
kernel config: https://syzkaller.appspot.com/x/.config?x=849fe52ba7c6d78a
dashboard link: https://syzkaller.appspot.com/bug?extid=c300ab283ba3bc072439
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1056076d680000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17093269680000
If the result looks correct, please mark the issue as fixed by replying with:
#syz fix: fs: Block writes to mounted block devices
For information about bisection process see: https://goo.gl/tpsmEJ#bisection
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-11-18 6:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <9dfe6ab434654f52a317b26f799d5ddb@paragon-software.com>
2024-08-23 17:56 ` [syzbot] [ntfs3?] possible deadlock in ni_fiemap syzbot
[not found] <023c2035-91d2-4e0d-a2ce-7aacd763ac0d@paragon-software.com>
2024-07-20 8:38 ` syzbot
2022-10-18 5:47 [syzbot] " syzbot
2024-11-18 6:58 ` [syzbot] [ntfs3?] " syzbot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.