* general protection fault in utf8_casefold @ 2020-10-08 14:59 syzbot 2020-10-08 19:15 ` Eric Biggers 2020-10-09 2:40 ` syzbot 0 siblings, 2 replies; 9+ messages in thread From: syzbot @ 2020-10-08 14:59 UTC (permalink / raw) To: krisman, linux-fsdevel, linux-kernel, syzkaller-bugs Hello, syzbot found the following issue on: HEAD commit: c85fb28b Merge tag 'arm64-fixes' of git://git.kernel.org/p.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1785ccd0500000 kernel config: https://syzkaller.appspot.com/x/.config?x=de7f697da23057c7 dashboard link: https://syzkaller.appspot.com/bug?extid=05139c4039d0679e19ff compiler: clang version 10.0.0 (https://github.com/llvm/llvm-project/ c2443155a0fb245c8f17f2c1c72b6ea391e86e81) syz repro: https://syzkaller.appspot.com/x/repro.syz?x=12316e00500000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=16e80420500000 IMPORTANT: if you fix the issue, please add the following tag to the commit: Reported-by: syzbot+05139c4039d0679e19ff@syzkaller.appspotmail.com F2FS-fs (loop0): invalid crc_offset: 0 F2FS-fs (loop0): f2fs_check_nid_range: out-of-range nid=1, run fsck to fix. F2FS-fs (loop0): f2fs_check_nid_range: out-of-range nid=2, run fsck to fix. F2FS-fs (loop0): Try to recover 2th superblock, ret: 0 F2FS-fs (loop0): Mounted with checkpoint version = 27d57943 general protection fault, probably for non-canonical address 0xdffffc0000000001: 0000 [#1] PREEMPT SMP KASAN KASAN: null-ptr-deref in range [0x0000000000000008-0x000000000000000f] CPU: 0 PID: 6860 Comm: syz-executor835 Not tainted 5.9.0-rc8-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 RIP: 0010:utf8_casefold+0x43/0x1b0 fs/unicode/utf8-core.c:107 Code: 89 fd 65 48 8b 04 25 28 00 00 00 48 89 44 24 48 49 be 00 00 00 00 00 fc ff df e8 d8 c5 19 ff 48 83 c5 08 48 89 e8 48 c1 e8 03 <42> 8a 04 30 84 c0 0f 85 21 01 00 00 8b 7d 00 e8 89 f8 ff ff 49 89 RSP: 0018:ffffc900072e7c48 EFLAGS: 00010202 RAX: 0000000000000001 RBX: ffff888087470e10 RCX: ffff8880a6b26440 RDX: 0000000000000000 RSI: ffff888087470e10 RDI: 0000000000000000 RBP: 0000000000000008 R08: ffffffff834b74e9 R09: fffffbfff16c82b1 R10: fffffbfff16c82b1 R11: 0000000000000000 R12: ffffc900072e7dc8 R13: 1ffff92000e5cfb3 R14: dffffc0000000000 R15: 00000000000000ff FS: 00007f59a4052700(0000) GS:ffff8880ae800000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007f360e3b4000 CR3: 00000000973fb000 CR4: 00000000001506f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: f2fs_init_casefolded_name fs/f2fs/dir.c:85 [inline] __f2fs_setup_filename fs/f2fs/dir.c:118 [inline] f2fs_prepare_lookup+0x3bf/0x640 fs/f2fs/dir.c:163 f2fs_lookup+0x10d/0x920 fs/f2fs/namei.c:494 __lookup_hash+0x115/0x240 fs/namei.c:1445 filename_create+0x14b/0x630 fs/namei.c:3467 user_path_create fs/namei.c:3524 [inline] do_mkdirat+0x56/0x310 fs/namei.c:3664 do_syscall_64+0x31/0x70 arch/x86/entry/common.c:46 entry_SYSCALL_64_after_hwframe+0x44/0xa9 RIP: 0033:0x449367 Code: ff ff ff ff c3 66 0f 1f 44 00 00 48 c7 c0 d0 ff ff ff 64 c7 00 16 00 00 00 b8 ff ff ff ff c3 0f 1f 40 00 b8 53 00 00 00 0f 05 <48> 3d 01 f0 ff ff 0f 83 8d e0 fb ff c3 66 2e 0f 1f 84 00 00 00 00 RSP: 002b:00007f59a4051bb8 EFLAGS: 00000203 ORIG_RAX: 0000000000000053 RAX: ffffffffffffffda RBX: 00000000ffffffff RCX: 0000000000449367 RDX: 0000000000000000 RSI: 00000000000001ff RDI: 0000000020001940 RBP: 00007f59a40526d0 R08: 0000000000000002 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000203 R12: 00000000ffffffff R13: 0000000000000000 R14: 0000000000000000 R15: 00007f59a4051c50 Modules linked in: ---[ end trace cf7b61b9a89941d1 ]--- RIP: 0010:utf8_casefold+0x43/0x1b0 fs/unicode/utf8-core.c:107 Code: 89 fd 65 48 8b 04 25 28 00 00 00 48 89 44 24 48 49 be 00 00 00 00 00 fc ff df e8 d8 c5 19 ff 48 83 c5 08 48 89 e8 48 c1 e8 03 <42> 8a 04 30 84 c0 0f 85 21 01 00 00 8b 7d 00 e8 89 f8 ff ff 49 89 RSP: 0018:ffffc900072e7c48 EFLAGS: 00010202 RAX: 0000000000000001 RBX: ffff888087470e10 RCX: ffff8880a6b26440 RDX: 0000000000000000 RSI: ffff888087470e10 RDI: 0000000000000000 RBP: 0000000000000008 R08: ffffffff834b74e9 R09: fffffbfff16c82b1 R10: fffffbfff16c82b1 R11: 0000000000000000 R12: ffffc900072e7dc8 R13: 1ffff92000e5cfb3 R14: dffffc0000000000 R15: 00000000000000ff FS: 00007f59a4052700(0000) GS:ffff8880ae800000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007f360e3b4000 CR3: 00000000973fb000 CR4: 00000000001506f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 --- This report is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller@googlegroups.com. syzbot will keep track of this issue. See: https://goo.gl/tpsmEJ#status for how to communicate with syzbot. syzbot can test patches for this issue, for details see: https://goo.gl/tpsmEJ#testing-patches ^ permalink raw reply [flat|nested] 9+ messages in thread
* [f2fs-dev] [PATCH] f2fs: reject CASEFOLD inode flag without casefold feature 2020-10-08 14:59 general protection fault in utf8_casefold syzbot @ 2020-10-08 19:15 ` Eric Biggers 2020-10-09 2:40 ` syzbot 1 sibling, 0 replies; 9+ messages in thread From: Eric Biggers @ 2020-10-08 19:15 UTC (permalink / raw) To: Jaegeuk Kim, Chao Yu, linux-f2fs-devel Cc: Daniel Rosenberg, syzkaller-bugs, linux-kernel, linux-fsdevel, syzbot+05139c4039d0679e19ff, Gabriel Krisman Bertazi From: Eric Biggers <ebiggers@google.com> syzbot reported: general protection fault, probably for non-canonical address 0xdffffc0000000001: 0000 [#1] PREEMPT SMP KASAN KASAN: null-ptr-deref in range [0x0000000000000008-0x000000000000000f] CPU: 0 PID: 6860 Comm: syz-executor835 Not tainted 5.9.0-rc8-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 RIP: 0010:utf8_casefold+0x43/0x1b0 fs/unicode/utf8-core.c:107 [...] Call Trace: f2fs_init_casefolded_name fs/f2fs/dir.c:85 [inline] __f2fs_setup_filename fs/f2fs/dir.c:118 [inline] f2fs_prepare_lookup+0x3bf/0x640 fs/f2fs/dir.c:163 f2fs_lookup+0x10d/0x920 fs/f2fs/namei.c:494 __lookup_hash+0x115/0x240 fs/namei.c:1445 filename_create+0x14b/0x630 fs/namei.c:3467 user_path_create fs/namei.c:3524 [inline] do_mkdirat+0x56/0x310 fs/namei.c:3664 do_syscall_64+0x31/0x70 arch/x86/entry/common.c:46 entry_SYSCALL_64_after_hwframe+0x44/0xa9 [...] The problem is that an inode has F2FS_CASEFOLD_FL set, but the filesystem doesn't have the casefold feature flag set, and therefore super_block::s_encoding is NULL. Fix this by making sanity_check_inode() reject inodes that have F2FS_CASEFOLD_FL when the filesystem doesn't have the casefold feature. Reported-by: syzbot+05139c4039d0679e19ff@syzkaller.appspotmail.com Fixes: 2c2eb7a300cd ("f2fs: Support case-insensitive file name lookups") Signed-off-by: Eric Biggers <ebiggers@google.com> --- fs/f2fs/inode.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c index 2ed935c13aed..d5664bc7d6c6 100644 --- a/fs/f2fs/inode.c +++ b/fs/f2fs/inode.c @@ -287,6 +287,13 @@ static bool sanity_check_inode(struct inode *inode, struct page *node_page) return false; } + if ((fi->i_flags & F2FS_CASEFOLD_FL) && !f2fs_sb_has_casefold(sbi)) { + set_sbi_flag(sbi, SBI_NEED_FSCK); + f2fs_warn(sbi, "%s: inode (ino=%lx) has casefold flag, but casefold feature is off", + __func__, inode->i_ino); + return false; + } + if (f2fs_has_extra_attr(inode) && f2fs_sb_has_compression(sbi) && fi->i_flags & F2FS_COMPR_FL && F2FS_FITS_IN_INODE(ri, fi->i_extra_isize, base-commit: db40330b0de9a9d9939178f48cd5fc5e3fab14de -- 2.28.0.1011.ga647a8990f-goog _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] f2fs: reject CASEFOLD inode flag without casefold feature @ 2020-10-08 19:15 ` Eric Biggers 0 siblings, 0 replies; 9+ messages in thread From: Eric Biggers @ 2020-10-08 19:15 UTC (permalink / raw) To: Jaegeuk Kim, Chao Yu, linux-f2fs-devel Cc: Daniel Rosenberg, Gabriel Krisman Bertazi, linux-kernel, linux-fsdevel, syzkaller-bugs, syzbot+05139c4039d0679e19ff From: Eric Biggers <ebiggers@google.com> syzbot reported: general protection fault, probably for non-canonical address 0xdffffc0000000001: 0000 [#1] PREEMPT SMP KASAN KASAN: null-ptr-deref in range [0x0000000000000008-0x000000000000000f] CPU: 0 PID: 6860 Comm: syz-executor835 Not tainted 5.9.0-rc8-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 RIP: 0010:utf8_casefold+0x43/0x1b0 fs/unicode/utf8-core.c:107 [...] Call Trace: f2fs_init_casefolded_name fs/f2fs/dir.c:85 [inline] __f2fs_setup_filename fs/f2fs/dir.c:118 [inline] f2fs_prepare_lookup+0x3bf/0x640 fs/f2fs/dir.c:163 f2fs_lookup+0x10d/0x920 fs/f2fs/namei.c:494 __lookup_hash+0x115/0x240 fs/namei.c:1445 filename_create+0x14b/0x630 fs/namei.c:3467 user_path_create fs/namei.c:3524 [inline] do_mkdirat+0x56/0x310 fs/namei.c:3664 do_syscall_64+0x31/0x70 arch/x86/entry/common.c:46 entry_SYSCALL_64_after_hwframe+0x44/0xa9 [...] The problem is that an inode has F2FS_CASEFOLD_FL set, but the filesystem doesn't have the casefold feature flag set, and therefore super_block::s_encoding is NULL. Fix this by making sanity_check_inode() reject inodes that have F2FS_CASEFOLD_FL when the filesystem doesn't have the casefold feature. Reported-by: syzbot+05139c4039d0679e19ff@syzkaller.appspotmail.com Fixes: 2c2eb7a300cd ("f2fs: Support case-insensitive file name lookups") Signed-off-by: Eric Biggers <ebiggers@google.com> --- fs/f2fs/inode.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c index 2ed935c13aed..d5664bc7d6c6 100644 --- a/fs/f2fs/inode.c +++ b/fs/f2fs/inode.c @@ -287,6 +287,13 @@ static bool sanity_check_inode(struct inode *inode, struct page *node_page) return false; } + if ((fi->i_flags & F2FS_CASEFOLD_FL) && !f2fs_sb_has_casefold(sbi)) { + set_sbi_flag(sbi, SBI_NEED_FSCK); + f2fs_warn(sbi, "%s: inode (ino=%lx) has casefold flag, but casefold feature is off", + __func__, inode->i_ino); + return false; + } + if (f2fs_has_extra_attr(inode) && f2fs_sb_has_compression(sbi) && fi->i_flags & F2FS_COMPR_FL && F2FS_FITS_IN_INODE(ri, fi->i_extra_isize, base-commit: db40330b0de9a9d9939178f48cd5fc5e3fab14de -- 2.28.0.1011.ga647a8990f-goog ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: reject CASEFOLD inode flag without casefold feature 2020-10-08 19:15 ` Eric Biggers @ 2020-10-08 19:26 ` Gabriel Krisman Bertazi -1 siblings, 0 replies; 9+ messages in thread From: Gabriel Krisman Bertazi @ 2020-10-08 19:26 UTC (permalink / raw) To: Eric Biggers Cc: Daniel Rosenberg, syzkaller-bugs, linux-kernel, linux-f2fs-devel, syzbot+05139c4039d0679e19ff, linux-fsdevel, Jaegeuk Kim Eric Biggers <ebiggers@kernel.org> writes: > From: Eric Biggers <ebiggers@google.com> > > syzbot reported: > > general protection fault, probably for non-canonical address 0xdffffc0000000001: 0000 [#1] PREEMPT SMP KASAN > KASAN: null-ptr-deref in range [0x0000000000000008-0x000000000000000f] > CPU: 0 PID: 6860 Comm: syz-executor835 Not tainted 5.9.0-rc8-syzkaller #0 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 > RIP: 0010:utf8_casefold+0x43/0x1b0 fs/unicode/utf8-core.c:107 > [...] > Call Trace: > f2fs_init_casefolded_name fs/f2fs/dir.c:85 [inline] > __f2fs_setup_filename fs/f2fs/dir.c:118 [inline] > f2fs_prepare_lookup+0x3bf/0x640 fs/f2fs/dir.c:163 > f2fs_lookup+0x10d/0x920 fs/f2fs/namei.c:494 > __lookup_hash+0x115/0x240 fs/namei.c:1445 > filename_create+0x14b/0x630 fs/namei.c:3467 > user_path_create fs/namei.c:3524 [inline] > do_mkdirat+0x56/0x310 fs/namei.c:3664 > do_syscall_64+0x31/0x70 arch/x86/entry/common.c:46 > entry_SYSCALL_64_after_hwframe+0x44/0xa9 > [...] > > The problem is that an inode has F2FS_CASEFOLD_FL set, but the > filesystem doesn't have the casefold feature flag set, and therefore > super_block::s_encoding is NULL. > > Fix this by making sanity_check_inode() reject inodes that have > F2FS_CASEFOLD_FL when the filesystem doesn't have the casefold feature. > > Reported-by: syzbot+05139c4039d0679e19ff@syzkaller.appspotmail.com > Fixes: 2c2eb7a300cd ("f2fs: Support case-insensitive file name lookups") > Signed-off-by: Eric Biggers <ebiggers@google.com> Looks good. For the record, this is fixed on ext4 already. Reviewed-by: Gabriel Krisman Bertazi <krisman@collabora.com> -- Gabriel Krisman Bertazi _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] f2fs: reject CASEFOLD inode flag without casefold feature @ 2020-10-08 19:26 ` Gabriel Krisman Bertazi 0 siblings, 0 replies; 9+ messages in thread From: Gabriel Krisman Bertazi @ 2020-10-08 19:26 UTC (permalink / raw) To: Eric Biggers Cc: Jaegeuk Kim, Chao Yu, linux-f2fs-devel, Daniel Rosenberg, linux-kernel, linux-fsdevel, syzkaller-bugs, syzbot+05139c4039d0679e19ff Eric Biggers <ebiggers@kernel.org> writes: > From: Eric Biggers <ebiggers@google.com> > > syzbot reported: > > general protection fault, probably for non-canonical address 0xdffffc0000000001: 0000 [#1] PREEMPT SMP KASAN > KASAN: null-ptr-deref in range [0x0000000000000008-0x000000000000000f] > CPU: 0 PID: 6860 Comm: syz-executor835 Not tainted 5.9.0-rc8-syzkaller #0 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 > RIP: 0010:utf8_casefold+0x43/0x1b0 fs/unicode/utf8-core.c:107 > [...] > Call Trace: > f2fs_init_casefolded_name fs/f2fs/dir.c:85 [inline] > __f2fs_setup_filename fs/f2fs/dir.c:118 [inline] > f2fs_prepare_lookup+0x3bf/0x640 fs/f2fs/dir.c:163 > f2fs_lookup+0x10d/0x920 fs/f2fs/namei.c:494 > __lookup_hash+0x115/0x240 fs/namei.c:1445 > filename_create+0x14b/0x630 fs/namei.c:3467 > user_path_create fs/namei.c:3524 [inline] > do_mkdirat+0x56/0x310 fs/namei.c:3664 > do_syscall_64+0x31/0x70 arch/x86/entry/common.c:46 > entry_SYSCALL_64_after_hwframe+0x44/0xa9 > [...] > > The problem is that an inode has F2FS_CASEFOLD_FL set, but the > filesystem doesn't have the casefold feature flag set, and therefore > super_block::s_encoding is NULL. > > Fix this by making sanity_check_inode() reject inodes that have > F2FS_CASEFOLD_FL when the filesystem doesn't have the casefold feature. > > Reported-by: syzbot+05139c4039d0679e19ff@syzkaller.appspotmail.com > Fixes: 2c2eb7a300cd ("f2fs: Support case-insensitive file name lookups") > Signed-off-by: Eric Biggers <ebiggers@google.com> Looks good. For the record, this is fixed on ext4 already. Reviewed-by: Gabriel Krisman Bertazi <krisman@collabora.com> -- Gabriel Krisman Bertazi ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: reject CASEFOLD inode flag without casefold feature 2020-10-08 19:15 ` Eric Biggers @ 2020-10-09 1:30 ` Chao Yu -1 siblings, 0 replies; 9+ messages in thread From: Chao Yu @ 2020-10-09 1:30 UTC (permalink / raw) To: Eric Biggers, Jaegeuk Kim, Chao Yu, linux-f2fs-devel Cc: Daniel Rosenberg, syzkaller-bugs, linux-kernel, linux-fsdevel, syzbot+05139c4039d0679e19ff, Gabriel Krisman Bertazi On 2020/10/9 3:15, Eric Biggers wrote: > From: Eric Biggers <ebiggers@google.com> > > syzbot reported: > > general protection fault, probably for non-canonical address 0xdffffc0000000001: 0000 [#1] PREEMPT SMP KASAN > KASAN: null-ptr-deref in range [0x0000000000000008-0x000000000000000f] > CPU: 0 PID: 6860 Comm: syz-executor835 Not tainted 5.9.0-rc8-syzkaller #0 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 > RIP: 0010:utf8_casefold+0x43/0x1b0 fs/unicode/utf8-core.c:107 > [...] > Call Trace: > f2fs_init_casefolded_name fs/f2fs/dir.c:85 [inline] > __f2fs_setup_filename fs/f2fs/dir.c:118 [inline] > f2fs_prepare_lookup+0x3bf/0x640 fs/f2fs/dir.c:163 > f2fs_lookup+0x10d/0x920 fs/f2fs/namei.c:494 > __lookup_hash+0x115/0x240 fs/namei.c:1445 > filename_create+0x14b/0x630 fs/namei.c:3467 > user_path_create fs/namei.c:3524 [inline] > do_mkdirat+0x56/0x310 fs/namei.c:3664 > do_syscall_64+0x31/0x70 arch/x86/entry/common.c:46 > entry_SYSCALL_64_after_hwframe+0x44/0xa9 > [...] > > The problem is that an inode has F2FS_CASEFOLD_FL set, but the > filesystem doesn't have the casefold feature flag set, and therefore > super_block::s_encoding is NULL. > > Fix this by making sanity_check_inode() reject inodes that have > F2FS_CASEFOLD_FL when the filesystem doesn't have the casefold feature. > > Reported-by: syzbot+05139c4039d0679e19ff@syzkaller.appspotmail.com > Fixes: 2c2eb7a300cd ("f2fs: Support case-insensitive file name lookups") > Signed-off-by: Eric Biggers <ebiggers@google.com> Reviewed-by: Chao Yu <yuchao0@huawei.com> Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] f2fs: reject CASEFOLD inode flag without casefold feature @ 2020-10-09 1:30 ` Chao Yu 0 siblings, 0 replies; 9+ messages in thread From: Chao Yu @ 2020-10-09 1:30 UTC (permalink / raw) To: Eric Biggers, Jaegeuk Kim, Chao Yu, linux-f2fs-devel Cc: Daniel Rosenberg, Gabriel Krisman Bertazi, linux-kernel, linux-fsdevel, syzkaller-bugs, syzbot+05139c4039d0679e19ff On 2020/10/9 3:15, Eric Biggers wrote: > From: Eric Biggers <ebiggers@google.com> > > syzbot reported: > > general protection fault, probably for non-canonical address 0xdffffc0000000001: 0000 [#1] PREEMPT SMP KASAN > KASAN: null-ptr-deref in range [0x0000000000000008-0x000000000000000f] > CPU: 0 PID: 6860 Comm: syz-executor835 Not tainted 5.9.0-rc8-syzkaller #0 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 > RIP: 0010:utf8_casefold+0x43/0x1b0 fs/unicode/utf8-core.c:107 > [...] > Call Trace: > f2fs_init_casefolded_name fs/f2fs/dir.c:85 [inline] > __f2fs_setup_filename fs/f2fs/dir.c:118 [inline] > f2fs_prepare_lookup+0x3bf/0x640 fs/f2fs/dir.c:163 > f2fs_lookup+0x10d/0x920 fs/f2fs/namei.c:494 > __lookup_hash+0x115/0x240 fs/namei.c:1445 > filename_create+0x14b/0x630 fs/namei.c:3467 > user_path_create fs/namei.c:3524 [inline] > do_mkdirat+0x56/0x310 fs/namei.c:3664 > do_syscall_64+0x31/0x70 arch/x86/entry/common.c:46 > entry_SYSCALL_64_after_hwframe+0x44/0xa9 > [...] > > The problem is that an inode has F2FS_CASEFOLD_FL set, but the > filesystem doesn't have the casefold feature flag set, and therefore > super_block::s_encoding is NULL. > > Fix this by making sanity_check_inode() reject inodes that have > F2FS_CASEFOLD_FL when the filesystem doesn't have the casefold feature. > > Reported-by: syzbot+05139c4039d0679e19ff@syzkaller.appspotmail.com > Fixes: 2c2eb7a300cd ("f2fs: Support case-insensitive file name lookups") > Signed-off-by: Eric Biggers <ebiggers@google.com> Reviewed-by: Chao Yu <yuchao0@huawei.com> Thanks, ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [f2fs-dev] general protection fault in utf8_casefold 2020-10-08 14:59 general protection fault in utf8_casefold syzbot @ 2020-10-09 2:40 ` syzbot 2020-10-09 2:40 ` syzbot 1 sibling, 0 replies; 9+ messages in thread From: syzbot @ 2020-10-09 2:40 UTC (permalink / raw) To: Su.Chung, alexander.deucher, chao, drosen, ebiggers, jaegeuk, jun.lei, krisman, linux-f2fs-devel, linux-fsdevel, linux-kernel, su.chung, sunpeng.li, syzkaller-bugs, viro, yuchao0 syzbot has bisected this issue to: commit 91db9311945f01901ddb9813ce11364de214a156 Author: Su Sung Chung <Su.Chung@amd.com> Date: Mon Jul 8 15:31:39 2019 +0000 drm/amd/display: refactor gpio to allocate hw_container in constructor bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1012ee8b900000 start commit: c85fb28b Merge tag 'arm64-fixes' of git://git.kernel.org/p.. git tree: upstream final oops: https://syzkaller.appspot.com/x/report.txt?x=1212ee8b900000 console output: https://syzkaller.appspot.com/x/log.txt?x=1412ee8b900000 kernel config: https://syzkaller.appspot.com/x/.config?x=de7f697da23057c7 dashboard link: https://syzkaller.appspot.com/bug?extid=05139c4039d0679e19ff syz repro: https://syzkaller.appspot.com/x/repro.syz?x=12316e00500000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=16e80420500000 Reported-by: syzbot+05139c4039d0679e19ff@syzkaller.appspotmail.com Fixes: 91db9311945f ("drm/amd/display: refactor gpio to allocate hw_container in constructor") For information about bisection process see: https://goo.gl/tpsmEJ#bisection _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: general protection fault in utf8_casefold @ 2020-10-09 2:40 ` syzbot 0 siblings, 0 replies; 9+ messages in thread From: syzbot @ 2020-10-09 2:40 UTC (permalink / raw) To: Su.Chung, alexander.deucher, chao, drosen, ebiggers, jaegeuk, jun.lei, krisman, linux-f2fs-devel, linux-fsdevel, linux-kernel, su.chung, sunpeng.li, syzkaller-bugs, viro, yuchao0 syzbot has bisected this issue to: commit 91db9311945f01901ddb9813ce11364de214a156 Author: Su Sung Chung <Su.Chung@amd.com> Date: Mon Jul 8 15:31:39 2019 +0000 drm/amd/display: refactor gpio to allocate hw_container in constructor bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1012ee8b900000 start commit: c85fb28b Merge tag 'arm64-fixes' of git://git.kernel.org/p.. git tree: upstream final oops: https://syzkaller.appspot.com/x/report.txt?x=1212ee8b900000 console output: https://syzkaller.appspot.com/x/log.txt?x=1412ee8b900000 kernel config: https://syzkaller.appspot.com/x/.config?x=de7f697da23057c7 dashboard link: https://syzkaller.appspot.com/bug?extid=05139c4039d0679e19ff syz repro: https://syzkaller.appspot.com/x/repro.syz?x=12316e00500000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=16e80420500000 Reported-by: syzbot+05139c4039d0679e19ff@syzkaller.appspotmail.com Fixes: 91db9311945f ("drm/amd/display: refactor gpio to allocate hw_container in constructor") For information about bisection process see: https://goo.gl/tpsmEJ#bisection ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-10-09 2:40 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-10-08 14:59 general protection fault in utf8_casefold syzbot 2020-10-08 19:15 ` [f2fs-dev] [PATCH] f2fs: reject CASEFOLD inode flag without casefold feature Eric Biggers 2020-10-08 19:15 ` Eric Biggers 2020-10-08 19:26 ` [f2fs-dev] " Gabriel Krisman Bertazi 2020-10-08 19:26 ` Gabriel Krisman Bertazi 2020-10-09 1:30 ` [f2fs-dev] " Chao Yu 2020-10-09 1:30 ` Chao Yu 2020-10-09 2:40 ` [f2fs-dev] general protection fault in utf8_casefold syzbot 2020-10-09 2:40 ` syzbot
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.