* [syzbot] [ntfs3?] KMSAN: uninit-value in ntfs_read_bh
@ 2024-09-01 20:28 syzbot
2024-09-04 15:47 ` syzbot
` (3 more replies)
0 siblings, 4 replies; 10+ messages in thread
From: syzbot @ 2024-09-01 20:28 UTC (permalink / raw)
To: almaz.alexandrovich, linux-kernel, ntfs3, syzkaller-bugs
Hello,
syzbot found the following issue on:
HEAD commit: 431c1646e1f8 Linux 6.11-rc6
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=137426eb980000
kernel config: https://syzkaller.appspot.com/x/.config?x=35c699864e165c51
dashboard link: https://syzkaller.appspot.com/bug?extid=7a2ba6b7b66340cff225
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
Unfortunately, I don't have any reproducer for this issue yet.
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/5ab3219cb5e8/disk-431c1646.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/82e6779c1851/vmlinux-431c1646.xz
kernel image: https://storage.googleapis.com/syzbot-assets/d5d4a104ce36/bzImage-431c1646.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+7a2ba6b7b66340cff225@syzkaller.appspotmail.com
=====================================================
BUG: KMSAN: uninit-value in ntfs_fix_post_read fs/ntfs3/fsntfs.c:180 [inline]
BUG: KMSAN: uninit-value in ntfs_read_bh+0x1eb/0xde0 fs/ntfs3/fsntfs.c:1317
ntfs_fix_post_read fs/ntfs3/fsntfs.c:180 [inline]
ntfs_read_bh+0x1eb/0xde0 fs/ntfs3/fsntfs.c:1317
indx_read+0x44e/0x17b0 fs/ntfs3/index.c:1067
indx_find+0xd12/0x1440 fs/ntfs3/index.c:1181
indx_update_dup+0x607/0xf80 fs/ntfs3/index.c:2666
ni_update_parent+0x12de/0x14b0 fs/ntfs3/frecord.c:3301
ni_write_inode+0x1cf4/0x1de0 fs/ntfs3/frecord.c:3392
ntfs3_write_inode+0x94/0xb0 fs/ntfs3/inode.c:1052
write_inode fs/fs-writeback.c:1497 [inline]
__writeback_single_inode+0x849/0x12c0 fs/fs-writeback.c:1716
writeback_sb_inodes+0xc95/0x1e00 fs/fs-writeback.c:1947
wb_writeback+0x4df/0xea0 fs/fs-writeback.c:2127
wb_do_writeback fs/fs-writeback.c:2274 [inline]
wb_workfn+0x40b/0x1940 fs/fs-writeback.c:2314
process_one_work kernel/workqueue.c:3231 [inline]
process_scheduled_works+0xae0/0x1c40 kernel/workqueue.c:3312
worker_thread+0xea7/0x14d0 kernel/workqueue.c:3389
kthread+0x3e2/0x540 kernel/kthread.c:389
ret_from_fork+0x6d/0x90 arch/x86/kernel/process.c:147
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244
Uninit was stored to memory at:
ntfs_read_run_nb+0x786/0x1070 fs/ntfs3/fsntfs.c:1252
ntfs_read_bh+0x64/0xde0 fs/ntfs3/fsntfs.c:1313
indx_read+0x44e/0x17b0 fs/ntfs3/index.c:1067
indx_find+0xd12/0x1440 fs/ntfs3/index.c:1181
indx_update_dup+0x607/0xf80 fs/ntfs3/index.c:2666
ni_update_parent+0x12de/0x14b0 fs/ntfs3/frecord.c:3301
ni_write_inode+0x1cf4/0x1de0 fs/ntfs3/frecord.c:3392
ntfs3_write_inode+0x94/0xb0 fs/ntfs3/inode.c:1052
write_inode fs/fs-writeback.c:1497 [inline]
__writeback_single_inode+0x849/0x12c0 fs/fs-writeback.c:1716
writeback_sb_inodes+0xc95/0x1e00 fs/fs-writeback.c:1947
wb_writeback+0x4df/0xea0 fs/fs-writeback.c:2127
wb_do_writeback fs/fs-writeback.c:2274 [inline]
wb_workfn+0x40b/0x1940 fs/fs-writeback.c:2314
process_one_work kernel/workqueue.c:3231 [inline]
process_scheduled_works+0xae0/0x1c40 kernel/workqueue.c:3312
worker_thread+0xea7/0x14d0 kernel/workqueue.c:3389
kthread+0x3e2/0x540 kernel/kthread.c:389
ret_from_fork+0x6d/0x90 arch/x86/kernel/process.c:147
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244
Uninit was created at:
__alloc_pages_noprof+0x9d6/0xe70 mm/page_alloc.c:4718
alloc_pages_mpol_noprof+0x299/0x990 mm/mempolicy.c:2263
alloc_pages_noprof mm/mempolicy.c:2343 [inline]
folio_alloc_noprof+0x1db/0x310 mm/mempolicy.c:2350
filemap_alloc_folio_noprof+0xa6/0x440 mm/filemap.c:1008
__filemap_get_folio+0xa05/0x14b0 mm/filemap.c:1950
grow_dev_folio fs/buffer.c:1047 [inline]
grow_buffers fs/buffer.c:1113 [inline]
__getblk_slow fs/buffer.c:1139 [inline]
bdev_getblk+0x2c9/0xab0 fs/buffer.c:1441
__getblk include/linux/buffer_head.h:381 [inline]
sb_getblk include/linux/buffer_head.h:387 [inline]
ntfs_get_bh+0x605/0x1190 fs/ntfs3/fsntfs.c:1365
indx_new+0x1bc/0x780 fs/ntfs3/index.c:955
indx_insert_into_root+0x2fd1/0x37d0 fs/ntfs3/index.c:1723
indx_insert_entry+0xe1d/0xee0 fs/ntfs3/index.c:1982
ntfs_create_inode+0x4391/0x4df0 fs/ntfs3/inode.c:1689
ntfs_mkdir+0x56/0x70 fs/ntfs3/namei.c:207
vfs_mkdir+0x4a0/0x780 fs/namei.c:4210
do_mkdirat+0x529/0x810 fs/namei.c:4233
__do_sys_mkdirat fs/namei.c:4248 [inline]
__se_sys_mkdirat fs/namei.c:4246 [inline]
__x64_sys_mkdirat+0xc6/0x120 fs/namei.c:4246
x64_sys_call+0x3a81/0x3ba0 arch/x86/include/generated/asm/syscalls_64.h:259
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xcd/0x1e0 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
CPU: 1 UID: 0 PID: 2918 Comm: kworker/u8:9 Not tainted 6.11.0-rc6-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024
Workqueue: writeback wb_workfn (flush-7:4)
=====================================================
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title
If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)
If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report
If you want to undo deduplication, reply with:
#syz undup
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [syzbot] possible fix (linux-ntfs3)
2024-08-16 13:07 [syzbot] [ntfs3?] kernel panic: stack is corrupted in vprintk_emit syzbot
@ 2024-09-02 12:27 ` syzbot
2024-09-10 7:08 ` syzbot
1 sibling, 0 replies; 10+ messages in thread
From: syzbot @ 2024-09-02 12:27 UTC (permalink / raw)
To: linux-kernel, syzkaller-bugs
For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com.
***
Subject: possible fix (linux-ntfs3)
Author: almaz.alexandrovich@paragon-software.com
#syz test: https://github.com/Paragon-Software-Group/linux-ntfs3.git master
diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
index 128d49512f5d..c08bbacc0030 100644
--- a/fs/ntfs3/super.c
+++ b/fs/ntfs3/super.c
@@ -125,8 +125,9 @@ void ntfs_inode_printk(struct inode *inode, const
char *fmt, ...)
if (de) {
spin_lock(&de->d_lock);
- snprintf(name, sizeof(s_name_buf), " \"%s\"",
- de->d_name.name);
+ if (snprintf(name, sizeof(s_name_buf), " \"%s\"",
+ de->d_name.name) >= sizeof(s_name_buf))
+ name[sizeof(s_name_buf) - 1] = 0;
spin_unlock(&de->d_lock);
} else {
name[0] = 0;
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [syzbot] possible fix (linux-ntfs3)
2024-07-13 6:10 [syzbot] [ntfs3?] general protection fault in run_is_mapped_full syzbot
@ 2024-09-02 13:00 ` syzbot
0 siblings, 0 replies; 10+ messages in thread
From: syzbot @ 2024-09-02 13:00 UTC (permalink / raw)
To: linux-kernel, syzkaller-bugs
For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com.
***
Subject: possible fix (linux-ntfs3)
Author: almaz.alexandrovich@paragon-software.com
#syz test: https://github.com/Paragon-Software-Group/linux-ntfs3.git master
diff --git a/fs/ntfs3/inode.c b/fs/ntfs3/inode.c
index 1963a8928360..ab2abd323859 100644
--- a/fs/ntfs3/inode.c
+++ b/fs/ntfs3/inode.c
@@ -1679,7 +1679,10 @@ int ntfs_create_inode(struct mnt_idmap *idmap, struct inode *dir,
attr = ni_find_attr(ni, NULL, NULL, ATTR_EA, NULL, 0, NULL, NULL);
if (attr && attr->non_res) {
/* Delete ATTR_EA, if non-resident. */
- attr_set_size(ni, ATTR_EA, NULL, 0, NULL, 0, NULL, false, NULL);
+ struct runs_tree run;
+ run_init(&run);
+ attr_set_size(ni, ATTR_EA, NULL, 0, &run, 0, NULL, false, NULL);
+ run_close(&run);
}
if (rp_inserted)
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [syzbot] possible fix (linux-ntfs3)
2022-10-01 13:47 [syzbot] possible deadlock in mi_read syzbot
@ 2024-09-02 13:17 ` syzbot
0 siblings, 0 replies; 10+ messages in thread
From: syzbot @ 2024-09-02 13:17 UTC (permalink / raw)
To: linux-kernel, syzkaller-bugs
For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com.
***
Subject: possible fix (linux-ntfs3)
Author: almaz.alexandrovich@paragon-software.com
#syz test: https://github.com/Paragon-Software-Group/linux-ntfs3.git master
diff --git a/fs/ntfs3/namei.c b/fs/ntfs3/namei.c
index fc720ad9c57a..aa7e9d70e32e 100644
--- a/fs/ntfs3/namei.c
+++ b/fs/ntfs3/namei.c
@@ -81,7 +81,7 @@ static struct dentry *ntfs_lookup(struct inode *dir, struct dentry *dentry,
if (err < 0)
inode = ERR_PTR(err);
else {
- ni_lock(ni);
+ ni_lock_dir(ni);
inode = dir_search_u(dir, uni, NULL);
ni_unlock(ni);
}
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [syzbot] [ntfs3?] KMSAN: uninit-value in ntfs_read_bh
2024-09-01 20:28 [syzbot] [ntfs3?] KMSAN: uninit-value in ntfs_read_bh syzbot
@ 2024-09-04 15:47 ` syzbot
2024-09-10 7:14 ` [syzbot] possible fix (linux-ntfs3) syzbot
` (2 subsequent siblings)
3 siblings, 0 replies; 10+ messages in thread
From: syzbot @ 2024-09-04 15:47 UTC (permalink / raw)
To: almaz.alexandrovich, linux-kernel, ntfs3, syzkaller-bugs
syzbot has found a reproducer for the following issue on:
HEAD commit: 88fac17500f4 Merge tag 'fuse-fixes-6.11-rc7' of git://git...
git tree: upstream
console+strace: https://syzkaller.appspot.com/x/log.txt?x=16802d63980000
kernel config: https://syzkaller.appspot.com/x/.config?x=35c699864e165c51
dashboard link: https://syzkaller.appspot.com/bug?extid=7a2ba6b7b66340cff225
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=168f8f0b980000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1466d5b7980000
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/6e5a9ba13ba0/disk-88fac175.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/229238ec073e/vmlinux-88fac175.xz
kernel image: https://storage.googleapis.com/syzbot-assets/64327bdcda24/bzImage-88fac175.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/b6db4a705ad8/mount_0.gz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+7a2ba6b7b66340cff225@syzkaller.appspotmail.com
=====================================================
BUG: KMSAN: uninit-value in ntfs_fix_post_read fs/ntfs3/fsntfs.c:180 [inline]
BUG: KMSAN: uninit-value in ntfs_read_bh+0x1eb/0xde0 fs/ntfs3/fsntfs.c:1317
ntfs_fix_post_read fs/ntfs3/fsntfs.c:180 [inline]
ntfs_read_bh+0x1eb/0xde0 fs/ntfs3/fsntfs.c:1317
indx_read+0x44e/0x17b0 fs/ntfs3/index.c:1067
indx_find+0xd12/0x1440 fs/ntfs3/index.c:1181
indx_update_dup+0x607/0xf80 fs/ntfs3/index.c:2666
ni_update_parent+0x12de/0x14b0 fs/ntfs3/frecord.c:3301
ni_write_inode+0x1cf4/0x1de0 fs/ntfs3/frecord.c:3392
ntfs3_write_inode+0x94/0xb0 fs/ntfs3/inode.c:1052
write_inode fs/fs-writeback.c:1497 [inline]
__writeback_single_inode+0x849/0x12c0 fs/fs-writeback.c:1716
writeback_sb_inodes+0xc95/0x1e00 fs/fs-writeback.c:1947
__writeback_inodes_wb+0x14c/0x440 fs/fs-writeback.c:2018
wb_writeback+0x50b/0xea0 fs/fs-writeback.c:2129
wb_check_background_flush fs/fs-writeback.c:2199 [inline]
wb_do_writeback fs/fs-writeback.c:2287 [inline]
wb_workfn+0x122c/0x1940 fs/fs-writeback.c:2314
process_one_work kernel/workqueue.c:3231 [inline]
process_scheduled_works+0xae0/0x1c40 kernel/workqueue.c:3312
worker_thread+0xea7/0x14d0 kernel/workqueue.c:3389
kthread+0x3e2/0x540 kernel/kthread.c:389
ret_from_fork+0x6d/0x90 arch/x86/kernel/process.c:147
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244
Uninit was stored to memory at:
ntfs_read_run_nb+0x786/0x1070 fs/ntfs3/fsntfs.c:1252
ntfs_read_bh+0x64/0xde0 fs/ntfs3/fsntfs.c:1313
indx_read+0x44e/0x17b0 fs/ntfs3/index.c:1067
indx_find+0xd12/0x1440 fs/ntfs3/index.c:1181
indx_update_dup+0x607/0xf80 fs/ntfs3/index.c:2666
ni_update_parent+0x12de/0x14b0 fs/ntfs3/frecord.c:3301
ni_write_inode+0x1cf4/0x1de0 fs/ntfs3/frecord.c:3392
ntfs3_write_inode+0x94/0xb0 fs/ntfs3/inode.c:1052
write_inode fs/fs-writeback.c:1497 [inline]
__writeback_single_inode+0x849/0x12c0 fs/fs-writeback.c:1716
writeback_sb_inodes+0xc95/0x1e00 fs/fs-writeback.c:1947
__writeback_inodes_wb+0x14c/0x440 fs/fs-writeback.c:2018
wb_writeback+0x50b/0xea0 fs/fs-writeback.c:2129
wb_check_background_flush fs/fs-writeback.c:2199 [inline]
wb_do_writeback fs/fs-writeback.c:2287 [inline]
wb_workfn+0x122c/0x1940 fs/fs-writeback.c:2314
process_one_work kernel/workqueue.c:3231 [inline]
process_scheduled_works+0xae0/0x1c40 kernel/workqueue.c:3312
worker_thread+0xea7/0x14d0 kernel/workqueue.c:3389
kthread+0x3e2/0x540 kernel/kthread.c:389
ret_from_fork+0x6d/0x90 arch/x86/kernel/process.c:147
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244
Uninit was created at:
__alloc_pages_noprof+0x9d6/0xe70 mm/page_alloc.c:4718
alloc_pages_mpol_noprof+0x299/0x990 mm/mempolicy.c:2263
alloc_pages_noprof mm/mempolicy.c:2343 [inline]
folio_alloc_noprof+0x1db/0x310 mm/mempolicy.c:2350
filemap_alloc_folio_noprof+0xa6/0x440 mm/filemap.c:1008
__filemap_get_folio+0xa05/0x14b0 mm/filemap.c:1950
grow_dev_folio fs/buffer.c:1047 [inline]
grow_buffers fs/buffer.c:1113 [inline]
__getblk_slow fs/buffer.c:1139 [inline]
bdev_getblk+0x2c9/0xab0 fs/buffer.c:1441
__getblk include/linux/buffer_head.h:381 [inline]
sb_getblk include/linux/buffer_head.h:387 [inline]
ntfs_get_bh+0x605/0x1190 fs/ntfs3/fsntfs.c:1365
indx_new+0x1bc/0x780 fs/ntfs3/index.c:955
indx_insert_into_root+0x2fd1/0x37d0 fs/ntfs3/index.c:1723
indx_insert_entry+0xe1d/0xee0 fs/ntfs3/index.c:1982
ntfs_create_inode+0x4391/0x4df0 fs/ntfs3/inode.c:1689
ntfs_mkdir+0x56/0x70 fs/ntfs3/namei.c:207
vfs_mkdir+0x4a0/0x780 fs/namei.c:4210
do_mkdirat+0x529/0x810 fs/namei.c:4233
__do_sys_mkdirat fs/namei.c:4248 [inline]
__se_sys_mkdirat fs/namei.c:4246 [inline]
__x64_sys_mkdirat+0xc6/0x120 fs/namei.c:4246
x64_sys_call+0x3a81/0x3ba0 arch/x86/include/generated/asm/syscalls_64.h:259
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xcd/0x1e0 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
CPU: 0 UID: 0 PID: 3708 Comm: kworker/u8:20 Not tainted 6.11.0-rc6-syzkaller-00026-g88fac17500f4 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024
Workqueue: writeback wb_workfn (flush-7:0)
=====================================================
---
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [syzbot] possible fix (linux-ntfs3)
2024-09-04 1:15 [syzbot] [ntfs3?] INFO: trying to register non-static key in mark_as_free_ex syzbot
@ 2024-09-09 15:13 ` syzbot
0 siblings, 0 replies; 10+ messages in thread
From: syzbot @ 2024-09-09 15:13 UTC (permalink / raw)
To: linux-kernel, syzkaller-bugs
For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com.
***
Subject: possible fix (linux-ntfs3)
Author: almaz.alexandrovich@paragon-software.com
#syz test: https://github.com/Paragon-Software-Group/linux-ntfs3.git master
diff --git a/fs/ntfs3/frecord.c b/fs/ntfs3/frecord.c
index 7d4e54161291..41c7ffad2790 100644
--- a/fs/ntfs3/frecord.c
+++ b/fs/ntfs3/frecord.c
@@ -102,7 +102,9 @@ void ni_clear(struct ntfs_inode *ni)
{
struct rb_node *node;
- if (!ni->vfs_inode.i_nlink && ni->mi.mrec && is_rec_inuse(ni->mi.mrec))
+ if (!ni->vfs_inode.i_nlink && ni->mi.mrec &&
+ is_rec_inuse(ni->mi.mrec) &&
+ !(ni->mi.sbi->flags & NTFS_FLAGS_LOG_REPLAYING))
ni_delete_all(ni);
al_destroy(ni);
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [syzbot] possible fix (linux-ntfs3)
2024-08-16 13:07 [syzbot] [ntfs3?] kernel panic: stack is corrupted in vprintk_emit syzbot
2024-09-02 12:27 ` [syzbot] possible fix (linux-ntfs3) syzbot
@ 2024-09-10 7:08 ` syzbot
1 sibling, 0 replies; 10+ messages in thread
From: syzbot @ 2024-09-10 7:08 UTC (permalink / raw)
To: linux-kernel, syzkaller-bugs
For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com.
***
Subject: possible fix (linux-ntfs3)
Author: almaz.alexandrovich@paragon-software.com
#syz test: https://github.com/Paragon-Software-Group/linux-ntfs3.git master
diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
index 128d49512f5d..4a2062e481a4 100644
--- a/fs/ntfs3/super.c
+++ b/fs/ntfs3/super.c
@@ -124,10 +124,15 @@ void ntfs_inode_printk(struct inode *inode, const char *fmt, ...)
struct dentry *de = d_find_alias(inode);
if (de) {
+ int len;
spin_lock(&de->d_lock);
- snprintf(name, sizeof(s_name_buf), " \"%s\"",
- de->d_name.name);
+ len = snprintf(name, sizeof(s_name_buf), " \"%s\"",
+ de->d_name.name);
spin_unlock(&de->d_lock);
+ if (len <= 0)
+ name[0] = 0;
+ else if (len >= sizeof(s_name_buf))
+ name[sizeof(s_name_buf) - 1] = 0;
} else {
name[0] = 0;
}
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [syzbot] possible fix (linux-ntfs3)
2024-09-01 20:28 [syzbot] [ntfs3?] KMSAN: uninit-value in ntfs_read_bh syzbot
2024-09-04 15:47 ` syzbot
@ 2024-09-10 7:14 ` syzbot
2025-09-25 16:59 ` Forwarded: potential fix syzbot
2025-10-12 18:36 ` Forwarded: test fix syzbot
3 siblings, 0 replies; 10+ messages in thread
From: syzbot @ 2024-09-10 7:14 UTC (permalink / raw)
To: linux-kernel, syzkaller-bugs
For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com.
***
Subject: possible fix (linux-ntfs3)
Author: almaz.alexandrovich@paragon-software.com
Not sure about all indexes on volume must have the same index_block_size.
#syz test: https://github.com/Paragon-Software-Group/linux-ntfs3.git master
diff --git a/fs/ntfs3/index.c b/fs/ntfs3/index.c
index 9089c58a005c..63fbb8ba6e1b 100644
--- a/fs/ntfs3/index.c
+++ b/fs/ntfs3/index.c
@@ -892,7 +892,9 @@ int indx_init(struct ntfs_index *indx, struct ntfs_sb_info *sbi,
indx->idx2vbn_bits = __ffs(root->index_block_clst);
t32 = le32_to_cpu(root->index_block_size);
- indx->index_bits = blksize_bits(t32);
+ if (t32 != sbi->index_size)
+ goto out;
+ indx->index_bits = sbi->index_bits;
/* Check index record size. */
if (t32 < sbi->cluster_size) {
diff --git a/fs/ntfs3/ntfs_fs.h b/fs/ntfs3/ntfs_fs.h
index 3dd6215316e4..73d72fa8ab65 100644
--- a/fs/ntfs3/ntfs_fs.h
+++ b/fs/ntfs3/ntfs_fs.h
@@ -222,8 +222,9 @@ struct ntfs_sb_info {
u32 record_size;
u32 index_size;
- u8 cluster_bits;
- u8 record_bits;
+ u8 cluster_bits; // log2(cluster_size)
+ u8 record_bits; // log2(record_size)
+ u8 index_bits; // log2(index_size)
u64 maxbytes; // Maximum size for normal files.
u64 maxbytes_sparse; // Maximum size for sparse file.
diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
index 128d49512f5d..f96641b80869 100644
--- a/fs/ntfs3/super.c
+++ b/fs/ntfs3/super.c
@@ -993,6 +993,7 @@ static int ntfs_init_from_boot(struct super_block *sb, u32 sector_size,
sbi->index_size);
goto out;
}
+ sbi->index_bits = blksize_bits(sbi->index_size);
sbi->volume.size = sectors * boot_sector_size;
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Forwarded: potential fix
2024-09-01 20:28 [syzbot] [ntfs3?] KMSAN: uninit-value in ntfs_read_bh syzbot
2024-09-04 15:47 ` syzbot
2024-09-10 7:14 ` [syzbot] possible fix (linux-ntfs3) syzbot
@ 2025-09-25 16:59 ` syzbot
2025-10-12 18:36 ` Forwarded: test fix syzbot
3 siblings, 0 replies; 10+ messages in thread
From: syzbot @ 2025-09-25 16:59 UTC (permalink / raw)
To: linux-kernel
For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org.
***
Subject: potential fix
Author: rpthibeault@gmail.com
#syz test
^ permalink raw reply [flat|nested] 10+ messages in thread
* Forwarded: test fix
2024-09-01 20:28 [syzbot] [ntfs3?] KMSAN: uninit-value in ntfs_read_bh syzbot
` (2 preceding siblings ...)
2025-09-25 16:59 ` Forwarded: potential fix syzbot
@ 2025-10-12 18:36 ` syzbot
3 siblings, 0 replies; 10+ messages in thread
From: syzbot @ 2025-10-12 18:36 UTC (permalink / raw)
To: linux-kernel, syzkaller-bugs
For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com.
***
Subject: test fix
Author: rpthibeault@gmail.com
#syz test
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2025-10-12 18:36 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-01 20:28 [syzbot] [ntfs3?] KMSAN: uninit-value in ntfs_read_bh syzbot
2024-09-04 15:47 ` syzbot
2024-09-10 7:14 ` [syzbot] possible fix (linux-ntfs3) syzbot
2025-09-25 16:59 ` Forwarded: potential fix syzbot
2025-10-12 18:36 ` Forwarded: test fix syzbot
-- strict thread matches above, loose matches on Subject: below --
2024-09-04 1:15 [syzbot] [ntfs3?] INFO: trying to register non-static key in mark_as_free_ex syzbot
2024-09-09 15:13 ` [syzbot] possible fix (linux-ntfs3) syzbot
2024-08-16 13:07 [syzbot] [ntfs3?] kernel panic: stack is corrupted in vprintk_emit syzbot
2024-09-02 12:27 ` [syzbot] possible fix (linux-ntfs3) syzbot
2024-09-10 7:08 ` syzbot
2024-07-13 6:10 [syzbot] [ntfs3?] general protection fault in run_is_mapped_full syzbot
2024-09-02 13:00 ` [syzbot] possible fix (linux-ntfs3) syzbot
2022-10-01 13:47 [syzbot] possible deadlock in mi_read syzbot
2024-09-02 13:17 ` [syzbot] possible fix (linux-ntfs3) syzbot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.