Re: [syzbot] [usb?] [fs?] WARNING in firmware_fallback_sysfs

Re: [syzbot] [usb?] [fs?] WARNING in firmware_fallback_sysfs

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
WARNING in firmware_fallback_sysfs

WARNING: CPU: 0 PID: 5070 at fs/sysfs/group.c:282 sysfs_remove_group+0x12a/0x170 fs/sysfs/group.c:282
Modules linked in:
CPU: 0 PID: 5070 Comm: kworker/0:5 Not tainted 6.6.0-syzkaller-03860-g5a6a09e97199-dirty #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/09/2023
Workqueue: events request_firmware_work_func
RIP: 0010:sysfs_remove_group+0x12a/0x170 fs/sysfs/group.c:282
Code: 48 89 d9 49 8b 14 24 48 b8 00 00 00 00 00 fc ff df 48 c1 e9 03 80 3c 01 00 75 37 48 8b 33 48 c7 c7 40 3f c0 8a e8 d6 84 37 ff <0f> 0b eb 98 e8 3d e7 c6 ff e9 01 ff ff ff 48 89 df e8 30 e7 c6 ff
RSP: 0018:ffffc9000377f9a8 EFLAGS: 00010282
RAX: 0000000000000000 RBX: ffffffff8b377da0 RCX: ffffffff814d2eb9
RDX: ffff88802b036180 RSI: ffffffff814d2ec6 RDI: 0000000000000001
RBP: 0000000000000000 R08: 0000000000000001 R09: 0000000000000000
R10: 0000000000000001 R11: 0000000000000001 R12: ffff88801c3d5008
R13: ffffffff8b378340 R14: 0000000000001770 R15: ffff88801c3d5008
FS:  0000000000000000(0000) GS:ffff8880b9800000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fe076d98000 CR3: 000000002906b000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <TASK>
 dpm_sysfs_remove+0x9d/0xb0 drivers/base/power/sysfs.c:837
 device_del+0x1a8/0xa50 drivers/base/core.c:3788
 fw_load_sysfs_fallback drivers/base/firmware_loader/fallback.c:120 [inline]
 fw_load_from_user_helper drivers/base/firmware_loader/fallback.c:158 [inline]
 firmware_fallback_sysfs+0xa73/0xb90 drivers/base/firmware_loader/fallback.c:234
 _request_firmware+0xe5b/0x12a0 drivers/base/firmware_loader/main.c:909
 request_firmware_work_func+0xeb/0x240 drivers/base/firmware_loader/main.c:1160
 process_one_work+0x884/0x15c0 kernel/workqueue.c:2630
 process_scheduled_works kernel/workqueue.c:2703 [inline]
 worker_thread+0x8b9/0x1290 kernel/workqueue.c:2784
 kthread+0x33c/0x440 kernel/kthread.c:388
 ret_from_fork+0x45/0x80 arch/x86/kernel/process.c:147
 ret_from_fork_asm+0x11/0x20 arch/x86/entry/entry_64.S:242
 </TASK>


Tested on:

commit:         5a6a09e9 Merge tag 'cgroup-for-6.7' of git://git.kerne..
git tree:       git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
console output: https://syzkaller.appspot.com/x/log.txt?x=1198425b680000
kernel config:  https://syzkaller.appspot.com/x/.config?x=c450de9124fc495d
dashboard link: https://syzkaller.appspot.com/bug?extid=95f2e2439b97575ec3c0
compiler:       gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40
patch:          https://syzkaller.appspot.com/x/patch.diff?x=1114ab60e80000