All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Doug Smythies" <dsmythies@telus.net>
To: 'Prarit Bhargava' <prarit@redhat.com>
Cc: 'Kristen Carlson Accardi' <kristen@linux.intel.com>,
	linux-kernel@vger.kernel.org,
	'Viresh Kumar' <viresh.kumar@linaro.org>,
	linux-pm@vger.kernel.org,
	"'Rafael J. Wysocki'" <rjw@rjwysocki.net>,
	Doug Smythies <dsmythies@telus.net>
Subject: RE: [PATCH] cpufreq, intel_pstate, set max_sysfs_pct and min_sysfs_pct on governor switch
Date: Wed, 7 Oct 2015 07:04:20 -0700	[thread overview]
Message-ID: <000001d10109$10d34630$3279d290$@net> (raw)
In-Reply-To: <5614ED1C.8070709@redhat.com>


On 2015.10.07 03:00 Prarit Bhargava wrote:
> On 10/07/2015 02:51 AM, Doug Smythies wrote:
>> 
>> And before patch I get, using primitives and not cpupower:
>> Executive Summary: Everything works fine (or at least as I thought it was supposed to).
>> 
>> root@s15:/home/doug/temp# grep . /sys/devices/system/cpu/cpu*/cpufreq/scaling_governor
>> /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor:powersave
>> ...
>> /sys/devices/system/cpu/cpu7/cpufreq/scaling_governor:powersave
>> root@s15:/home/doug/temp# grep . /sys/devices/system/cpu/intel_pstate/*_perf_*
>> /sys/devices/system/cpu/intel_pstate/max_perf_pct:100
>> /sys/devices/system/cpu/intel_pstate/min_perf_pct:42
>> root@s15:/home/doug/temp# echo 50 > /sys/devices/system/cpu/intel_pstate/min_perf_pct
>> root@s15:/home/doug/temp# echo 80 > /sys/devices/system/cpu/intel_pstate/max_perf_pct
>> root@s15:/home/doug/temp# grep . /sys/devices/system/cpu/intel_pstate/*_perf_*
>> /sys/devices/system/cpu/intel_pstate/max_perf_pct:80
>> /sys/devices/system/cpu/intel_pstate/min_perf_pct:50
>> root@s15:/home/doug/temp# for file in /sys/devices/system/cpu/cpu*/cpufreq/scaling_governor; do echo "performance" > $file; done
>> root@s15:/home/doug/temp# grep . /sys/devices/system/cpu/intel_pstate/*_perf_*
>> /sys/devices/system/cpu/intel_pstate/max_perf_pct:100
>> /sys/devices/system/cpu/intel_pstate/min_perf_pct:100
>> root@s15:/home/doug/temp# grep . /sys/devices/system/cpu/cpu*/cpufreq/scaling_governor
>> /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor:performance
>
> The switch has to be from performance to powersave.  Switch again and you'll see
> the problem.

Yes, of course, and I did.
The first "powersave" listing was just to show the setup.
Continue reading my original reply, also added back below:
The "..." stuff is just where I deleted 6 of the 8 CPUs saying the same thing.

root@s15:/home/doug/temp# grep . /sys/devices/system/cpu/intel_pstate/*_perf_*
/sys/devices/system/cpu/intel_pstate/max_perf_pct:100
/sys/devices/system/cpu/intel_pstate/min_perf_pct:100
root@s15:/home/doug/temp# grep . /sys/devices/system/cpu/cpu*/cpufreq/scaling_governor
/sys/devices/system/cpu/cpu0/cpufreq/scaling_governor:performance
...
/sys/devices/system/cpu/cpu7/cpufreq/scaling_governor:performance
root@s15:/home/doug/temp# for file in /sys/devices/system/cpu/cpu*/cpufreq/scaling_governor; do echo "powersave" > $file; done
root@s15:/home/doug/temp# grep . /sys/devices/system/cpu/cpu*/cpufreq/scaling_governor
/sys/devices/system/cpu/cpu0/cpufreq/scaling_governor:powersave
...
/sys/devices/system/cpu/cpu7/cpufreq/scaling_governor:powersave
root@s15:/home/doug/temp# grep . /sys/devices/system/cpu/intel_pstate/*_perf_*
/sys/devices/system/cpu/intel_pstate/max_perf_pct:80
/sys/devices/system/cpu/intel_pstate/min_perf_pct:50

> I can also reproduce this without using 'cpupower'.

Interesting. Then maybe it is a difference between legacy mode
and Hardware P state (HWP) mode. I do not have an HWP capable processor
to test.

I compiled cpupower, but get the same results as I get using primitives,
meaning things work properly before the patch and resort to defaults
after the patch.



WARNING: multiple messages have this Message-ID (diff)
From: "Doug Smythies" <dsmythies@telus.net>
To: "'Prarit Bhargava'" <prarit@redhat.com>
Cc: "'Kristen Carlson Accardi'" <kristen@linux.intel.com>,
	<linux-kernel@vger.kernel.org>,
	"'Viresh Kumar'" <viresh.kumar@linaro.org>,
	<linux-pm@vger.kernel.org>,
	"'Rafael J. Wysocki'" <rjw@rjwysocki.net>,
	"Doug Smythies" <dsmythies@telus.net>
Subject: RE: [PATCH] cpufreq, intel_pstate, set max_sysfs_pct and min_sysfs_pct on governor switch
Date: Wed, 7 Oct 2015 07:04:20 -0700	[thread overview]
Message-ID: <000001d10109$10d34630$3279d290$@net> (raw)
In-Reply-To: <5614ED1C.8070709@redhat.com>


On 2015.10.07 03:00 Prarit Bhargava wrote:
> On 10/07/2015 02:51 AM, Doug Smythies wrote:
>> 
>> And before patch I get, using primitives and not cpupower:
>> Executive Summary: Everything works fine (or at least as I thought it was supposed to).
>> 
>> root@s15:/home/doug/temp# grep . /sys/devices/system/cpu/cpu*/cpufreq/scaling_governor
>> /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor:powersave
>> ...
>> /sys/devices/system/cpu/cpu7/cpufreq/scaling_governor:powersave
>> root@s15:/home/doug/temp# grep . /sys/devices/system/cpu/intel_pstate/*_perf_*
>> /sys/devices/system/cpu/intel_pstate/max_perf_pct:100
>> /sys/devices/system/cpu/intel_pstate/min_perf_pct:42
>> root@s15:/home/doug/temp# echo 50 > /sys/devices/system/cpu/intel_pstate/min_perf_pct
>> root@s15:/home/doug/temp# echo 80 > /sys/devices/system/cpu/intel_pstate/max_perf_pct
>> root@s15:/home/doug/temp# grep . /sys/devices/system/cpu/intel_pstate/*_perf_*
>> /sys/devices/system/cpu/intel_pstate/max_perf_pct:80
>> /sys/devices/system/cpu/intel_pstate/min_perf_pct:50
>> root@s15:/home/doug/temp# for file in /sys/devices/system/cpu/cpu*/cpufreq/scaling_governor; do echo "performance" > $file; done
>> root@s15:/home/doug/temp# grep . /sys/devices/system/cpu/intel_pstate/*_perf_*
>> /sys/devices/system/cpu/intel_pstate/max_perf_pct:100
>> /sys/devices/system/cpu/intel_pstate/min_perf_pct:100
>> root@s15:/home/doug/temp# grep . /sys/devices/system/cpu/cpu*/cpufreq/scaling_governor
>> /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor:performance
>
> The switch has to be from performance to powersave.  Switch again and you'll see
> the problem.

Yes, of course, and I did.
The first "powersave" listing was just to show the setup.
Continue reading my original reply, also added back below:
The "..." stuff is just where I deleted 6 of the 8 CPUs saying the same thing.

root@s15:/home/doug/temp# grep . /sys/devices/system/cpu/intel_pstate/*_perf_*
/sys/devices/system/cpu/intel_pstate/max_perf_pct:100
/sys/devices/system/cpu/intel_pstate/min_perf_pct:100
root@s15:/home/doug/temp# grep . /sys/devices/system/cpu/cpu*/cpufreq/scaling_governor
/sys/devices/system/cpu/cpu0/cpufreq/scaling_governor:performance
...
/sys/devices/system/cpu/cpu7/cpufreq/scaling_governor:performance
root@s15:/home/doug/temp# for file in /sys/devices/system/cpu/cpu*/cpufreq/scaling_governor; do echo "powersave" > $file; done
root@s15:/home/doug/temp# grep . /sys/devices/system/cpu/cpu*/cpufreq/scaling_governor
/sys/devices/system/cpu/cpu0/cpufreq/scaling_governor:powersave
...
/sys/devices/system/cpu/cpu7/cpufreq/scaling_governor:powersave
root@s15:/home/doug/temp# grep . /sys/devices/system/cpu/intel_pstate/*_perf_*
/sys/devices/system/cpu/intel_pstate/max_perf_pct:80
/sys/devices/system/cpu/intel_pstate/min_perf_pct:50

> I can also reproduce this without using 'cpupower'.

Interesting. Then maybe it is a difference between legacy mode
and Hardware P state (HWP) mode. I do not have an HWP capable processor
to test.

I compiled cpupower, but get the same results as I get using primitives,
meaning things work properly before the patch and resort to defaults
after the patch.



  reply	other threads:[~2015-10-07 14:04 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-06 21:49 [PATCH] cpufreq, intel_pstate, set max_sysfs_pct and min_sysfs_pct on governor switch Prarit Bhargava
2015-10-06 22:43 ` Rafael J. Wysocki
2015-10-06 23:06   ` Rafael J. Wysocki
2015-10-07  6:51     ` Doug Smythies
2015-10-07  6:51       ` Doug Smythies
2015-10-07  9:59       ` Prarit Bhargava
2015-10-07 14:04         ` Doug Smythies [this message]
2015-10-07 14:04           ` Doug Smythies
2015-10-07 14:10           ` Prarit Bhargava
2015-10-07 15:40             ` Doug Smythies
2015-10-07 15:40               ` Doug Smythies
2015-10-07 15:46               ` Prarit Bhargava
2015-10-07 18:52                 ` Doug Smythies
2015-10-07 18:52                   ` Doug Smythies
2015-10-07 20:40                   ` Prarit Bhargava
2015-10-07 21:31                   ` Prarit Bhargava
2015-10-07 22:05                     ` Rafael J. Wysocki
2015-10-07 22:26                       ` Doug Smythies
2015-10-07 22:26                         ` Doug Smythies
2015-10-07 23:17                         ` Prarit Bhargava
2015-10-08  0:13                         ` Prarit Bhargava
2015-10-07 23:08                       ` Prarit Bhargava
2015-10-07 14:34           ` Prarit Bhargava
2015-10-07 11:38     ` Prarit Bhargava
2015-10-07 12:18     ` Prarit Bhargava
2015-10-07 14:50       ` Prarit Bhargava

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000001d10109$10d34630$3279d290$@net' \
    --to=dsmythies@telus.net \
    --cc=kristen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=prarit@redhat.com \
    --cc=rjw@rjwysocki.net \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.