From: "Allen Hubbe" <Allen.Hubbe@emc.com>
To: "'Yu, Xiangliang'" <Xiangliang.Yu@amd.com>,
jdmason@kudzu.us, dave.jiang@intel.com,
linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org
Cc: 'SPG_Linux_Kernel' <SPG_Linux_Kernel@amd.com>
Subject: RE: [PATCH V2 0/3] Change notes of V2
Date: Thu, 7 Jan 2016 09:43:09 -0500 [thread overview]
Message-ID: <000001d14959$bb730790$325916b0$@emc.com> (raw)
In-Reply-To: <BLUPR12MB0420EEA096245F2D6DEDD483EBF50@BLUPR12MB0420.namprd12.prod.outlook.com>
> > In particular, I think we need feedback on #3 from PCI and power
> > management maintainers.
>
> I don't get your concern.
> I think we can add device attribute file to let application to trigger
> wakeup function, then NTB hardware will do the rest. NTB driver just
> need to implement suspend/resume interface of PCI PM.
>
> Add one more thing, do you think NTB should support runtime power
> management?
>
I think it is good to make the power management functionality available. In other words, yes, to your last question.
My concern is that I would like some degree of certainty that it is done right, in harmony with the rest of the kernel. I don't know what "done right" means in this case, which is why I would like someone else to review it. A smaller patch with only (and all of) the power management code will have a better chance of being reviewed.
I'm also concerned about the waiting behavior in #2 and #3. I'm not saying it's wrong. At least now that behavior is noted in the api documentation; thanks for that. If a PCI or power management expert has no objection to the waiting behavior in #3, then I would be comfortable with that behavior in #2 as well.
Allen
WARNING: multiple messages have this Message-ID (diff)
From: "Allen Hubbe" <Allen.Hubbe@emc.com>
To: "'Yu, Xiangliang'" <Xiangliang.Yu@amd.com>, <jdmason@kudzu.us>,
<dave.jiang@intel.com>, <linux-ntb@googlegroups.com>,
<linux-kernel@vger.kernel.org>
Cc: "'SPG_Linux_Kernel'" <SPG_Linux_Kernel@amd.com>
Subject: RE: [PATCH V2 0/3] Change notes of V2
Date: Thu, 7 Jan 2016 09:43:09 -0500 [thread overview]
Message-ID: <000001d14959$bb730790$325916b0$@emc.com> (raw)
In-Reply-To: <BLUPR12MB0420EEA096245F2D6DEDD483EBF50@BLUPR12MB0420.namprd12.prod.outlook.com>
> > In particular, I think we need feedback on #3 from PCI and power
> > management maintainers.
>
> I don't get your concern.
> I think we can add device attribute file to let application to trigger
> wakeup function, then NTB hardware will do the rest. NTB driver just
> need to implement suspend/resume interface of PCI PM.
>
> Add one more thing, do you think NTB should support runtime power
> management?
>
I think it is good to make the power management functionality available. In other words, yes, to your last question.
My concern is that I would like some degree of certainty that it is done right, in harmony with the rest of the kernel. I don't know what "done right" means in this case, which is why I would like someone else to review it. A smaller patch with only (and all of) the power management code will have a better chance of being reviewed.
I'm also concerned about the waiting behavior in #2 and #3. I'm not saying it's wrong. At least now that behavior is noted in the api documentation; thanks for that. If a PCI or power management expert has no objection to the waiting behavior in #3, then I would be comfortable with that behavior in #2 as well.
Allen
next prev parent reply other threads:[~2016-01-07 14:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 13:42 [PATCH V2 0/3] Change notes of V2 Xiangliang Yu
2015-12-23 13:42 ` Xiangliang Yu
2016-01-06 18:19 ` Allen Hubbe
2016-01-06 18:19 ` Allen Hubbe
2016-01-07 3:15 ` Yu, Xiangliang
2016-01-07 3:15 ` Yu, Xiangliang
2016-01-07 14:43 ` Allen Hubbe [this message]
2016-01-07 14:43 ` Allen Hubbe
2016-01-08 3:09 ` Yu, Xiangliang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001d14959$bb730790$325916b0$@emc.com' \
--to=allen.hubbe@emc.com \
--cc=SPG_Linux_Kernel@amd.com \
--cc=Xiangliang.Yu@amd.com \
--cc=dave.jiang@intel.com \
--cc=jdmason@kudzu.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.