All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Chanho Park" <chanho61.park@samsung.com>
To: "'Sam Protsenko'" <semen.protsenko@linaro.org>,
	"'Wolfram Sang'" <wsa@kernel.org>,
	"'Krzysztof Kozlowski'" <krzysztof.kozlowski@canonical.com>
Cc: "'Jaewon Kim'" <jaewon02.kim@samsung.com>,
	<linux-i2c@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-samsung-soc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] i2c: exynos5: Fix getting the optional clock
Date: Mon, 13 Dec 2021 09:00:48 +0900	[thread overview]
Message-ID: <000001d7efb4$7c608110$75218330$@samsung.com> (raw)
In-Reply-To: <20211212181057.20210-1-semen.protsenko@linaro.org>

> "hsi2c_pclk" clock is optional and may not be present for some SoCs
> supported by this driver. Nevertheless, in case the clock is provided but
> some error happens during its getting, that error should be handled
> properly. Use devm_clk_get_optional() API for that. Also report possible
> errors using dev_err_probe() to handle properly -EPROBE_DEFER error (if
> clock provider is not ready by the time I2C probe function is executed).
> 
> Fixes: c93ac09df2a8 ("i2c: exynos5: Add bus clock support")
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>

Reviewed-by: Chanho Park <chanho61.park@samsung.com>


WARNING: multiple messages have this Message-ID (diff)
From: "Chanho Park" <chanho61.park@samsung.com>
To: "'Sam Protsenko'" <semen.protsenko@linaro.org>,
	"'Wolfram Sang'" <wsa@kernel.org>,
	"'Krzysztof Kozlowski'" <krzysztof.kozlowski@canonical.com>
Cc: "'Jaewon Kim'" <jaewon02.kim@samsung.com>,
	<linux-i2c@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-samsung-soc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] i2c: exynos5: Fix getting the optional clock
Date: Mon, 13 Dec 2021 09:00:48 +0900	[thread overview]
Message-ID: <000001d7efb4$7c608110$75218330$@samsung.com> (raw)
In-Reply-To: <20211212181057.20210-1-semen.protsenko@linaro.org>

> "hsi2c_pclk" clock is optional and may not be present for some SoCs
> supported by this driver. Nevertheless, in case the clock is provided but
> some error happens during its getting, that error should be handled
> properly. Use devm_clk_get_optional() API for that. Also report possible
> errors using dev_err_probe() to handle properly -EPROBE_DEFER error (if
> clock provider is not ready by the time I2C probe function is executed).
> 
> Fixes: c93ac09df2a8 ("i2c: exynos5: Add bus clock support")
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>

Reviewed-by: Chanho Park <chanho61.park@samsung.com>


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-12-13  0:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20211212181103epcas2p2f366435198200c3f4bac0fdf8ad1d0a3@epcas2p2.samsung.com>
2021-12-12 18:10 ` [PATCH] i2c: exynos5: Fix getting the optional clock Sam Protsenko
2021-12-12 18:10   ` Sam Protsenko
2021-12-12 18:23   ` Krzysztof Kozlowski
2021-12-12 18:23     ` Krzysztof Kozlowski
2021-12-13  0:00   ` Chanho Park [this message]
2021-12-13  0:00     ` Chanho Park
2021-12-16 21:22   ` Wolfram Sang
2021-12-16 21:22     ` Wolfram Sang
2021-12-16 23:04     ` Sam Protsenko
2021-12-16 23:04       ` Sam Protsenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000001d7efb4$7c608110$75218330$@samsung.com' \
    --to=chanho61.park@samsung.com \
    --cc=jaewon02.kim@samsung.com \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=semen.protsenko@linaro.org \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.