From: "Kwanghoon Son" <k.son@samsung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
<p.zabel@pengutronix.de>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<jszhang@kernel.org>, <guoren@kernel.org>, <wefu@redhat.com>,
<paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
<aou@eecs.berkeley.edu>, <inki.dae@samsung.com>
Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-riscv@lists.infradead.org>
Subject: RE: [RFC PATCH 2/3] reset: Add th1520 reset driver support
Date: Wed, 6 Sep 2023 11:19:08 +0900 [thread overview]
Message-ID: <000001d9e068$84cabcc0$8e603640$@samsung.com> (raw)
In-Reply-To: <a19f9b10-f65f-6719-635f-06bc10b79c61@linaro.org>
> > drivers/reset/Kconfig | 10 +++
> > drivers/reset/Makefile | 1 +
> > drivers/reset/reset-th1520.c | 109 +++++++++++++++++++++++
> > include/dt-bindings/reset/th1520-reset.h | 9 ++
>
> Bindings are always separate patches. In this case, all bindings should
> be together. Also you clearly forgot one step:
Thanks for the feedback. Does it mean 2 files
`include/dt-bindings/reset/th1520-reset.h`, `Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml`
Should be one patch first together?
Kwnag.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: "Kwanghoon Son" <k.son@samsung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
<p.zabel@pengutronix.de>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<jszhang@kernel.org>, <guoren@kernel.org>, <wefu@redhat.com>,
<paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
<aou@eecs.berkeley.edu>, <inki.dae@samsung.com>
Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-riscv@lists.infradead.org>
Subject: RE: [RFC PATCH 2/3] reset: Add th1520 reset driver support
Date: Wed, 6 Sep 2023 11:19:08 +0900 [thread overview]
Message-ID: <000001d9e068$84cabcc0$8e603640$@samsung.com> (raw)
In-Reply-To: <a19f9b10-f65f-6719-635f-06bc10b79c61@linaro.org>
> > drivers/reset/Kconfig | 10 +++
> > drivers/reset/Makefile | 1 +
> > drivers/reset/reset-th1520.c | 109 +++++++++++++++++++++++
> > include/dt-bindings/reset/th1520-reset.h | 9 ++
>
> Bindings are always separate patches. In this case, all bindings should
> be together. Also you clearly forgot one step:
Thanks for the feedback. Does it mean 2 files
`include/dt-bindings/reset/th1520-reset.h`, `Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml`
Should be one patch first together?
Kwnag.
next prev parent reply other threads:[~2023-09-06 2:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230904042603epcas1p40f732a0ac7871371126d229945cc0849@epcas1p4.samsung.com>
2023-09-04 4:25 ` [RFC PATCH 0/3] Introduce reset driver for T-HEAD th1520 SoC Kwanghoon Son
2023-09-04 4:25 ` Kwanghoon Son
2023-09-04 4:25 ` [RFC PATCH 1/3] dt-bindings: reset: Document th1520 reset control Kwanghoon Son
2023-09-04 4:25 ` Kwanghoon Son
2023-09-04 5:22 ` Rob Herring
2023-09-04 5:22 ` Rob Herring
2023-09-04 7:29 ` Krzysztof Kozlowski
2023-09-04 7:29 ` Krzysztof Kozlowski
2023-09-04 4:25 ` [RFC PATCH 2/3] reset: Add th1520 reset driver support Kwanghoon Son
2023-09-04 4:25 ` Kwanghoon Son
2023-09-04 14:19 ` Krzysztof Kozlowski
2023-09-04 14:19 ` Krzysztof Kozlowski
2023-09-06 2:19 ` Kwanghoon Son [this message]
2023-09-06 2:19 ` Kwanghoon Son
2023-09-04 4:25 ` [RFC PATCH 3/3] riscv: dts: Add th1520 reset device tree Kwanghoon Son
2023-09-04 4:25 ` Kwanghoon Son
2023-09-04 7:29 ` Krzysztof Kozlowski
2023-09-04 7:29 ` Krzysztof Kozlowski
2023-09-06 6:26 ` [RFC PATCH 0/3] Introduce reset driver for T-HEAD th1520 SoC Philipp Zabel
2023-09-06 6:26 ` Philipp Zabel
2023-09-07 1:46 ` Kwanghoon Son
2023-09-07 1:46 ` Kwanghoon Son
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001d9e068$84cabcc0$8e603640$@samsung.com' \
--to=k.son@samsung.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=guoren@kernel.org \
--cc=inki.dae@samsung.com \
--cc=jszhang@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=wefu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.