All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Pritam Manohar Sutar" <pritam.sutar@samsung.com>
To: "'Krzysztof Kozlowski'" <krzk@kernel.org>
Cc: <vkoul@kernel.org>, <kishon@kernel.org>, <robh@kernel.org>,
	<krzk+dt@kernel.org>, <conor+dt@kernel.org>,
	<alim.akhtar@samsung.com>, <andre.draszik@linaro.org>,
	<peter.griffin@linaro.org>, <kauschluss@disroot.org>,
	<ivo.ivanov.ivanov1@gmail.com>,
	<igor.belwon@mentallysanemainliners.org>,
	<m.szyprowski@samsung.com>, <s.nawrocki@samsung.com>,
	<linux-phy@lists.infradead.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-samsung-soc@vger.kernel.org>, <rosa.pila@samsung.com>,
	<dev.tailor@samsung.com>, <faraz.ata@samsung.com>,
	<muhammed.ali@samsung.com>, <selvarasu.g@samsung.com>
Subject: RE: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 HS phy compatible
Date: Thu, 4 Sep 2025 13:21:07 +0530	[thread overview]
Message-ID: <000001dc1d70$aebf7d80$0c3e7880$@samsung.com> (raw)
In-Reply-To: <20250904-interesting-lovely-ringtail-38bbef@kuoka>

Hi Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 04 September 2025 12:18 PM
> To: Pritam Manohar Sutar <pritam.sutar@samsung.com>
> Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org;
> krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com;
> andre.draszik@linaro.org; peter.griffin@linaro.org; kauschluss@disroot.org;
> ivo.ivanov.ivanov1@gmail.com; igor.belwon@mentallysanemainliners.org;
> m.szyprowski@samsung.com; s.nawrocki@samsung.com; linux-
> phy@lists.infradead.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung-
> soc@vger.kernel.org; rosa.pila@samsung.com; dev.tailor@samsung.com;
> faraz.ata@samsung.com; muhammed.ali@samsung.com;
> selvarasu.g@samsung.com
> Subject: Re: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add
> ExynosAutov920 HS phy compatible
> 
> On Wed, Sep 03, 2025 at 01:08:22PM +0530, Pritam Manohar Sutar wrote:
> > Document support for the USB20 phy found on the ExynosAutov920 SoC.
> > The
> > USB20 phy is functionally identical to that on the Exynos850 SoC, so
> > no driver changes are needed to support this phy. However, add a
> > dedicated compatible string for USB20 phy found in this SoC.
> >
> > Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com>
> 
> You just dropped all tags without explaining why.

Regretted inconvenience. 

There were significant changes in supplies' names in driver and schemas 
(patch-set v8). This led to make changes in patch no 5.  And review for 
these changes is needed.  Hence, removed RB tag in this patch-set. 

There was a ask for the same https://lore.kernel.org/linux-phy/000401dc18cd$ec02a1b0$c407e510$@samsung.com/#:~:text=Let%20me%20know%2C%20because%20of%20above%20changes%2C%20should%20be%20removing%20your%20%0A%27reviewed%2Dby%27%20tag%20from%20patch%201%20and%203.

This had to be captured in changelog along with other details. Will remember to add details 
in future, if any tags are removed. 

However,  do I need to send v9 with the details? 

> 
> <form letter>
> This is a friendly reminder during the review process.
> 
> It looks like you received a tag and forgot to add it.
> 
> If you do not know the process, here is a short explanation:
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions of
> patchset, under or above your Signed-off-by tag, unless patch changed
> significantly (e.g. new properties added to the DT bindings). Tag is "received",
> when provided in a message replied to you on the mailing list. Tools like b4 can
> help here. However, there's no need to repost patches *only* to add the tags.
> The upstream maintainer will do that for tags received on the version they apply.
> 
> Please read:
> https://protect2.fireeye.com/v1/url?k=6abe7ac7-0bc392bf-6abff188-
> 74fe485fffb1-49c70cea06738e63&q=1&e=fc43c80a-8c7b-41b0-aa24-
> 8cb76d954fe5&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Fv6.12-
> rc3%2Fsource%2FDocumentation%2Fprocess%2Fsubmitting-
> patches.rst%23L577
> 
> If a tag was not added on purpose, please state why and what changed.
> </form letter>
> 
> Best regards,
> Krzysztof

Thank you.

Regards,
Pritam




WARNING: multiple messages have this Message-ID (diff)
From: "Pritam Manohar Sutar" <pritam.sutar@samsung.com>
To: "'Krzysztof Kozlowski'" <krzk@kernel.org>
Cc: <vkoul@kernel.org>, <kishon@kernel.org>, <robh@kernel.org>,
	<krzk+dt@kernel.org>, <conor+dt@kernel.org>,
	<alim.akhtar@samsung.com>, <andre.draszik@linaro.org>,
	<peter.griffin@linaro.org>, <kauschluss@disroot.org>,
	<ivo.ivanov.ivanov1@gmail.com>,
	<igor.belwon@mentallysanemainliners.org>,
	<m.szyprowski@samsung.com>, <s.nawrocki@samsung.com>,
	<linux-phy@lists.infradead.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-samsung-soc@vger.kernel.org>, <rosa.pila@samsung.com>,
	<dev.tailor@samsung.com>, <faraz.ata@samsung.com>,
	<muhammed.ali@samsung.com>, <selvarasu.g@samsung.com>
Subject: RE: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 HS phy compatible
Date: Thu, 4 Sep 2025 13:21:07 +0530	[thread overview]
Message-ID: <000001dc1d70$aebf7d80$0c3e7880$@samsung.com> (raw)
In-Reply-To: <20250904-interesting-lovely-ringtail-38bbef@kuoka>

Hi Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 04 September 2025 12:18 PM
> To: Pritam Manohar Sutar <pritam.sutar@samsung.com>
> Cc: vkoul@kernel.org; kishon@kernel.org; robh@kernel.org;
> krzk+dt@kernel.org; conor+dt@kernel.org; alim.akhtar@samsung.com;
> andre.draszik@linaro.org; peter.griffin@linaro.org; kauschluss@disroot.org;
> ivo.ivanov.ivanov1@gmail.com; igor.belwon@mentallysanemainliners.org;
> m.szyprowski@samsung.com; s.nawrocki@samsung.com; linux-
> phy@lists.infradead.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung-
> soc@vger.kernel.org; rosa.pila@samsung.com; dev.tailor@samsung.com;
> faraz.ata@samsung.com; muhammed.ali@samsung.com;
> selvarasu.g@samsung.com
> Subject: Re: [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add
> ExynosAutov920 HS phy compatible
> 
> On Wed, Sep 03, 2025 at 01:08:22PM +0530, Pritam Manohar Sutar wrote:
> > Document support for the USB20 phy found on the ExynosAutov920 SoC.
> > The
> > USB20 phy is functionally identical to that on the Exynos850 SoC, so
> > no driver changes are needed to support this phy. However, add a
> > dedicated compatible string for USB20 phy found in this SoC.
> >
> > Signed-off-by: Pritam Manohar Sutar <pritam.sutar@samsung.com>
> 
> You just dropped all tags without explaining why.

Regretted inconvenience. 

There were significant changes in supplies' names in driver and schemas 
(patch-set v8). This led to make changes in patch no 5.  And review for 
these changes is needed.  Hence, removed RB tag in this patch-set. 

There was a ask for the same https://lore.kernel.org/linux-phy/000401dc18cd$ec02a1b0$c407e510$@samsung.com/#:~:text=Let%20me%20know%2C%20because%20of%20above%20changes%2C%20should%20be%20removing%20your%20%0A%27reviewed%2Dby%27%20tag%20from%20patch%201%20and%203.

This had to be captured in changelog along with other details. Will remember to add details 
in future, if any tags are removed. 

However,  do I need to send v9 with the details? 

> 
> <form letter>
> This is a friendly reminder during the review process.
> 
> It looks like you received a tag and forgot to add it.
> 
> If you do not know the process, here is a short explanation:
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions of
> patchset, under or above your Signed-off-by tag, unless patch changed
> significantly (e.g. new properties added to the DT bindings). Tag is "received",
> when provided in a message replied to you on the mailing list. Tools like b4 can
> help here. However, there's no need to repost patches *only* to add the tags.
> The upstream maintainer will do that for tags received on the version they apply.
> 
> Please read:
> https://protect2.fireeye.com/v1/url?k=6abe7ac7-0bc392bf-6abff188-
> 74fe485fffb1-49c70cea06738e63&q=1&e=fc43c80a-8c7b-41b0-aa24-
> 8cb76d954fe5&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Fv6.12-
> rc3%2Fsource%2FDocumentation%2Fprocess%2Fsubmitting-
> patches.rst%23L577
> 
> If a tag was not added on purpose, please state why and what changed.
> </form letter>
> 
> Best regards,
> Krzysztof

Thank you.

Regards,
Pritam



-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  reply	other threads:[~2025-09-04  8:17 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20250903072932epcas5p4dc5b5ada87f09f6f0c4e1b750874fc85@epcas5p4.samsung.com>
2025-09-03  7:38 ` [PATCH v8 0/6] initial usbdrd phy support for Exynosautov920 soc Pritam Manohar Sutar
2025-09-03  7:38   ` Pritam Manohar Sutar
2025-09-03  7:38   ` [PATCH v8 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 HS phy compatible Pritam Manohar Sutar
2025-09-03  7:38     ` Pritam Manohar Sutar
2025-09-04  6:48     ` Krzysztof Kozlowski
2025-09-04  6:48       ` Krzysztof Kozlowski
2025-09-04  7:51       ` Pritam Manohar Sutar [this message]
2025-09-04  7:51         ` Pritam Manohar Sutar
2025-09-04  9:42         ` Krzysztof Kozlowski
2025-09-04  9:42           ` Krzysztof Kozlowski
2025-09-04 10:21           ` Pritam Manohar Sutar
2025-09-04 10:21             ` Pritam Manohar Sutar
2025-09-18  2:43             ` Krzysztof Kozlowski
2025-09-18  2:43               ` Krzysztof Kozlowski
2025-09-18 11:49               ` Pritam Manohar Sutar
2025-09-18 11:49                 ` Pritam Manohar Sutar
2025-09-17  7:07           ` Pritam Manohar Sutar
2025-09-17  7:07             ` Pritam Manohar Sutar
2025-09-18  2:44     ` Krzysztof Kozlowski
2025-09-18  2:44       ` Krzysztof Kozlowski
2025-09-18 11:55       ` Pritam Manohar Sutar
2025-09-18 11:55         ` Pritam Manohar Sutar
2025-09-19  0:29         ` Krzysztof Kozlowski
2025-09-19  0:29           ` Krzysztof Kozlowski
2025-09-22  5:26           ` Pritam Manohar Sutar
2025-09-22  5:26             ` Pritam Manohar Sutar
2025-10-07  6:23             ` Krzysztof Kozlowski
2025-10-07  6:23               ` Krzysztof Kozlowski
2025-10-08  4:45               ` Pritam Manohar Sutar
2025-10-08  4:45                 ` Pritam Manohar Sutar
2025-10-08  8:12                 ` Krzysztof Kozlowski
2025-10-08  8:12                   ` Krzysztof Kozlowski
2025-10-08 11:43                   ` Pritam Manohar Sutar
2025-10-08 11:43                     ` Pritam Manohar Sutar
2025-09-29  6:45     ` Alim Akhtar
2025-09-29  6:45       ` Alim Akhtar
2025-10-06  7:55       ` Pritam Manohar Sutar
2025-10-06  7:55         ` Pritam Manohar Sutar
2025-09-03  7:38   ` [PATCH v8 2/6] phy: exynos5-usbdrd: support HS phy for ExynosAutov920 Pritam Manohar Sutar
2025-09-03  7:38     ` Pritam Manohar Sutar
2025-09-29  6:46     ` Alim Akhtar
2025-09-29  6:46       ` Alim Akhtar
2025-09-03  7:38   ` [PATCH v8 3/6] dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 combo hsphy Pritam Manohar Sutar
2025-09-03  7:38     ` Pritam Manohar Sutar
2025-09-29  6:46     ` Alim Akhtar
2025-09-29  6:46       ` Alim Akhtar
2025-09-03  7:38   ` [PATCH v8 4/6] phy: exynos5-usbdrd: support HS combo phy for ExynosAutov920 Pritam Manohar Sutar
2025-09-03  7:38     ` Pritam Manohar Sutar
2025-09-29  6:48     ` Alim Akhtar
2025-09-29  6:48       ` Alim Akhtar
2025-09-03  7:38   ` [PATCH v8 5/6] dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 combo ssphy Pritam Manohar Sutar
2025-09-03  7:38     ` Pritam Manohar Sutar
2025-09-29  6:49     ` Alim Akhtar
2025-09-29  6:49       ` Alim Akhtar
2025-09-03  7:38   ` [PATCH v8 6/6] phy: exynos5-usbdrd: support SS combo phy for ExynosAutov920 Pritam Manohar Sutar
2025-09-03  7:38     ` Pritam Manohar Sutar
2025-09-29  6:49     ` Alim Akhtar
2025-09-29  6:49       ` Alim Akhtar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000001dc1d70$aebf7d80$0c3e7880$@samsung.com' \
    --to=pritam.sutar@samsung.com \
    --cc=alim.akhtar@samsung.com \
    --cc=andre.draszik@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=dev.tailor@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=faraz.ata@samsung.com \
    --cc=igor.belwon@mentallysanemainliners.org \
    --cc=ivo.ivanov.ivanov1@gmail.com \
    --cc=kauschluss@disroot.org \
    --cc=kishon@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=muhammed.ali@samsung.com \
    --cc=peter.griffin@linaro.org \
    --cc=robh@kernel.org \
    --cc=rosa.pila@samsung.com \
    --cc=s.nawrocki@samsung.com \
    --cc=selvarasu.g@samsung.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.