All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jingoo Han" <jingoohan1@gmail.com>
To: 'Krzysztof Kozlowski' <k.kozlowski@samsung.com>
Cc: 'Inki Dae' <inki.dae@samsung.com>,
	'Joonyoung Shim' <jy0922.shim@samsung.com>,
	'Seung-Woo Kim' <sw0312.kim@samsung.com>,
	'Kyungmin Park' <kyungmin.park@samsung.com>,
	'David Airlie' <airlied@linux.ie>,
	'Kukjin Kim' <kgene.kim@samsung.com>,
	dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/exynos: dp: Lower level of EDID read success message
Date: Tue, 19 May 2015 08:30:14 +0900	[thread overview]
Message-ID: <000101d091c2$9c1d1920$d4574b60$@com> (raw)

> Don't pollute the dmesg with EDID read success message as an error.
> Printing as debug should be fine.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Right, dev_err() is not right.
Thank you for sending the patch.

Acked-by: Jingoo Han <jingoohan1@gmail.com>

Best regards,
Jingoo Han

> ---
>  drivers/gpu/drm/exynos/exynos_dp_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c
> index 441ef06b8894..30feb7d06624 100644
> --- a/drivers/gpu/drm/exynos/exynos_dp_core.c
> +++ b/drivers/gpu/drm/exynos/exynos_dp_core.c
> @@ -195,7 +195,7 @@ static int exynos_dp_read_edid(struct exynos_dp_device *dp)
>  		}
>  	}
>  
> -	dev_err(dp->dev, "EDID Read success!\n");
> +	dev_dbg(dp->dev, "EDID Read success!\n");
>  	return 0;
>  }
>  
> -- 
> 1.9.1

WARNING: multiple messages have this Message-ID (diff)
From: "Jingoo Han" <jingoohan1@gmail.com>
To: "'Krzysztof Kozlowski'" <k.kozlowski@samsung.com>
Cc: "'Inki Dae'" <inki.dae@samsung.com>,
	"'Joonyoung Shim'" <jy0922.shim@samsung.com>,
	"'Seung-Woo Kim'" <sw0312.kim@samsung.com>,
	"'Kyungmin Park'" <kyungmin.park@samsung.com>,
	"'David Airlie'" <airlied@linux.ie>,
	"'Kukjin Kim'" <kgene.kim@samsung.com>,
	<dri-devel@lists.freedesktop.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-samsung-soc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/exynos: dp: Lower level of EDID read success message
Date: Tue, 19 May 2015 08:30:14 +0900	[thread overview]
Message-ID: <000101d091c2$9c1d1920$d4574b60$@com> (raw)

> Don't pollute the dmesg with EDID read success message as an error.
> Printing as debug should be fine.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Right, dev_err() is not right.
Thank you for sending the patch.

Acked-by: Jingoo Han <jingoohan1@gmail.com>

Best regards,
Jingoo Han

> ---
>  drivers/gpu/drm/exynos/exynos_dp_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c
> index 441ef06b8894..30feb7d06624 100644
> --- a/drivers/gpu/drm/exynos/exynos_dp_core.c
> +++ b/drivers/gpu/drm/exynos/exynos_dp_core.c
> @@ -195,7 +195,7 @@ static int exynos_dp_read_edid(struct exynos_dp_device *dp)
>  		}
>  	}
>  
> -	dev_err(dp->dev, "EDID Read success!\n");
> +	dev_dbg(dp->dev, "EDID Read success!\n");
>  	return 0;
>  }
>  
> -- 
> 1.9.1


             reply	other threads:[~2015-05-18 23:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-18 23:30 Jingoo Han [this message]
2015-05-18 23:30 ` [PATCH] drm/exynos: dp: Lower level of EDID read success message Jingoo Han
  -- strict thread matches above, loose matches on Subject: below --
2015-05-14  0:03 Krzysztof Kozlowski
2015-05-14  0:03 ` Krzysztof Kozlowski
2015-05-14  0:03 ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000101d091c2$9c1d1920$d4574b60$@com' \
    --to=jingoohan1@gmail.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=inki.dae@samsung.com \
    --cc=jy0922.shim@samsung.com \
    --cc=k.kozlowski@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=sw0312.kim@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.