From: "Jingoo Han" <jingoohan1@gmail.com>
To: "'Gustavo Pimentel'" <gustavo.pimentel@synopsys.com>,
<bhelgaas@google.com>, <lorenzo.pieralisi@arm.com>,
<Joao.Pinto@synopsys.com>, <kishon@ti.com>, <robh+dt@kernel.org>,
<mark.rutland@arm.com>
Cc: <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 9/9] PCI: dwc: Replace magic number by defines
Date: Tue, 10 Apr 2018 20:07:33 -0400 [thread overview]
Message-ID: <000101d3d129$17847f60$468d7e20$@gmail.com> (raw)
In-Reply-To: <e16abfbbb45aff6f45d5e6821d2dc23cf4d61783.1523266508.git.gustavo.pimentel@synopsys.com>
On Monday, April 9, 2018 5:41 AM, Gustavo Pimentel wrote:
>
> Replace magic numbers by a well known define in order to make the code
> human readable and also facilitate the code reusability.
>
> Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
Acked-by: Jingoo Han <jingoohan1@gmail.com>
> ---
> Change v1->v2:
> - Nothing changed, just to follow the patch set version.
>
> drivers/pci/dwc/pcie-designware-host.c | 34 ++++++++++++++++++++---------
> -----
> drivers/pci/dwc/pcie-designware.h | 1 +
> 2 files changed, 21 insertions(+), 14 deletions(-)
>
[.....]
WARNING: multiple messages have this Message-ID (diff)
From: "Jingoo Han" <jingoohan1@gmail.com>
To: 'Gustavo Pimentel' <gustavo.pimentel@synopsys.com>,
bhelgaas@google.com, lorenzo.pieralisi@arm.com,
Joao.Pinto@synopsys.com, kishon@ti.com, robh+dt@kernel.org,
mark.rutland@arm.com
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 9/9] PCI: dwc: Replace magic number by defines
Date: Tue, 10 Apr 2018 20:07:33 -0400 [thread overview]
Message-ID: <000101d3d129$17847f60$468d7e20$@gmail.com> (raw)
In-Reply-To: <e16abfbbb45aff6f45d5e6821d2dc23cf4d61783.1523266508.git.gustavo.pimentel@synopsys.com>
On Monday, April 9, 2018 5:41 AM, Gustavo Pimentel wrote:
>
> Replace magic numbers by a well known define in order to make the code
> human readable and also facilitate the code reusability.
>
> Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
Acked-by: Jingoo Han <jingoohan1@gmail.com>
> ---
> Change v1->v2:
> - Nothing changed, just to follow the patch set version.
>
> drivers/pci/dwc/pcie-designware-host.c | 34 ++++++++++++++++++++---------
> -----
> drivers/pci/dwc/pcie-designware.h | 1 +
> 2 files changed, 21 insertions(+), 14 deletions(-)
>
[.....]
next prev parent reply other threads:[~2018-04-11 0:07 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 9:41 [PATCH v2 0/9] Designware EP support and code clean up Gustavo Pimentel
2018-04-09 9:41 ` [PATCH v2 1/9] bindings: PCI: designware: Example update Gustavo Pimentel
2018-04-09 9:41 ` [PATCH v2 2/9] PCI: dwc: Add support for endpoint mode Gustavo Pimentel
2018-04-10 5:12 ` Kishon Vijay Abraham I
2018-04-10 5:12 ` Kishon Vijay Abraham I
2018-04-10 10:36 ` Gustavo Pimentel
2018-04-10 11:09 ` Kishon Vijay Abraham I
2018-04-09 9:41 ` [PATCH v2 3/9] bindings: PCI: designware: Add support for the EP in Designware driver Gustavo Pimentel
2018-04-09 9:41 ` [PATCH v2 4/9] PCI: Adds device ID for Synopsys Sample Endpoint Gustavo Pimentel
2018-04-09 9:41 ` [PATCH v2 5/9] misc: pci_endpoint_test: Add designware EP entry Gustavo Pimentel
2018-04-09 9:41 ` [PATCH v2 6/9] PCI: dwc: Define maximum number of vectors Gustavo Pimentel
2018-04-09 16:03 ` Lorenzo Pieralisi
2018-04-10 7:59 ` Gustavo Pimentel
2018-04-10 9:56 ` Lorenzo Pieralisi
2018-04-09 9:41 ` [PATCH v2 7/9] PCI: dwc: Replace lower into upper case characters Gustavo Pimentel
2018-04-09 10:25 ` Joe Perches
2018-04-09 13:10 ` Gustavo Pimentel
2018-04-09 14:25 ` Joe Perches
2018-04-11 0:05 ` Jingoo Han
2018-04-11 0:05 ` Jingoo Han
2018-04-09 9:41 ` [PATCH v2 8/9] PCI: dwc: Small computation improvement Gustavo Pimentel
2018-04-11 0:01 ` Jingoo Han
2018-04-11 0:01 ` Jingoo Han
2018-04-11 7:40 ` Gustavo Pimentel
2018-04-11 19:37 ` Jingoo Han
2018-04-11 19:37 ` Jingoo Han
2018-04-16 8:41 ` Gustavo Pimentel
2018-04-15 13:09 ` Fabio Estevam
2018-04-16 8:35 ` Gustavo Pimentel
2018-04-09 9:41 ` [PATCH v2 9/9] PCI: dwc: Replace magic number by defines Gustavo Pimentel
2018-04-11 0:07 ` Jingoo Han [this message]
2018-04-11 0:07 ` Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000101d3d129$17847f60$468d7e20$@gmail.com' \
--to=jingoohan1@gmail.com \
--cc=Joao.Pinto@synopsys.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=gustavo.pimentel@synopsys.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.