* [PATCH 2/3] net: phy: mdio: add missing __iomem annotation
@ 2013-08-06 8:32 Jingoo Han
2013-08-07 23:59 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-08-06 8:32 UTC (permalink / raw)
To: 'David S. Miller'; +Cc: netdev, 'Timur Tabi', Jingoo Han
Added missing __iomem annotation in order to fix the following
sparse warnings:
drivers/net/phy/mdio-mux-mmioreg.c:51:27: warning: incorrect type in initializer (different address spaces)
drivers/net/phy/mdio-mux-mmioreg.c:51:27: expected void *p
drivers/net/phy/mdio-mux-mmioreg.c:51:27: got void [noderef] <asn:2>*
drivers/net/phy/mdio-mux-mmioreg.c:57:21: warning: incorrect type in argument 1 (different address spaces)
drivers/net/phy/mdio-mux-mmioreg.c:57:21: expected void const volatile [noderef] <asn:2>*addr
drivers/net/phy/mdio-mux-mmioreg.c:57:21: got void *p
drivers/net/phy/mdio-mux-mmioreg.c:60:25: warning: incorrect type in argument 2 (different address spaces)
drivers/net/phy/mdio-mux-mmioreg.c:60:25: expected void volatile [noderef] <asn:2>*addr
drivers/net/phy/mdio-mux-mmioreg.c:60:25: got void *p
drivers/net/phy/mdio-mux-mmioreg.c:64:25: warning: incorrect type in argument 1 (different address spaces)
drivers/net/phy/mdio-mux-mmioreg.c:64:25: expected void volatile [noderef] <asn:2>*addr
drivers/net/phy/mdio-mux-mmioreg.c:64:25: got void *p
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/phy/mdio-mux-mmioreg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/mdio-mux-mmioreg.c b/drivers/net/phy/mdio-mux-mmioreg.c
index 9733bd2..f8e305d 100644
--- a/drivers/net/phy/mdio-mux-mmioreg.c
+++ b/drivers/net/phy/mdio-mux-mmioreg.c
@@ -48,7 +48,7 @@ static int mdio_mux_mmioreg_switch_fn(int current_child, int desired_child,
struct mdio_mux_mmioreg_state *s = data;
if (current_child ^ desired_child) {
- void *p = ioremap(s->phys, 1);
+ void __iomem *p = ioremap(s->phys, 1);
uint8_t x, y;
if (!p)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/3] net: phy: mdio: add missing __iomem annotation
2013-08-06 8:32 [PATCH 2/3] net: phy: mdio: add missing __iomem annotation Jingoo Han
@ 2013-08-07 23:59 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-08-07 23:59 UTC (permalink / raw)
To: jg1.han; +Cc: netdev, timur
From: Jingoo Han <jg1.han@samsung.com>
Date: Tue, 06 Aug 2013 17:32:58 +0900
> Added missing __iomem annotation in order to fix the following
> sparse warnings:
>
> drivers/net/phy/mdio-mux-mmioreg.c:51:27: warning: incorrect type in initializer (different address spaces)
> drivers/net/phy/mdio-mux-mmioreg.c:51:27: expected void *p
> drivers/net/phy/mdio-mux-mmioreg.c:51:27: got void [noderef] <asn:2>*
> drivers/net/phy/mdio-mux-mmioreg.c:57:21: warning: incorrect type in argument 1 (different address spaces)
> drivers/net/phy/mdio-mux-mmioreg.c:57:21: expected void const volatile [noderef] <asn:2>*addr
> drivers/net/phy/mdio-mux-mmioreg.c:57:21: got void *p
> drivers/net/phy/mdio-mux-mmioreg.c:60:25: warning: incorrect type in argument 2 (different address spaces)
> drivers/net/phy/mdio-mux-mmioreg.c:60:25: expected void volatile [noderef] <asn:2>*addr
> drivers/net/phy/mdio-mux-mmioreg.c:60:25: got void *p
> drivers/net/phy/mdio-mux-mmioreg.c:64:25: warning: incorrect type in argument 1 (different address spaces)
> drivers/net/phy/mdio-mux-mmioreg.c:64:25: expected void volatile [noderef] <asn:2>*addr
> drivers/net/phy/mdio-mux-mmioreg.c:64:25: got void *p
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-07 23:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-06 8:32 [PATCH 2/3] net: phy: mdio: add missing __iomem annotation Jingoo Han
2013-08-07 23:59 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.