* RE: [PATCH] infiniband:cxgb4:Fix concurrent access issue in the function send_mpa_reply [not found] <1437014271-26020-1-git-send-email-xerofoify@gmail.com> @ 2015-07-16 14:20 ` Steve Wise 0 siblings, 0 replies; 2+ messages in thread From: Steve Wise @ 2015-07-16 14:20 UTC (permalink / raw) To: 'Nicholas Krause', swise Cc: dledford, sean.hefty, hal.rosenstock, linux-rdma, linux-kernel > -----Original Message----- > From: Nicholas Krause [mailto:xerofoify@gmail.com] > Sent: Wednesday, July 15, 2015 9:38 PM > To: swise@chelsio.com > Cc: dledford@redhat.com; sean.hefty@intel.com; hal.rosenstock@gmail.com; linux-rdma@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [PATCH] infiniband:cxgb4:Fix concurrent access issue in the function send_mpa_reply > > This fixes a concurrent access issue in the function send_mpa_reply > when calling the non wrapper function set_state on the structure > pointer ep's member com due to us not locking the mutex lock for > this structure pointer and thus avoid concurrent access issues > by here by using the wrapper version of set_state that properly > locks the mutex lock for us. > > Signed-off-by: Nicholas Krause <xerofoify@gmail.com> > --- > drivers/infiniband/hw/cxgb4/cm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c > index 3ad8dc7..0b46b99 100644 > --- a/drivers/infiniband/hw/cxgb4/cm.c > +++ b/drivers/infiniband/hw/cxgb4/cm.c > @@ -1048,7 +1048,7 @@ static int send_mpa_reply(struct c4iw_ep *ep, const void *pdata, u8 plen) > skb_get(skb); > t4_set_arp_err_handler(skb, NULL, arp_failure_discard); > ep->mpa_skb = skb; > - __state_set(&ep->com, MPA_REP_SENT); > + state_set(&ep->com, MPA_REP_SENT); > ep->snd_seq += mpalen; > return c4iw_l2t_send(&ep->com.dev->rdev, skb, ep->l2t); > } > -- send_mpa_reply() is called with the ep mutex held. See c4iw_accept_cr(). ^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [PATCH] infiniband:cxgb4:Fix concurrent access issue in the function send_mpa_reply @ 2015-07-16 14:20 ` Steve Wise 0 siblings, 0 replies; 2+ messages in thread From: Steve Wise @ 2015-07-16 14:20 UTC (permalink / raw) To: 'Nicholas Krause', swise Cc: dledford, sean.hefty, hal.rosenstock, linux-rdma, linux-kernel > -----Original Message----- > From: Nicholas Krause [mailto:xerofoify@gmail.com] > Sent: Wednesday, July 15, 2015 9:38 PM > To: swise@chelsio.com > Cc: dledford@redhat.com; sean.hefty@intel.com; hal.rosenstock@gmail.com; linux-rdma@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [PATCH] infiniband:cxgb4:Fix concurrent access issue in the function send_mpa_reply > > This fixes a concurrent access issue in the function send_mpa_reply > when calling the non wrapper function set_state on the structure > pointer ep's member com due to us not locking the mutex lock for > this structure pointer and thus avoid concurrent access issues > by here by using the wrapper version of set_state that properly > locks the mutex lock for us. > > Signed-off-by: Nicholas Krause <xerofoify@gmail.com> > --- > drivers/infiniband/hw/cxgb4/cm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c > index 3ad8dc7..0b46b99 100644 > --- a/drivers/infiniband/hw/cxgb4/cm.c > +++ b/drivers/infiniband/hw/cxgb4/cm.c > @@ -1048,7 +1048,7 @@ static int send_mpa_reply(struct c4iw_ep *ep, const void *pdata, u8 plen) > skb_get(skb); > t4_set_arp_err_handler(skb, NULL, arp_failure_discard); > ep->mpa_skb = skb; > - __state_set(&ep->com, MPA_REP_SENT); > + state_set(&ep->com, MPA_REP_SENT); > ep->snd_seq += mpalen; > return c4iw_l2t_send(&ep->com.dev->rdev, skb, ep->l2t); > } > -- send_mpa_reply() is called with the ep mutex held. See c4iw_accept_cr(). ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-16 14:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1437014271-26020-1-git-send-email-xerofoify@gmail.com>
2015-07-16 14:20 ` [PATCH] infiniband:cxgb4:Fix concurrent access issue in the function send_mpa_reply Steve Wise
2015-07-16 14:20 ` Steve Wise
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.